From 910661e75c46358f50d0d3321622a163da864c64 Mon Sep 17 00:00:00 2001 From: Jason Rasmussen Date: Thu, 19 Jun 2025 11:35:09 -0400 Subject: [PATCH] chore: remove unused mocks (#19299) --- server/src/services/duplicate.service.spec.ts | 4 ++-- server/src/services/library.service.spec.ts | 2 -- server/src/services/notification.service.spec.ts | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/server/src/services/duplicate.service.spec.ts b/server/src/services/duplicate.service.spec.ts index 4524a7cb68..b7d6d5fc96 100644 --- a/server/src/services/duplicate.service.spec.ts +++ b/server/src/services/duplicate.service.spec.ts @@ -151,11 +151,11 @@ describe(SearchService.name, () => { }, }); const id = assetStub.livePhotoMotionAsset.id; - mocks.asset.getById.mockResolvedValue(assetStub.livePhotoMotionAsset); const result = await sut.handleSearchDuplicates({ id }); expect(result).toBe(JobStatus.SKIPPED); + expect(mocks.assetJob.getForSearchDuplicatesJob).not.toHaveBeenCalled(); }); it('should skip if duplicate detection is disabled', async () => { @@ -168,11 +168,11 @@ describe(SearchService.name, () => { }, }); const id = assetStub.livePhotoMotionAsset.id; - mocks.asset.getById.mockResolvedValue(assetStub.livePhotoMotionAsset); const result = await sut.handleSearchDuplicates({ id }); expect(result).toBe(JobStatus.SKIPPED); + expect(mocks.assetJob.getForSearchDuplicatesJob).not.toHaveBeenCalled(); }); it('should fail if asset is not found', async () => { diff --git a/server/src/services/library.service.spec.ts b/server/src/services/library.service.spec.ts index 6b0817dd3b..e92cdcf200 100644 --- a/server/src/services/library.service.spec.ts +++ b/server/src/services/library.service.spec.ts @@ -1113,8 +1113,6 @@ describe(LibraryService.name, () => { mocks.library.get.mockResolvedValue(library); mocks.library.streamAssetIds.mockReturnValue(makeStream([assetStub.image1])); - mocks.asset.getById.mockResolvedValue(assetStub.image1); - await expect(sut.handleDeleteLibrary({ id: library.id })).resolves.toBe(JobStatus.SUCCESS); }); }); diff --git a/server/src/services/notification.service.spec.ts b/server/src/services/notification.service.spec.ts index b0f2a3ab62..c2a7712521 100644 --- a/server/src/services/notification.service.spec.ts +++ b/server/src/services/notification.service.spec.ts @@ -268,7 +268,7 @@ describe(NotificationService.name, () => { mocks.album.getById.mockResolvedValue(albumStub.empty); await expect(sut.handleAlbumInvite({ id: '', recipientId: '' })).resolves.toBe(JobStatus.SKIPPED); - expect(mocks.asset.getById).not.toHaveBeenCalled(); + expect(mocks.job.queue).not.toHaveBeenCalled(); }); it('should skip if the recipient has email notifications disabled', async () => {