fix: network criteria for upload LivePhotos (#21386)

This commit is contained in:
Alex 2025-08-30 13:45:42 -05:00 committed by GitHub
parent d6b8c0926f
commit aacb27ea5f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -278,13 +278,7 @@ class UploadService {
livePhotoVideoId: '',
).toJson();
bool requiresWiFi = true;
if (asset.isVideo && _appSettingsService.getSetting(AppSettingsEnum.useCellularForUploadVideos)) {
requiresWiFi = false;
} else if (!asset.isVideo && _appSettingsService.getSetting(AppSettingsEnum.useCellularForUploadPhotos)) {
requiresWiFi = false;
}
final requiresWiFi = _shouldRequireWiFi(asset);
return buildUploadTask(
file,
@ -311,6 +305,8 @@ class UploadService {
final fields = {'livePhotoVideoId': livePhotoVideoId};
final requiresWiFi = _shouldRequireWiFi(asset);
return buildUploadTask(
file,
originalFileName: asset.name,
@ -319,9 +315,22 @@ class UploadService {
group: kBackupLivePhotoGroup,
priority: 0, // Highest priority to get upload immediately
isFavorite: asset.isFavorite,
requiresWiFi: requiresWiFi,
);
}
bool _shouldRequireWiFi(LocalAsset asset) {
bool requiresWiFi = true;
if (asset.isVideo && _appSettingsService.getSetting(AppSettingsEnum.useCellularForUploadVideos)) {
requiresWiFi = false;
} else if (!asset.isVideo && _appSettingsService.getSetting(AppSettingsEnum.useCellularForUploadPhotos)) {
requiresWiFi = false;
}
return requiresWiFi;
}
Future<UploadTask> buildUploadTask(
File file, {
required String group,