Cutlery/immich
1
0
Fork 1
mirror of https://github.com/immich-app/immich.git synced 2025-07-09 03:04:16 -04:00
Code Issues Packages Projects Releases Wiki Activity

refactor(server): sync service (#19559)

Browse Source
This commit is contained in:
Jason Rasmussen 2025-06-26 13:24:57 -04:00 committed by GitHub
parent 926ff075a3
commit b96c95beda
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
open-api/immich-openapi-specs.json
View File

@ -13425,6 +13425,7 @@
"properties": { "properties": {
"acks": { "acks": {
"items": { "items": {
"maxLength": 1000,
"type": "string" "type": "string"
}, },
"type": "array" "type": "array"

3
server/src/dtos/sync.dto.ts
View File

@ -1,5 +1,5 @@
import { ApiProperty } from '@nestjs/swagger'; import { ApiProperty } from '@nestjs/swagger';
import { IsEnum, IsInt, IsPositive, IsString } from 'class-validator'; import { IsEnum, IsInt, IsPositive, IsString, MaxLength } from 'class-validator';
import { AssetResponseDto } from 'src/dtos/asset-response.dto'; import { AssetResponseDto } from 'src/dtos/asset-response.dto';
import { AlbumUserRole, AssetOrder, AssetType, AssetVisibility, SyncEntityType, SyncRequestType } from 'src/enum'; import { AlbumUserRole, AssetOrder, AssetType, AssetVisibility, SyncEntityType, SyncRequestType } from 'src/enum';
import { Optional, ValidateDate, ValidateUUID } from 'src/validation'; import { Optional, ValidateDate, ValidateUUID } from 'src/validation';
@ -217,6 +217,7 @@ export class SyncAckDto {
} }
export class SyncAckSetDto { export class SyncAckSetDto {
@MaxLength(1000)
@IsString({ each: true }) @IsString({ each: true })
acks!: string[]; acks!: string[];
} }

5
server/src/services/sync.service.ts
View File

@ -96,10 +96,7 @@ export class SyncService extends BaseService {
throw new BadRequestException(`Invalid ack type: ${type}`); throw new BadRequestException(`Invalid ack type: ${type}`);
} }
if (checkpoints[type]) { // TODO pick the latest ack for each type, instead of using the last one
throw new BadRequestException('Only one ack per type is allowed');
}
checkpoints[type] = { sessionId, type, ack }; checkpoints[type] = { sessionId, type, ack };
} }