From b97d73d7a7f7cd37b12ffcaf0acfd6192959ce71 Mon Sep 17 00:00:00 2001
From: bo0tzz <git@bo0tzz.me>
Date: Wed, 10 Sep 2025 03:46:59 +0200
Subject: [PATCH] fix: handle missing checkbox in close-dupes (#21689)

---
 .github/workflows/close-duplicates.yml | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/close-duplicates.yml b/.github/workflows/close-duplicates.yml
index 3237a84765..d9ac98aa2d 100644
--- a/.github/workflows/close-duplicates.yml
+++ b/.github/workflows/close-duplicates.yml
@@ -37,20 +37,19 @@ jobs:
     container:
       image: yshavit/mdq:0.9.0@sha256:4399483ca857fb1a7ed28a596f754c7373e358647de31ce14b79a27c91e1e35e
     outputs:
-      json: ${{ steps.get_checkbox.outputs.json }}
+      checked: ${{ steps.get_checkbox.outputs.checked }}
     steps:
       - id: get_checkbox
         env:
           BODY: ${{ needs.get_body.outputs.body }}
-        # TODO: We should detect if the checkbox is missing entirely and also close_and_comment in that case.
         run: |
-          JSON=$(echo "$BODY" | base64 -d | /mdq --output json '# I have searched | - [?] Yes')
-          echo "json=$JSON" >> $GITHUB_OUTPUT
+          CHECKED=$(echo "$BODY" | base64 -d | /mdq --output json '# I have searched | - [?] Yes' | jq '.items[0].list[0].checked // false')
+          echo "checked=$CHECKED" >> $GITHUB_OUTPUT
 
   close_and_comment:
     runs-on: ubuntu-latest
     needs: [get_checkbox_json, should_run]
-    if: ${{ needs.should_run.outputs.should_run == 'true' && !fromJSON(needs.get_checkbox_json.outputs.json).items[0].list[0].checked }}
+    if: ${{ needs.should_run.outputs.should_run == 'true' && needs.get_checkbox_json.outputs.checked != 'true' }}
     permissions:
       issues: write
       discussions: write