fix: change all download icons to mdiDownload for clarity and consistency (#20821)

change all download icons to `mdiDownload` for clarity and consistency
This commit is contained in:
Nicholas 2025-08-10 22:23:21 -04:00 committed by GitHub
parent 4b9019e762
commit d6d31c6695
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
6 changed files with 14 additions and 16 deletions

View File

@ -14,7 +14,7 @@
import { fileUploadHandler, openFileUploadDialog } from '$lib/utils/file-uploader'; import { fileUploadHandler, openFileUploadDialog } from '$lib/utils/file-uploader';
import type { AlbumResponseDto, SharedLinkResponseDto, UserResponseDto } from '@immich/sdk'; import type { AlbumResponseDto, SharedLinkResponseDto, UserResponseDto } from '@immich/sdk';
import { IconButton } from '@immich/ui'; import { IconButton } from '@immich/ui';
import { mdiFileImagePlusOutline, mdiFolderDownloadOutline } from '@mdi/js'; import { mdiDownload, mdiFileImagePlusOutline } from '@mdi/js';
import { onDestroy } from 'svelte'; import { onDestroy } from 'svelte';
import { t } from 'svelte-i18n'; import { t } from 'svelte-i18n';
import DownloadAction from '../photos-page/actions/download-action.svelte'; import DownloadAction from '../photos-page/actions/download-action.svelte';
@ -125,7 +125,7 @@
variant="ghost" variant="ghost"
aria-label={$t('download')} aria-label={$t('download')}
onclick={() => downloadAlbum(album)} onclick={() => downloadAlbum(album)}
icon={mdiFolderDownloadOutline} icon={mdiDownload}
/> />
{/if} {/if}
{#if sharedLink.showMetadata && $featureFlags.loaded && $featureFlags.map} {#if sharedLink.showMetadata && $featureFlags.loaded && $featureFlags.map}

View File

@ -38,7 +38,7 @@
import { normalizeSearchString } from '$lib/utils/string-utils'; import { normalizeSearchString } from '$lib/utils/string-utils';
import { addUsersToAlbum, deleteAlbum, isHttpError, type AlbumResponseDto, type AlbumUserAddDto } from '@immich/sdk'; import { addUsersToAlbum, deleteAlbum, isHttpError, type AlbumResponseDto, type AlbumUserAddDto } from '@immich/sdk';
import { modalManager } from '@immich/ui'; import { modalManager } from '@immich/ui';
import { mdiDeleteOutline, mdiFolderDownloadOutline, mdiRenameOutline, mdiShareVariantOutline } from '@mdi/js'; import { mdiDeleteOutline, mdiDownload, mdiRenameOutline, mdiShareVariantOutline } from '@mdi/js';
import { groupBy } from 'lodash-es'; import { groupBy } from 'lodash-es';
import { onMount, type Snippet } from 'svelte'; import { onMount, type Snippet } from 'svelte';
import { t } from 'svelte-i18n'; import { t } from 'svelte-i18n';
@ -419,7 +419,7 @@
/> />
<MenuOption icon={mdiShareVariantOutline} text={$t('share')} onClick={() => openShareModal()} /> <MenuOption icon={mdiShareVariantOutline} text={$t('share')} onClick={() => openShareModal()} />
{/if} {/if}
<MenuOption icon={mdiFolderDownloadOutline} text={$t('download')} onClick={() => handleDownloadAlbum()} /> <MenuOption icon={mdiDownload} text={$t('download')} onClick={() => handleDownloadAlbum()} />
{#if showFullContextMenu} {#if showFullContextMenu}
<MenuOption icon={mdiDeleteOutline} text={$t('delete')} onClick={() => setAlbumToDelete()} /> <MenuOption icon={mdiDeleteOutline} text={$t('delete')} onClick={() => setAlbumToDelete()} />
{/if} {/if}

View File

@ -6,7 +6,7 @@
import { downloadFile } from '$lib/utils/asset-utils'; import { downloadFile } from '$lib/utils/asset-utils';
import { getAssetInfo } from '@immich/sdk'; import { getAssetInfo } from '@immich/sdk';
import { IconButton } from '@immich/ui'; import { IconButton } from '@immich/ui';
import { mdiFolderDownloadOutline } from '@mdi/js'; import { mdiDownload } from '@mdi/js';
import { t } from 'svelte-i18n'; import { t } from 'svelte-i18n';
interface Props { interface Props {
@ -26,10 +26,10 @@
color="secondary" color="secondary"
shape="round" shape="round"
variant="ghost" variant="ghost"
icon={mdiFolderDownloadOutline} icon={mdiDownload}
aria-label={$t('download')} aria-label={$t('download')}
onclick={onDownloadFile} onclick={onDownloadFile}
/> />
{:else} {:else}
<MenuOption icon={mdiFolderDownloadOutline} text={$t('download')} onClick={onDownloadFile} /> <MenuOption icon={mdiDownload} text={$t('download')} onClick={onDownloadFile} />
{/if} {/if}

View File

@ -5,7 +5,7 @@
import { downloadArchive, downloadFile } from '$lib/utils/asset-utils'; import { downloadArchive, downloadFile } from '$lib/utils/asset-utils';
import { getAssetInfo } from '@immich/sdk'; import { getAssetInfo } from '@immich/sdk';
import { IconButton } from '@immich/ui'; import { IconButton } from '@immich/ui';
import { mdiCloudDownloadOutline, mdiFileDownloadOutline, mdiFolderDownloadOutline } from '@mdi/js'; import { mdiDownload } from '@mdi/js';
import { t } from 'svelte-i18n'; import { t } from 'svelte-i18n';
import MenuOption from '../../shared-components/context-menu/menu-option.svelte'; import MenuOption from '../../shared-components/context-menu/menu-option.svelte';
import { getAssetControlContext } from '../asset-select-control-bar.svelte'; import { getAssetControlContext } from '../asset-select-control-bar.svelte';
@ -31,21 +31,19 @@
clearSelect(); clearSelect();
await downloadArchive(filename, { assetIds: assets.map((asset) => asset.id) }); await downloadArchive(filename, { assetIds: assets.map((asset) => asset.id) });
}; };
let menuItemIcon = $derived(getAssets().length === 1 ? mdiFileDownloadOutline : mdiFolderDownloadOutline);
</script> </script>
<svelte:document use:shortcut={{ shortcut: { key: 'd', shift: true }, onShortcut: handleDownloadFiles }} /> <svelte:document use:shortcut={{ shortcut: { key: 'd', shift: true }, onShortcut: handleDownloadFiles }} />
{#if menuItem} {#if menuItem}
<MenuOption text={$t('download')} icon={menuItemIcon} onClick={handleDownloadFiles} /> <MenuOption text={$t('download')} icon={mdiDownload} onClick={handleDownloadFiles} />
{:else} {:else}
<IconButton <IconButton
shape="round" shape="round"
color="secondary" color="secondary"
variant="ghost" variant="ghost"
aria-label={$t('download')} aria-label={$t('download')}
icon={mdiCloudDownloadOutline} icon={mdiDownload}
onclick={handleDownloadFiles} onclick={handleDownloadFiles}
/> />
{/if} {/if}

View File

@ -14,7 +14,7 @@
import { toTimelineAsset } from '$lib/utils/timeline-util'; import { toTimelineAsset } from '$lib/utils/timeline-util';
import { addSharedLinkAssets, getAssetInfo, type SharedLinkResponseDto } from '@immich/sdk'; import { addSharedLinkAssets, getAssetInfo, type SharedLinkResponseDto } from '@immich/sdk';
import { IconButton } from '@immich/ui'; import { IconButton } from '@immich/ui';
import { mdiArrowLeft, mdiFileImagePlusOutline, mdiFolderDownloadOutline, mdiSelectAll } from '@mdi/js'; import { mdiArrowLeft, mdiDownload, mdiFileImagePlusOutline, mdiSelectAll } from '@mdi/js';
import { t } from 'svelte-i18n'; import { t } from 'svelte-i18n';
import AssetViewer from '../asset-viewer/asset-viewer.svelte'; import AssetViewer from '../asset-viewer/asset-viewer.svelte';
import DownloadAction from '../photos-page/actions/download-action.svelte'; import DownloadAction from '../photos-page/actions/download-action.svelte';
@ -135,7 +135,7 @@
variant="ghost" variant="ghost"
aria-label={$t('download')} aria-label={$t('download')}
onclick={downloadAssets} onclick={downloadAssets}
icon={mdiFolderDownloadOutline} icon={mdiDownload}
/> />
{/if} {/if}
{/snippet} {/snippet}

View File

@ -75,7 +75,7 @@
mdiCogOutline, mdiCogOutline,
mdiDeleteOutline, mdiDeleteOutline,
mdiDotsVertical, mdiDotsVertical,
mdiFolderDownloadOutline, mdiDownload,
mdiImageOutline, mdiImageOutline,
mdiImagePlusOutline, mdiImagePlusOutline,
mdiLink, mdiLink,
@ -664,7 +664,7 @@
color="secondary" color="secondary"
aria-label={$t('download')} aria-label={$t('download')}
onclick={handleDownloadAlbum} onclick={handleDownloadAlbum}
icon={mdiFolderDownloadOutline} icon={mdiDownload}
/> />
{/if} {/if}