chore: code review changes

This commit is contained in:
bwees 2025-07-31 09:46:06 -05:00
parent 66deb80c36
commit d9fd3dc8d3
No known key found for this signature in database
4 changed files with 12 additions and 11 deletions

View File

@ -109,6 +109,7 @@ class LogService {
} }
Future<void> flush() { Future<void> flush() {
_flushTimer?.cancel();
return _flushBuffer(); return _flushBuffer();
} }

View File

@ -141,12 +141,14 @@ class DriftLogger extends $DriftLogger implements IDatabaseRepository {
@override @override
int get schemaVersion => 1; int get schemaVersion => 1;
}
class DriftLoggerDatabaseRepository implements IDatabaseRepository {
final DriftLogger _db;
const DriftLoggerDatabaseRepository(this._db);
@override @override
Future<T> transaction<T>(Future<T> Function() callback) => _db.transaction(callback); MigrationStrategy get migration => MigrationStrategy(
beforeOpen: (details) async {
await customStatement('PRAGMA foreign_keys = ON');
await customStatement('PRAGMA synchronous = NORMAL');
await customStatement('PRAGMA journal_mode = WAL');
await customStatement('PRAGMA busy_timeout = 500');
},
);
} }

View File

@ -31,9 +31,7 @@ class LogRepository extends DriftLoggerDatabaseRepository {
Future<List<LogMessage>> getAll() async { Future<List<LogMessage>> getAll() async {
final query = _db.logMessageEntity.select()..orderBy([(row) => OrderingTerm.desc(row.createdAt)]); final query = _db.logMessageEntity.select()..orderBy([(row) => OrderingTerm.desc(row.createdAt)]);
return query.map((log) { return query.map((log) => log.toDto()).get();
return log.toDto();
}).get();
} }
LogMessageEntityCompanion _toEntityCompanion(LogMessage log) { LogMessageEntityCompanion _toEntityCompanion(LogMessage log) {

View File

@ -65,7 +65,7 @@ class AppLogDetailPage extends HookConsumerWidget {
); );
} }
buildLogLogger(String logger) { buildLogContext(String logger) {
return Padding( return Padding(
padding: const EdgeInsets.all(8.0), padding: const EdgeInsets.all(8.0),
child: Column( child: Column(
@ -103,7 +103,7 @@ class AppLogDetailPage extends HookConsumerWidget {
children: [ children: [
buildTextWithCopyButton("MESSAGE", logMessage.message), buildTextWithCopyButton("MESSAGE", logMessage.message),
if (logMessage.error != null) buildTextWithCopyButton("DETAILS", logMessage.error.toString()), if (logMessage.error != null) buildTextWithCopyButton("DETAILS", logMessage.error.toString()),
if (logMessage.logger != null) buildLogLogger(logMessage.logger.toString()), if (logMessage.logger != null) buildLogContext(logMessage.logger.toString()),
if (logMessage.stack != null) buildTextWithCopyButton("STACK TRACE", logMessage.stack.toString()), if (logMessage.stack != null) buildTextWithCopyButton("STACK TRACE", logMessage.stack.toString()),
], ],
), ),