Cutlery/immich
1
0
Fork 1
mirror of https://github.com/immich-app/immich.git synced 2025-05-31 12:15:47 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(web): Fixed video unmutes when scrubbing (#9382)

Browse Source 
Fixed video unmutes when scrubbing

Co-authored-by: Tushar Harsora <tushar.harsora.harsora@oracle.com>
This commit is contained in:
Tushar Harsora 2024-05-11 01:58:21 +05:30 committed by GitHub
parent bb4843747b
commit dd8d7732de
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
web/src/lib/components/asset-viewer/video-native-viewer.svelte
View File

@ -1,5 +1,5 @@
<script lang="ts"> <script lang="ts">
import { videoViewerVolume } from '$lib/stores/preferences.store'; import { videoViewerVolume, videoViewerMuted } from '$lib/stores/preferences.store';
import { getAssetFileUrl, getAssetThumbnailUrl } from '$lib/utils'; import { getAssetFileUrl, getAssetThumbnailUrl } from '$lib/utils';
import { handleError } from '$lib/utils/handle-error'; import { handleError } from '$lib/utils/handle-error';
import { ThumbnailFormat } from '@immich/sdk'; import { ThumbnailFormat } from '@immich/sdk';
@ -17,9 +17,7 @@
const handleCanPlay = async (event: Event) => { const handleCanPlay = async (event: Event) => {
try { try {
const video = event.currentTarget as HTMLVideoElement; const video = event.currentTarget as HTMLVideoElement;
video.muted = true;
await video.play(); await video.play();
video.muted = false;
dispatch('onVideoStarted'); dispatch('onVideoStarted');
} catch (error) { } catch (error) {
handleError(error, 'Unable to play video'); handleError(error, 'Unable to play video');
@ -42,6 +40,7 @@
class="h-full object-contain" class="h-full object-contain"
on:canplay={handleCanPlay} on:canplay={handleCanPlay}
on:ended={() => dispatch('onVideoEnded')} on:ended={() => dispatch('onVideoEnded')}
bind:muted={$videoViewerMuted}
bind:volume={$videoViewerVolume} bind:volume={$videoViewerVolume}
poster={getAssetThumbnailUrl(assetId, ThumbnailFormat.Jpeg)} poster={getAssetThumbnailUrl(assetId, ThumbnailFormat.Jpeg)}
> >

1
web/src/lib/stores/preferences.store.ts
View File

@ -63,6 +63,7 @@ export const mapSettings = persisted<MapSettings>('map-settings', {
}); });
export const videoViewerVolume = persisted<number>('video-viewer-volume', 1, {}); export const videoViewerVolume = persisted<number>('video-viewer-volume', 1, {});
export const videoViewerMuted = persisted<boolean>('video-viewer-muted', false, {});
export const isShowDetail = persisted<boolean>('info-opened', false, {}); export const isShowDetail = persisted<boolean>('info-opened', false, {});