top 10 worst rebases of all time, 0/10

mobile/lib/infrastructure/repositories/asset_media.repository.dart

@@ -36,11 +36,7 @@ class AssetMediaRepository {
     }
   }
 
-  Future<Uint8List?> getThumbnail(
+  Future<Uint8List?> getThumbnail(String id, {int quality = 80, ui.Size size = const ui.Size.square(256)}) =>
-    String id, {
-    int quality = 80,
-    ui.Size size = const ui.Size.square(256),
-  }) =>
       AssetEntity(
         id: id,
         // The below fields are not used in thumbnailDataWithSize but are required
@@ -49,8 +45,5 @@ class AssetMediaRepository {
         typeInt: AssetType.image.index,
         width: size.width.toInt(),
         height: size.height.toInt(),
-      ).thumbnailDataWithSize(
+      ).thumbnailDataWithSize(ThumbnailSize(size.width.toInt(), size.height.toInt()), quality: quality);
-        ThumbnailSize(size.width.toInt(), size.height.toInt()),
-        quality: quality,
-      );
 }

mobile/lib/presentation/pages/drift_place.page.dart

@@ -164,9 +164,7 @@ class _PlaceTile extends StatelessWidget {
       onTap: () => context.pushRoute(DriftPlaceDetailRoute(place: place.$1)),
       title: Text(place.$1, style: context.textTheme.titleMedium?.copyWith(fontWeight: FontWeight.w500)),
       leading: ClipRRect(
-        borderRadius: const BorderRadius.all(
+        borderRadius: const BorderRadius.all(Radius.circular(20)),
-          Radius.circular(20),
-        ),
         child: Thumbnail(
           imageProvider: RemoteThumbProvider(assetId: place.$2),
           size: const Size(80, 80),

mobile/lib/presentation/widgets/album/album_selector.widget.dart

@@ -436,7 +436,11 @@ class _AlbumList extends ConsumerWidget {
               leading: album.thumbnailAssetId != null
                   ? ClipRRect(
                       borderRadius: const BorderRadius.all(Radius.circular(15)),
-                      child: SizedBox(width: 80, height: 80, child: Thumbnail(imageProvider: RemoteThumbProvider(assetId: album.thumbnailAssetId!))),
+                      child: SizedBox(
+                        width: 80,
+                        height: 80,
+                        child: Thumbnail(imageProvider: RemoteThumbProvider(assetId: album.thumbnailAssetId!)),
+                      ),
                     )
                   : SizedBox(
                       width: 80,

mobile/lib/presentation/widgets/asset_viewer/asset_viewer.page.dart

@@ -147,11 +147,7 @@ class _AssetViewerState extends ConsumerState<AssetViewer> {
     // Precache both thumbnail and full image for smooth transitions
     unawaited(
       Future.wait([
-        precacheImage(
+        precacheImage(getThumbnailImageProvider(asset: asset), context, onError: (_, __) {}),
-          getThumbnailImageProvider(asset: asset),
-          context,
-          onError: (_, __) {},
-        ),
         precacheImage(getFullImageProvider(asset, size: screenSize), context, onError: (_, __) {}),
       ]),
     );
@@ -481,10 +477,7 @@ class _AssetViewerState extends ConsumerState<AssetViewer> {
       width: double.infinity,
       height: double.infinity,
       color: backgroundColor,
-      child: Thumbnail.fromBaseAsset(
+      child: Thumbnail.fromBaseAsset(asset: asset, fit: BoxFit.contain),
-        asset: asset,
-        fit: BoxFit.contain,
-      ),
     );
   }
 
@@ -534,10 +527,7 @@ class _AssetViewerState extends ConsumerState<AssetViewer> {
         width: ctx.width,
         height: ctx.height,
         color: backgroundColor,
-        child: Thumbnail.fromBaseAsset(
+        child: Thumbnail.fromBaseAsset(asset: asset, fit: BoxFit.contain),
-          asset: asset,
-          fit: BoxFit.contain,
-        ),
       ),
     );
   }

mobile/lib/presentation/widgets/asset_viewer/asset_viewer.state.dart

@@ -93,10 +93,7 @@ class AssetViewerStateNotifier extends AutoDisposeNotifier<AssetViewerState> {
     if (showing == state.showingBottomSheet) {
       return;
     }
-    state = state.copyWith(
+    state = state.copyWith(showingBottomSheet: showing, showingControls: showing || state.showingControls);
-      showingBottomSheet: showing,
-      showingControls: showing || state.showingControls,
-    );
     if (showing) {
       ref.read(videoPlayerControlsProvider.notifier).pause();
     }

mobile/lib/presentation/widgets/images/image_provider.dart

@@ -32,10 +32,7 @@ ImageProvider getThumbnailImageProvider({
   String? remoteId,
   Size size = const Size.square(kTimelineThumbnailSize),
 }) {
-  assert(
+  assert(asset != null || remoteId != null, 'Either asset or remoteId must be provided');
-    asset != null || remoteId != null,
-    'Either asset or remoteId must be provided',
-  );
 
   if (remoteId != null) {
     return RemoteThumbProvider(assetId: remoteId);

mobile/lib/presentation/widgets/images/local_image_provider.dart

@@ -12,11 +12,7 @@ class LocalThumbProvider extends ImageProvider<LocalThumbProvider> {
   final Size size;
   final DateTime? updatedAt;
 
-  const LocalThumbProvider({
+  const LocalThumbProvider({required this.id, required this.size, this.updatedAt});
-    required this.id,
-    required this.size,
-    this.updatedAt,
-  });
 
   @override
   Future<LocalThumbProvider> obtainKey(ImageConfiguration configuration) {
@@ -24,10 +20,7 @@ class LocalThumbProvider extends ImageProvider<LocalThumbProvider> {
   }
 
   @override
-  ImageStreamCompleter loadImage(
+  ImageStreamCompleter loadImage(LocalThumbProvider key, ImageDecoderCallback decode) {
-    LocalThumbProvider key,
-    ImageDecoderCallback decode,
-  ) {
     return OneFrameImageStreamCompleter(
       _codec(key),
       informationCollector: () => <DiagnosticsNode>[
@@ -71,10 +64,7 @@ class LocalFullImageProvider extends ImageProvider<LocalFullImageProvider> {
   }
 
   @override
-  ImageStreamCompleter loadImage(
+  ImageStreamCompleter loadImage(LocalFullImageProvider key, ImageDecoderCallback decode) {
-    LocalFullImageProvider key,
-    ImageDecoderCallback decode,
-  ) {
     return OneFrameImageStreamCompleter(_codec(key));
   }
 

mobile/lib/presentation/widgets/images/thumbnail.widget.dart

@@ -41,8 +41,8 @@ class Thumbnail extends StatefulWidget {
     this.size = const ui.Size.square(kTimelineThumbnailSize),
     this.thumbhashMode = ThumbhashMode.enabled,
     super.key,
-  })  : blurhash = asset.thumbhash,
+  }) : blurhash = asset.thumbhash,
-        imageProvider = _getImageProviderFromAsset(asset, size);
+       imageProvider = _getImageProviderFromAsset(asset, size);
 
   Thumbnail.fromBaseAsset({
     required BaseAsset? asset,
@@ -50,11 +50,11 @@ class Thumbnail extends StatefulWidget {
     this.size = const ui.Size.square(kTimelineThumbnailSize),
     this.thumbhashMode = ThumbhashMode.enabled,
     super.key,
-  })  : blurhash = switch (asset) {
+  }) : blurhash = switch (asset) {
-          RemoteAsset() => asset.thumbHash,
+         RemoteAsset() => asset.thumbHash,
-          _ => null,
+         _ => null,
-        },
+       },
-        imageProvider = _getImageProviderFromBaseAsset(asset, size);
+       imageProvider = _getImageProviderFromBaseAsset(asset, size);
 
   static ImageProvider? _getImageProviderFromAsset(Asset asset, ui.Size size) {
     if (asset.localId != null) {
@@ -65,10 +65,7 @@ class Thumbnail extends StatefulWidget {
     return null;
   }
 
-  static ImageProvider? _getImageProviderFromBaseAsset(
+  static ImageProvider? _getImageProviderFromBaseAsset(BaseAsset? asset, ui.Size size) {
-    BaseAsset? asset,
-    ui.Size size,
-  ) {
     switch (asset) {
       case RemoteAsset():
         if (asset.localId != null) {
@@ -217,19 +214,12 @@ class _ThumbnailState extends State<Thumbnail> {
   Widget build(BuildContext context) {
     final colorScheme = context.colorScheme;
     final gradient = _gradientCache[colorScheme] ??= LinearGradient(
-      colors: [
+      colors: [colorScheme.surfaceContainer, colorScheme.surfaceContainer.darken(amount: .1)],
-        colorScheme.surfaceContainer,
-        colorScheme.surfaceContainer.darken(amount: .1),
-      ],
       begin: Alignment.topCenter,
       end: Alignment.bottomCenter,
     );
 
-    return _ThumbnailLeaf(
+    return _ThumbnailLeaf(image: _providerImage, fit: widget.fit, placeholderGradient: gradient);
-      image: _providerImage,
-      fit: widget.fit,
-      placeholderGradient: gradient,
-    );
   }
 
   @override
@@ -245,26 +235,15 @@ class _ThumbnailLeaf extends LeafRenderObjectWidget {
   final BoxFit fit;
   final Gradient placeholderGradient;
 
-  const _ThumbnailLeaf({
+  const _ThumbnailLeaf({required this.image, required this.fit, required this.placeholderGradient});
-    required this.image,
-    required this.fit,
-    required this.placeholderGradient,
-  });
 
   @override
   RenderObject createRenderObject(BuildContext context) {
-    return _ThumbnailRenderBox(
+    return _ThumbnailRenderBox(image: image, fit: fit, placeholderGradient: placeholderGradient);
-      image: image,
-      fit: fit,
-      placeholderGradient: placeholderGradient,
-    );
   }
 
   @override
-  void updateRenderObject(
+  void updateRenderObject(BuildContext context, _ThumbnailRenderBox renderObject) {
-    BuildContext context,
-    _ThumbnailRenderBox renderObject,
-  ) {
     renderObject.fit = fit;
     renderObject.image = image;
     renderObject.placeholderGradient = placeholderGradient;
@@ -285,14 +264,11 @@ class _ThumbnailRenderBox extends RenderBox {
   @override
   bool isRepaintBoundary = true;
 
-  _ThumbnailRenderBox({
+  _ThumbnailRenderBox({required ui.Image? image, required BoxFit fit, required Gradient placeholderGradient})
-    required ui.Image? image,
+    : _image = image,
-    required BoxFit fit,
+      _fit = fit,
-    required Gradient placeholderGradient,
+      _placeholderGradient = placeholderGradient,
-  })  : _image = image,
+      _lastImageRequest = DateTime.now();
-        _fit = fit,
-        _placeholderGradient = placeholderGradient,
-        _lastImageRequest = DateTime.now();
 
   @override
   void paint(PaintingContext context, Offset offset) {

mobile/lib/presentation/widgets/images/thumbnail_tile.widget.dart

@@ -74,10 +74,10 @@ class ThumbnailTile extends ConsumerWidget {
                     child: Thumbnail.fromBaseAsset(
                       asset: asset,
                       thumbhashMode: isScrubbing
-                              ? ThumbhashMode.only
+                          ? ThumbhashMode.only
                           : asset != null && asset.hasLocal
-                              ? ThumbhashMode.disabled
+                          ? ThumbhashMode.disabled
-                              : ThumbhashMode.enabled,
+                          : ThumbhashMode.enabled,
                     ),
                   ),
                 ),
@@ -86,23 +86,17 @@ class ThumbnailTile extends ConsumerWidget {
                       ? const Align(
                           alignment: Alignment.topRight,
                           child: Padding(
-                            padding: EdgeInsets.only(
+                            padding: EdgeInsets.only(right: 10.0, top: 24.0),
-                              right: 10.0,
-                              top: 24.0,
-                            ),
                             child: _TileOverlayIcon(Icons.burst_mode_rounded),
                           ),
                         )
                       : const Align(
                           alignment: Alignment.topRight,
                           child: Padding(
-                            padding: EdgeInsets.only(
+                            padding: EdgeInsets.only(right: 10.0, top: 6.0),
-                              right: 10.0,
-                              top: 6.0,
-                            ),
                             child: _TileOverlayIcon(Icons.burst_mode_rounded),
-                    ),
+                          ),
-                  ),
+                        ),
                 if (asset != null && asset.isVideo)
                   Align(
                     alignment: Alignment.topRight,

mobile/lib/presentation/widgets/memory/memory_card.widget.dart

@@ -102,10 +102,7 @@ class _BlurredBackdrop extends HookWidget {
       child: DecoratedBox(
         decoration: BoxDecoration(
           image: DecorationImage(
-            image: getFullImageProvider(
+            image: getFullImageProvider(asset, size: Size(context.width, context.height)),
-              asset,
-              size: Size(context.width, context.height),
-            ),
             fit: BoxFit.cover,
           ),
         ),

mobile/lib/presentation/widgets/memory/memory_lane.widget.dart

@@ -57,15 +57,8 @@ class DriftMemoryCard extends ConsumerWidget {
       child: Stack(
         children: [
           ColorFiltered(
-            colorFilter: ColorFilter.mode(
+            colorFilter: ColorFilter.mode(Colors.black.withValues(alpha: 0.2), BlendMode.darken),
-              Colors.black.withValues(alpha: 0.2),
+            child: SizedBox(width: 205, height: 200, child: Thumbnail.fromBaseAsset(asset: memory.assets[0])),
-              BlendMode.darken,
-            ),
-            child: SizedBox(
-              width: 205,
-              height: 200,
-              child: Thumbnail.fromBaseAsset(asset: memory.assets[0]),
-            ),
           ),
           Positioned(
             bottom: 16,

mobile/lib/presentation/widgets/timeline/fixed/segment.model.dart

@@ -80,19 +80,19 @@ class FixedSegment extends Segment {
   }
 
   const FixedSegment.empty()
-      : this(
+    : this(
-          firstIndex: 0,
+        firstIndex: 0,
-          lastIndex: 0,
+        lastIndex: 0,
-          startOffset: 0,
+        startOffset: 0,
-          endOffset: 0,
+        endOffset: 0,
-          firstAssetIndex: 0,
+        firstAssetIndex: 0,
-          bucket: const Bucket(assetCount: 0),
+        bucket: const Bucket(assetCount: 0),
-          tileHeight: 1,
+        tileHeight: 1,
-          columnCount: 0,
+        columnCount: 0,
-          headerExtent: 0,
+        headerExtent: 0,
-          spacing: 0,
+        spacing: 0,
-          header: HeaderType.none,
+        header: HeaderType.none,
-        );
+      );
 }
 
 class _FixedSegmentRow extends ConsumerWidget {

mobile/lib/widgets/common/immich_app_bar.dart

@@ -41,7 +41,10 @@ class ImmichAppBar extends ConsumerWidget implements PreferredSizeWidget {
         borderRadius: const BorderRadius.all(Radius.circular(12)),
         child: Badge(
           label: const DecoratedBox(
-            decoration: BoxDecoration(color: Colors.black, borderRadius: BorderRadius.all(Radius.circular(widgetSize / 2))),
+            decoration: BoxDecoration(
+              color: Colors.black,
+              borderRadius: BorderRadius.all(Radius.circular(widgetSize / 2)),
+            ),
             child: Icon(Icons.info, color: Color.fromARGB(255, 243, 188, 106), size: widgetSize / 2),
           ),
           backgroundColor: Colors.transparent,

mobile/lib/widgets/memories/memory_card.dart

@@ -101,11 +101,7 @@ class _BlurredBackdrop extends HookWidget {
       child: DecoratedBox(
         decoration: BoxDecoration(
           image: DecorationImage(
-            image: ImmichImage.imageProvider(
+            image: ImmichImage.imageProvider(asset: asset, height: context.height, width: context.width),
-              asset: asset,
-              height: context.height,
-              width: context.width,
-            ),
             fit: BoxFit.cover,
           ),
         ),