fix(server): don't associate assets with Null Island (#5623)

* Don't associate assets with Null Island

* Fix lint

server/src/domain/metadata/metadata.service.spec.ts

@@ -304,6 +304,18 @@ describe(MetadataService.name, () => {
       });
     });
 
+    it('should discard latitude and longitude on null island', async () => {
+      assetMock.getByIds.mockResolvedValue([assetStub.withLocation]);
+      metadataMock.readTags.mockResolvedValue({
+        GPSLatitude: 0,
+        GPSLongitude: 0,
+      });
+
+      await sut.handleMetadataExtraction({ id: assetStub.image.id });
+      expect(assetMock.getByIds).toHaveBeenCalledWith([assetStub.image.id]);
+      expect(assetMock.upsertExif).toHaveBeenCalledWith(expect.objectContaining({ latitude: null, longitude: null }));
+    });
+
     it('should not apply motion photos if asset is video', async () => {
       assetMock.getByIds.mockResolvedValue([{ ...assetStub.livePhotoMotionAsset, isVisible: true }]);
       mediaMock.probe.mockResolvedValue(probeStub.matroskaContainer);

server/src/domain/metadata/metadata.service.ts

@@ -432,8 +432,7 @@ export class MetadataService {
 
     this.logger.verbose('Exif Tags', tags);
 
-    return {
+    const exifData = {
-      exifData: {
       // altitude: tags.GPSAltitude ?? null,
       assetId: asset.id,
       bitsPerSample: this.getBitsPerSample(tags),
@@ -458,9 +457,15 @@ export class MetadataService {
       profileDescription: tags.ProfileDescription || tags.ProfileName || null,
       projectionType: tags.ProjectionType ? String(tags.ProjectionType).toUpperCase() : null,
       timeZone: tags.tz ?? null,
-      },
-      tags,
     };
+
+    if (exifData.latitude === 0 && exifData.longitude === 0) {
+      console.warn('Exif data has latitude and longitude of 0, setting to null');
+      exifData.latitude = null;
+      exifData.longitude = null;
+    }
+
+    return { exifData, tags };
   }
 
   private getDateTimeOriginal(tags: ImmichTags | Tags | null) {

server/src/infra/migrations/1702257380990-DropNullIslandLatLong.ts

@@ -0,0 +1,14 @@
+import { MigrationInterface, QueryRunner } from 'typeorm';
+
+export class DropNullIslandLatLong1702257380990 implements MigrationInterface {
+  public async up(queryRunner: QueryRunner): Promise<void> {
+    await queryRunner.query(
+      'UPDATE "exif" SET latitude = NULL, longitude = NULL WHERE latitude = 0 AND longitude = 0;',
+    );
+  }
+
+  public async down(): Promise<void> {
+    // There's no way to know which assets used to have 0/0 lat-long if we've
+    // already run this migration.
+  }
+}