Cutlery/immich
1
0
Fork 1
mirror of https://github.com/immich-app/immich.git synced 2025-11-27 00:35:16 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: new update notification cause rendering loop (#24013)

Browse Source
This commit is contained in:
Alex 2025-11-19 20:14:30 -06:00 committed by GitHub
parent acded69adf
commit e7261a04e1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
web/src/lib/components/shared-components/side-bar/server-status.svelte
View File

@ -38,7 +38,7 @@
); );
const releaseInfo = $derived.by(() => { const releaseInfo = $derived.by(() => {
if ($release == undefined || $release?.isAvailable || !$user.isAdmin) { if ($release == undefined || !$release?.isAvailable || !$user.isAdmin) {
return; return;
} }

8
web/src/routes/+layout.svelte
View File

@ -11,7 +11,6 @@
import { eventManager } from '$lib/managers/event-manager.svelte'; import { eventManager } from '$lib/managers/event-manager.svelte';
import { serverConfigManager } from '$lib/managers/server-config-manager.svelte'; import { serverConfigManager } from '$lib/managers/server-config-manager.svelte';
import ServerRestartingModal from '$lib/modals/ServerRestartingModal.svelte'; import ServerRestartingModal from '$lib/modals/ServerRestartingModal.svelte';
import VersionAnnouncementModal from '$lib/modals/VersionAnnouncementModal.svelte';
import { user } from '$lib/stores/user.store'; import { user } from '$lib/stores/user.store';
import { import {
closeWebsocketConnection, closeWebsocketConnection,
@ -82,13 +81,13 @@
const { release, serverRestarting } = websocketStore; const { release, serverRestarting } = websocketStore;
const handleRelease = async (release?: ReleaseEvent) => { const handleRelease = (release?: ReleaseEvent) => {
if (!release?.isAvailable || !$user.isAdmin) { if (!release?.isAvailable || !$user.isAdmin) {
return; return;
} }
const releaseVersion = semverToName(release.releaseVersion); const releaseVersion = semverToName(release.releaseVersion);
const serverVersion = semverToName(release.serverVersion); // const serverVersion = semverToName(release.serverVersion);
const type = getReleaseType(release.serverVersion, release.releaseVersion); const type = getReleaseType(release.serverVersion, release.releaseVersion);
if (type === 'none' || type === 'patch' || localStorage.getItem('appVersion') === releaseVersion) { if (type === 'none' || type === 'patch' || localStorage.getItem('appVersion') === releaseVersion) {
@ -96,8 +95,7 @@
} }
try { try {
await modalManager.show(VersionAnnouncementModal, { serverVersion, releaseVersion }); // await modalManager.show(VersionAnnouncementModal, { serverVersion, releaseVersion });
localStorage.setItem('appVersion', releaseVersion); localStorage.setItem('appVersion', releaseVersion);
} catch (error) { } catch (error) {
console.error('Error [VersionAnnouncementBox]:', error); console.error('Error [VersionAnnouncementBox]:', error);