From edefed56aecba32eb824cd6d33f9607d79e301c7 Mon Sep 17 00:00:00 2001 From: Daniel Dietzler <36593685+danieldietzler@users.noreply.github.com> Date: Fri, 25 Jul 2025 15:06:12 +0200 Subject: [PATCH] fix: optional number inputs (#20218) --- .../shared-components/settings/setting-input-field.spec.ts | 2 +- .../shared-components/settings/setting-input-field.svelte | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/web/src/lib/components/shared-components/settings/setting-input-field.spec.ts b/web/src/lib/components/shared-components/settings/setting-input-field.spec.ts index 80cb920074..a6b0140de4 100644 --- a/web/src/lib/components/shared-components/settings/setting-input-field.spec.ts +++ b/web/src/lib/components/shared-components/settings/setting-input-field.spec.ts @@ -46,6 +46,6 @@ describe('SettingInputField component', () => { expect(numberInput.value).toEqual(''); await user.click(document.body); - expect(numberInput.value).toEqual('0'); + expect(numberInput.value).toEqual(''); }); }); diff --git a/web/src/lib/components/shared-components/settings/setting-input-field.svelte b/web/src/lib/components/shared-components/settings/setting-input-field.svelte index 87451667cd..bb0e2d8bef 100644 --- a/web/src/lib/components/shared-components/settings/setting-input-field.svelte +++ b/web/src/lib/components/shared-components/settings/setting-input-field.svelte @@ -49,6 +49,11 @@ value = e.currentTarget.value; if (inputType === SettingInputFieldType.NUMBER) { + if (value === '' && !required) { + value = null; + return; + } + let newValue = Number(value) || 0; if (newValue < min) { newValue = min;