From f11bfb95814583458e7244cb772e6a2ea6dcaef3 Mon Sep 17 00:00:00 2001 From: Jason Rasmussen Date: Fri, 14 Nov 2025 11:46:32 -0500 Subject: [PATCH] fix(server): broken memories (#23896) --- server/src/controllers/memory.controller.spec.ts | 5 +++++ server/src/dtos/memory.dto.ts | 3 ++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/server/src/controllers/memory.controller.spec.ts b/server/src/controllers/memory.controller.spec.ts index ac96e54a5b..8629b6c799 100644 --- a/server/src/controllers/memory.controller.spec.ts +++ b/server/src/controllers/memory.controller.spec.ts @@ -24,6 +24,11 @@ describe(MemoryController.name, () => { await request(ctx.getHttpServer()).get('/memories'); expect(ctx.authenticate).toHaveBeenCalled(); }); + + it('should not require any parameters', async () => { + await request(ctx.getHttpServer()).get('/memories').query({}); + expect(service.search).toHaveBeenCalled(); + }); }); describe('POST /memories', () => { diff --git a/server/src/dtos/memory.dto.ts b/server/src/dtos/memory.dto.ts index 8a86e66691..8e7320f831 100644 --- a/server/src/dtos/memory.dto.ts +++ b/server/src/dtos/memory.dto.ts @@ -5,7 +5,7 @@ import { Memory } from 'src/database'; import { AssetResponseDto, mapAsset } from 'src/dtos/asset-response.dto'; import { AuthDto } from 'src/dtos/auth.dto'; import { AssetOrderWithRandom, MemoryType } from 'src/enum'; -import { ValidateBoolean, ValidateDate, ValidateEnum, ValidateUUID } from 'src/validation'; +import { Optional, ValidateBoolean, ValidateDate, ValidateEnum, ValidateUUID } from 'src/validation'; class MemoryBaseDto { @ValidateBoolean({ optional: true }) @@ -31,6 +31,7 @@ export class MemorySearchDto { @IsInt() @IsPositive() @Type(() => Number) + @Optional() @ApiProperty({ type: 'integer', description: 'Number of memories to return' }) size?: number;