mirror of
				https://github.com/immich-app/immich.git
				synced 2025-11-03 19:17:11 -05:00 
			
		
		
		
	I ran into this while testing out <https://github.com/immich-app/immich/pull/19830>. When I add, change, or remove a client certificate under Immich's advanced settings, the change wouldn't take effect until some mysterious point in the future. For example: 1. Add a client certificate. It doesn't get used. 2. Remove certificate. *Now* the client certificate from step 1) is used. 3. Restart application. Now no client certificate is used. This all boils down to some missing `await`s. The user would change the cert, and we'd start asynchronously saving it to the store, and while the save is still happening, [`HttpSSLOptions` pulls the "old" value out of `SSLClientCertStoreVal`](https://github.com/immich-app/immich/blob/v1.136.0/mobile/lib/utils/http_ssl_options.dart#L30). With the appropriate `await`s, this behaves much more sanely.
		
			
				
	
	
		
			39 lines
		
	
	
		
			1.1 KiB
		
	
	
	
		
			Dart
		
	
	
	
	
	
			
		
		
	
	
			39 lines
		
	
	
		
			1.1 KiB
		
	
	
	
		
			Dart
		
	
	
	
	
	
import 'dart:convert';
 | 
						|
import 'dart:typed_data';
 | 
						|
 | 
						|
import 'package:immich_mobile/domain/models/store.model.dart';
 | 
						|
import 'package:immich_mobile/domain/services/store.service.dart';
 | 
						|
 | 
						|
// ignore: non_constant_identifier_names
 | 
						|
final Store = StoreService.I;
 | 
						|
 | 
						|
class SSLClientCertStoreVal {
 | 
						|
  final Uint8List data;
 | 
						|
  final String? password;
 | 
						|
 | 
						|
  const SSLClientCertStoreVal(this.data, this.password);
 | 
						|
 | 
						|
  Future<void> save() async {
 | 
						|
    final b64Str = base64Encode(data);
 | 
						|
    await Store.put(StoreKey.sslClientCertData, b64Str);
 | 
						|
    if (password != null) {
 | 
						|
      await Store.put(StoreKey.sslClientPasswd, password!);
 | 
						|
    }
 | 
						|
  }
 | 
						|
 | 
						|
  static SSLClientCertStoreVal? load() {
 | 
						|
    final b64Str = Store.tryGet<String>(StoreKey.sslClientCertData);
 | 
						|
    if (b64Str == null) {
 | 
						|
      return null;
 | 
						|
    }
 | 
						|
    final Uint8List certData = base64Decode(b64Str);
 | 
						|
    final passwd = Store.tryGet<String>(StoreKey.sslClientPasswd);
 | 
						|
    return SSLClientCertStoreVal(certData, passwd);
 | 
						|
  }
 | 
						|
 | 
						|
  static Future<void> delete() async {
 | 
						|
    await Store.delete(StoreKey.sslClientCertData);
 | 
						|
    await Store.delete(StoreKey.sslClientPasswd);
 | 
						|
  }
 | 
						|
}
 |