From 69b24f95c4e7e7249fe281ea698006b677d26fe2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Benjamin=20Beganovi=C4=87?= <k1pstabug@gmail.com>
Date: Mon, 28 Sep 2020 12:36:51 +0200
Subject: [PATCH] Centralised variables: - New Helpers.php with
 sharedEmailVariables - Merged settings from TemplateEngine - @isset check for
 $whitelabel in the master.blade

---
 app/Utils/Helpers.php                         | 29 +++++++++++++++++++
 app/Utils/TemplateEngine.php                  |  5 ++--
 .../views/email/template/master.blade.php     | 14 +++++----
 3 files changed, 39 insertions(+), 9 deletions(-)
 create mode 100644 app/Utils/Helpers.php

diff --git a/app/Utils/Helpers.php b/app/Utils/Helpers.php
new file mode 100644
index 000000000000..ef28f19440dc
--- /dev/null
+++ b/app/Utils/Helpers.php
@@ -0,0 +1,29 @@
+<?php
+
+/**
+ * Invoice Ninja (https://invoiceninja.com).
+ *
+ * @link https://github.com/invoiceninja/invoiceninja source repository
+ *
+ * @copyright Copyright (c) 2020. Invoice Ninja LLC (https://invoiceninja.com)
+ *
+ * @license https://opensource.org/licenses/AAL
+ */
+
+namespace App\Utils;
+
+use App\Models\Client;
+
+class Helpers
+{
+    public static function sharedEmailVariables(Client $client, array $settings = null): array
+    {
+        $_settings = is_null($settings) ? $client->getMergedSettings() : $settings;
+
+        $elements['signature'] = $_settings->email_signature;
+        $elements['settings'] = $_settings;
+        $elements['whitelabel'] = $client->user->account->isPaid() ? true : false;
+
+        return $elements;
+    }
+}
diff --git a/app/Utils/TemplateEngine.php b/app/Utils/TemplateEngine.php
index c2dbc2d1b771..4563d472d9a0 100644
--- a/app/Utils/TemplateEngine.php
+++ b/app/Utils/TemplateEngine.php
@@ -171,9 +171,8 @@ class TemplateEngine
         $data['title'] = '';
         $data['body'] = '$body';
         $data['footer'] = '';
-        $data['signature'] = $this->settings_entity->getSetting('email_signature');
-        $data['settings'] = $this->settings;
-        $data['whitelabel'] = $this->entity_obj->client->user->account->isPaid() ? true : false;
+        
+        $data = array_merge($data, Helpers::sharedEmailVariables($this->entity_obj->client));
 
         if ($email_style == 'custom') {
             $wrapper = $this->settings_entity->getSetting('email_style_custom');
diff --git a/resources/views/email/template/master.blade.php b/resources/views/email/template/master.blade.php
index 71167aaf6235..cf44f3f41687 100644
--- a/resources/views/email/template/master.blade.php
+++ b/resources/views/email/template/master.blade.php
@@ -59,12 +59,14 @@ if(!isset($design)) $design = 'light';
   </div>
 
   <!-- Whitelabel -->
-  @if(!$whitelabel)
-    <div style="display: flex; flex-direction: row; justify-content: center; margin-top: 1rem; margin-bottom: 1rem;">
-      <a href="https://invoiceninja.com" target="_blank">
-        <img style="height: 4rem;" src="{{ asset('images/created-by-invoiceninja-new.png') }}" alt="Invoice Ninja">
-      </a>
-    </div>
+  @isset($whitelabel)
+    @if(!$whitelabel)
+      <div style="display: flex; flex-direction: row; justify-content: center; margin-top: 1rem; margin-bottom: 1rem;">
+          <a href="https://invoiceninja.com" target="_blank">
+            <img style="height: 4rem;" src="{{ asset('images/created-by-invoiceninja-new.png') }}" alt="Invoice Ninja">
+          </a>
+      </div>
+    @endif
   @endif
 </body>
 </html>
\ No newline at end of file