From 105b5c967bb70444c231958d9819cbf086a8666d Mon Sep 17 00:00:00 2001
From: David Bomba <turbo124@gmail.com>
Date: Wed, 2 Oct 2024 10:59:14 +1000
Subject: [PATCH] Fixes for tests

---
 .../Requests/Product/StoreProductRequest.php  |  9 ++++++++
 tests/Feature/ProductTest.php                 | 21 +++++++++++++++++++
 2 files changed, 30 insertions(+)

diff --git a/app/Http/Requests/Product/StoreProductRequest.php b/app/Http/Requests/Product/StoreProductRequest.php
index 6984288cf859..ee8f588bcc6b 100644
--- a/app/Http/Requests/Product/StoreProductRequest.php
+++ b/app/Http/Requests/Product/StoreProductRequest.php
@@ -52,6 +52,11 @@ class StoreProductRequest extends Request
         $rules['stock_notification_threshold'] = 'sometimes|numeric';
         $rules['stock_notification'] = 'sometimes|bool';
 
+        $rules['tax_rate1'] = 'bail|sometimes|numeric';
+        $rules['tax_rate2'] = 'bail|sometimes|numeric';
+        $rules['tax_rate3'] = 'bail|sometimes|numeric';
+
+
         return $rules;
     }
 
@@ -67,6 +72,10 @@ class StoreProductRequest extends Request
             $input['assigned_user_id'] = $this->decodePrimaryKey($input['assigned_user_id']);
         }
 
+        $input['tax_name1'] =  $input['tax_name1'] ?? '';
+        $input['tax_name2'] =  $input['tax_name2'] ?? '';
+        $input['tax_name3'] =  $input['tax_name3'] ?? '';
+
         $this->replace($input);
     }
 }
diff --git a/tests/Feature/ProductTest.php b/tests/Feature/ProductTest.php
index b394870de75b..7bdea3e817c8 100644
--- a/tests/Feature/ProductTest.php
+++ b/tests/Feature/ProductTest.php
@@ -53,6 +53,27 @@ class ProductTest extends TestCase
 
     }
 
+    public function testRequiredFields()
+    {
+        
+        $product = [
+            'cost' => 10,
+            'vendor_id' => $this->vendor->hashed_id
+        ];
+
+        $response = $this->withHeaders([
+            'X-API-SECRET' => config('ninja.api_secret'),
+            'X-API-TOKEN' => $this->token,
+        ])->postJson('/api/v1/products', $product)
+        ->assertStatus(200);
+
+        $arr = $response->json();
+
+        $p = Product::find($this->decodePrimaryKey($arr['data']['id']));
+
+        $this->assertNull($p->vendor_id);
+    }
+
     public function testProductCostMigration()
     {
         $items = [];