Fixes for credits

app/Helpers/Invoice/InvoiceItemSum.php

@@ -29,6 +29,7 @@ class InvoiceItemSum
     use Discounter;
     use Taxer;
 
+    //@phpstan-ignore-next-line
     private array $eu_tax_jurisdictions = [
         'AT', // Austria
         'BE', // Belgium
@@ -170,7 +171,7 @@ class InvoiceItemSum
     private function shouldCalculateTax(): self
     {
 
-        if (!$this->invoice->company?->calculate_taxes || $this->invoice->company->account->isFreeHostedClient()) {
+        if (!$this->invoice->company?->calculate_taxes || $this->invoice->company->account->isFreeHostedClient()) { //@phpstan-ignore-line
             $this->calc_tax = false;
             return $this;
         }

app/Helpers/Invoice/InvoiceItemSumInclusive.php

@@ -27,7 +27,7 @@ class InvoiceItemSumInclusive
     use Discounter;
     use Taxer;
 
-
+    //@phpstan-ignore-next-line
     private array $eu_tax_jurisdictions = [
         'AT', // Austria
         'BE', // Belgium
@@ -98,6 +98,7 @@ class InvoiceItemSumInclusive
 
     private $total_taxes;
 
+    /** @phpstan-ignore-next-line */
     private $item;
 
     private $line_items;
@@ -399,7 +400,7 @@ class InvoiceItemSumInclusive
     private function shouldCalculateTax(): self
     {
 
-        if (!$this->invoice->company->calculate_taxes || $this->invoice->company->account->isFreeHostedClient()) {
+        if (!$this->invoice->company?->calculate_taxes || $this->invoice->company->account->isFreeHostedClient()) {//@phpstan-ignore-line
             $this->calc_tax = false;
             return $this;
         }

app/Http/Controllers/MigrationController.php

@@ -280,18 +280,6 @@ class MigrationController extends BaseController
             }
         }
 
-        if (app()->environment() === 'local') {
-        }
-
-        try {
-            return response()->json([
-                '_id' => Str::uuid(),
-                'method' => config('queue.default'),
-                'started_at' => now(),
-            ], 200);
-        } finally {
-            // Controller logic here
-
         foreach ($companies as $company) {
             if (! is_array($company)) {
                 continue;
@@ -460,6 +448,4 @@ class MigrationController extends BaseController
         ], 200);
 
     }
-
-    }
 }

app/Http/Controllers/OneTimeTokenController.php

@@ -22,8 +22,6 @@ use Illuminate\Support\Str;
 
 class OneTimeTokenController extends BaseController
 {
-    private $contexts = [
-    ];
 
     public function __construct()
     {

app/Http/Controllers/PostMarkController.php

@@ -19,7 +19,6 @@ use Illuminate\Http\Request;
  */
 class PostMarkController extends BaseController
 {
-    private $invitation;
 
     public function __construct()
     {

app/Http/Controllers/SetupController.php

@@ -234,24 +234,6 @@ class SetupController extends Controller
         }
     }
 
-    private function testPhantom()
-    {
-        try {
-            $key = config('ninja.phantomjs_key');
-            $url = 'https://www.invoiceninja.org/';
-
-            $phantom_url = "https://phantomjscloud.com/api/browser/v2/{$key}/?request=%7Burl:%22{$url}%22,renderType:%22pdf%22%7D";
-            $pdf = CurlUtils::get($phantom_url);
-
-            Storage::disk(config('filesystems.default'))->put('test.pdf', $pdf);
-            Storage::disk('local')->put('test.pdf', $pdf);
-
-            return response(['url' => Storage::disk('local')->url('test.pdf')], 200);
-        } catch (Exception $e) {
-            return response([], 500);
-        }
-    }
-
     public function clearCompiledCache()
     {
         $cacheCompiled = base_path('bootstrap/cache/compiled.php');

app/Import/Transformer/Invoice2Go/InvoiceTransformer.php

@@ -277,7 +277,7 @@ class InvoiceTransformer extends BaseTransformer
             if($key == 0) {
                 continue;
             }
-
+            /** @var array $row */
             if(is_array($row[5])) {
                 $csv = str_getcsv($row[5][0], ";");
                 $row[5] = array_combine(explode(",", $csv[0]), explode(",", $csv[1]));

app/Jobs/Entity/CreateRawPdf.php

@@ -40,7 +40,7 @@ class CreateRawPdf
 
     public Invoice | Credit | Quote | RecurringInvoice | PurchaseOrder $entity;
 
-    public $company;
+    public \App\Models\Company $company;
 
     public $contact;
 
@@ -55,6 +55,7 @@ class CreateRawPdf
     {
 
         $this->invitation = $invitation;
+        $this->company = $invitation->company;
 
         if ($invitation instanceof InvoiceInvitation) {
             $this->entity = $invitation->invoice;
@@ -116,6 +117,13 @@ class CreateRawPdf
         if ($this->entity_string == "invoice" && $this->entity->client->getSetting("merge_e_invoice_to_pdf")) {
             $pdf = (new MergeEDocument($this->entity, $pdf))->handle();
         }        
+
+        $merge_docs = $this->entity->client ? $this->entity->client->getSetting('embed_documents') : $this->company->getSetting('embed_documents');
+
+        if($merge_docs && ($this->entity->documents()->where('is_public', true)->count() > 0 || $this->company->documents()->where('is_public', true)->count() > 0)) {
+            $pdf = $this->entity->documentMerge($pdf);
+        }
+
         return $pdf;
     }
 

app/Jobs/Invoice/CreateUbl.php

@@ -192,7 +192,7 @@ class CreateUbl implements ShouldQueue
     /**
      * @param $item
      * @param $invoice_total
-     * @return float|int
+     * @return float
      */
     private function getItemTaxable($item, $invoice_total)
     {

app/Models/User.php

@@ -60,7 +60,7 @@ use Laracasts\Presenter\PresentableTrait;
  * @property bool $is_deleted
  * @property string|null $last_login
  * @property string|null $signature
- * @property string $password
+ * @property string|null $password
  * @property string $language_id
  * @property string|null $remember_token
  * @property string|null $custom_value1

app/PaymentDrivers/Braintree/CreditCard.php

@@ -53,7 +53,7 @@ class CreditCard
      * Credit card payment page.
      *
      * @param array $data
-     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
+     * @return array
      */
 
     private function threeDParameters(array $data)

app/PaymentDrivers/PayPal/PayPalWebhook.php

@@ -307,7 +307,7 @@ class PayPalWebhook implements ShouldQueue
 
             });
 
-        return $gateway ?? false;
+        return $gateway ?? null;
     }
 
     //--------------------------------------------------------------------------------------//

app/PaymentDrivers/PayPalPPCPPaymentDriver.php

@@ -284,6 +284,10 @@ class PayPalPPCPPaymentDriver extends PayPalBasePaymentDriver
 
         $r = $this->gatewayRequest('/v2/checkout/orders', 'post', $order);
 
+        if(!isset($r->json()['id'])) {
+            $this->handleProcessingFailure($r->json());
+        }
+
         $this->payment_hash->withData("orderID", $r->json()['id']);
 
         return $r->json()['id'];

app/Repositories/PaymentRepository.php

@@ -59,7 +59,7 @@ class PaymentRepository extends BaseRepository
      * @param  Payment $payment The $payment entity
      * @return Payment          The updated/created payment object
      */
-    private function applyPayment(array $data, Payment $payment): ?Payment
+    private function applyPayment(array $data, Payment $payment): Payment
     {
         $is_existing_payment = true;
         $client = false;

app/Services/Credit/CreditService.php

@@ -219,27 +219,6 @@ class CreditService
 
     public function deletePdf()
     {
-        $this->credit->invitations->each(function ($invitation) {
-            // (new UnlinkFile(config('filesystems.default'), $this->credit->client->credit_filepath($invitation).$this->credit->numberFormatter().'.pdf'))->handle();
-
-            //30-06-2023
-            try {
-                // if (Storage::disk(config('filesystems.default'))->exists($this->invoice->client->invoice_filepath($invitation).$this->invoice->numberFormatter().'.pdf')) {
-                Storage::disk(config('filesystems.default'))->delete($this->credit->client->credit_filepath($invitation).$this->credit->numberFormatter().'.pdf');
-                // }
-
-                // if (Ninja::isHosted() && Storage::disk('public')->exists($this->invoice->client->invoice_filepath($invitation).$this->invoice->numberFormatter().'.pdf')) {
-                if (Ninja::isHosted()) {
-                    Storage::disk('public')->delete($this->credit->client->credit_filepath($invitation).$this->credit->numberFormatter().'.pdf');
-                }
-            } catch (\Exception $e) {
-                nlog($e->getMessage());
-            }
-
-
-
-        });
-
         return $this;
     }
 
@@ -273,9 +252,12 @@ class CreditService
 
     public function deleteCredit()
     {
+        $paid_to_date = $this->credit->invoice_id ? $this->credit->balance : 0;
+
         $this->credit
             ->client
             ->service()
+            ->updatePaidToDate($paid_to_date)
             ->adjustCreditBalance($this->credit->balance * -1)
             ->save();
 
@@ -285,9 +267,13 @@ class CreditService
 
     public function restoreCredit()
     {
+        
+        $paid_to_date = $this->credit->invoice_id ? $this->credit->balance : 0;
+
         $this->credit
              ->client
              ->service()
+             ->updatePaidToDate($paid_to_date * -1)
              ->adjustCreditBalance($this->credit->balance)
              ->save();
 

app/Services/EDocument/Standards/RoEInvoice.php

@@ -405,7 +405,7 @@ class RoEInvoice extends AbstractService
     /**
      * @param $item
      * @param $invoice_total
-     * @return float|int
+     * @return float
      */
     private function getItemTaxable($item, $invoice_total)
     {

app/Services/Email/EmailDefaults.php

@@ -406,7 +406,7 @@ class EmailDefaults
      * @param  string $markdown The body to convert
      * @return string           The parsed markdown response
      */
-    private function parseMarkdownToHtml(string $markdown): ?string
+    private function parseMarkdownToHtml(string $markdown): string
     {
         $converter = new CommonMarkConverter([
             'allow_unsafe_links' => false,

app/Utils/Traits/CleanLineItems.php

@@ -110,8 +110,6 @@ trait CleanLineItems
             $total += ($item['cost'] * $item['quantity']);
         }
 
-        nlog($total);
-
         return $total;
     }
 }

tests/Feature/CreditTest.php

@@ -43,6 +43,102 @@ class CreditTest extends TestCase
         $this->makeTestData();
     }
 
+    public function testPaidToDateAdjustments()
+    {
+
+        $c = Client::factory()->create([
+            'company_id' => $this->company->id,
+            'user_id' => $this->user->id,
+            'balance' => 0,
+        ]);
+
+        $ii = new InvoiceItem();
+        $ii->cost = 100;
+        $ii->quantity = 1;
+        $ii->product_key = 'xx';
+        $ii->notes = 'yy';
+
+        $i = \App\Models\Invoice::factory()->create([
+            'company_id' => $this->company->id,
+            'user_id' => $this->user->id,
+            'client_id' => $c->id,
+            'tax_name1' => '',
+            'tax_name2' => '',
+            'tax_name3' => '',
+            'tax_rate1' => 0,
+            'tax_rate2' => 0,
+            'tax_rate3' => 0,
+            'discount' => 0,
+            'line_items' => [
+                $ii
+            ],
+            'status_id' => 1,
+        ]);
+
+        $i = $i->calc()->getInvoice();
+
+        $this->assertEquals(0, $i->balance);
+        $this->assertEquals(100, $i->amount);
+
+        $i->service()->markSent()->save();
+
+        $this->assertEquals(100, $i->balance);
+        
+        $i->service()->markPaid()->save();
+        $i = $i->fresh();
+        $c = $c->fresh();
+
+        $this->assertEquals(0, $i->balance);
+        $this->assertEquals(0, $c->balance);
+
+        $this->assertEquals(100, $c->paid_to_date);
+        
+        $i->service()->handleReversal()->save();
+        
+        
+        $data = $i->toArray(); 
+        $data['invoice_id'] = $i->hashed_id;
+        $data['user_id'] = $this->encodePrimaryKey($i->user_id);
+        $data['client_id'] = $this->encodePrimaryKey($i->client_id);
+        $data['status_id'] = 1;
+
+        $response = $this->withHeaders([
+                    'X-API-SECRET' => config('ninja.api_secret'),
+                    'X-API-TOKEN' => $this->token,
+                ])->postJson("/api/v1/credits?mark_sent=true", $data);
+
+        $response->assertStatus(200);
+        $arr = $response->json();
+
+        $cr_id = $arr['data']['id'];
+
+        $i = $i->fresh();
+        $c = $c->fresh();
+
+        $credit = $i->credits()->first();
+
+        $this->assertNotNull($credit);
+
+        $this->assertEquals(0, $i->balance);
+        $this->assertEquals(100, $c->credit_balance);
+        $this->assertEquals(0, $c->paid_to_date);
+    
+        $credit->service()->deleteCredit()->save();
+
+        $c = $c->fresh();
+
+        $this->assertEquals(100, $c->paid_to_date);
+        $this->assertEquals(0, $c->credit_balance);
+
+        $credit->service()->restoreCredit()->save();
+
+        $c = $c->fresh();
+
+        $this->assertEquals(0, $c->paid_to_date);
+        $this->assertEquals(100, $c->credit_balance);
+
+    }
+
     public function testCreditPaymentsPaidToDates()
     {
         $c = Client::factory()->create([