Clean up for phpstan

This commit is contained in:
David Bomba 2023-06-08 17:39:05 +10:00
parent dad8aea5b0
commit 1365fc0050
2 changed files with 30 additions and 24 deletions

View File

@ -29,7 +29,7 @@ trait Refundable
* Entry point for processing of refunds. * Entry point for processing of refunds.
* @param array $data * @param array $data
* @deprecated ???? 06-09-2022 * @deprecated ???? 06-09-2022
* @return Refundable * @return self
* @throws PaymentRefundFailed * @throws PaymentRefundFailed
*/ */
public function processRefund(array $data) public function processRefund(array $data)

View File

@ -108,7 +108,6 @@ class VendorHtmlEngine
{ {
if (! $this->vendor->currency()) { if (! $this->vendor->currency()) {
throw new Exception(debug_backtrace()[1]['function'], 1); throw new Exception(debug_backtrace()[1]['function'], 1);
return [];
} }
App::forgetInstance('translator'); App::forgetInstance('translator');
@ -601,6 +600,8 @@ class VendorHtmlEngine
* @return string a collection of <tr> rows with line item * @return string a collection of <tr> rows with line item
* aggregate data * aggregate data
*/ */
/*
private function makeLineTaxes() :string private function makeLineTaxes() :string
{ {
$tax_map = $this->entity_calc->getTaxMap(); $tax_map = $this->entity_calc->getTaxMap();
@ -616,18 +617,6 @@ class VendorHtmlEngine
return $data; return $data;
} }
private function lineTaxValues() :string
{
$tax_map = $this->entity_calc->getTaxMap();
$data = '';
foreach ($tax_map as $tax) {
$data .= '<span>'.Number::formatMoney($tax['total'], $this->company).'</span>';
}
return $data;
}
private function makeTotalTaxes() :string private function makeTotalTaxes() :string
{ {
@ -653,21 +642,13 @@ class VendorHtmlEngine
return strtr($section, $values); return strtr($section, $values);
} }
*/
/*
| Ensures the URL doesn't have duplicated trailing slash
*/
public function generateAppUrl()
{
//return rtrim(config('ninja.app_url'), "/");
return config('ninja.app_url');
}
/** /**
* Builds CSS to assist with the generation * Builds CSS to assist with the generation
* of Repeating headers and footers on the PDF. * of Repeating headers and footers on the PDF.
* @return string The css string * @return string The css string
*/
private function generateCustomCSS() :string private function generateCustomCSS() :string
{ {
$header_and_footer = ' $header_and_footer = '
@ -759,6 +740,31 @@ html {
return $css; return $css;
} }
*/
private function lineTaxValues() :string
{
$tax_map = $this->entity_calc->getTaxMap();
$data = '';
foreach ($tax_map as $tax) {
$data .= '<span>'.Number::formatMoney($tax['total'], $this->company).'</span>';
}
return $data;
}
/*
| Ensures the URL doesn't have duplicated trailing slash
*/
public function generateAppUrl()
{
//return rtrim(config('ninja.app_url'), "/");
return config('ninja.app_url');
}
/** /**
* Generate markup for HTML images on entity. * Generate markup for HTML images on entity.