mirror of
https://github.com/invoiceninja/invoiceninja.git
synced 2025-06-01 03:04:35 -04:00
Email blacklists
This commit is contained in:
parent
fd7ff4d285
commit
25aadf9202
@ -12,7 +12,10 @@
|
|||||||
namespace App\Http\Requests\Account;
|
namespace App\Http\Requests\Account;
|
||||||
|
|
||||||
use App\Http\Requests\Request;
|
use App\Http\Requests\Request;
|
||||||
|
use App\Http\ValidationRules\Account\BlackListRule;
|
||||||
|
use App\Http\ValidationRules\Account\EmailBlackListRule;
|
||||||
use App\Http\ValidationRules\NewUniqueUserRule;
|
use App\Http\ValidationRules\NewUniqueUserRule;
|
||||||
|
use App\Utils\Ninja;
|
||||||
|
|
||||||
class CreateAccountRequest extends Request
|
class CreateAccountRequest extends Request
|
||||||
{
|
{
|
||||||
@ -33,13 +36,18 @@ class CreateAccountRequest extends Request
|
|||||||
*/
|
*/
|
||||||
public function rules()
|
public function rules()
|
||||||
{
|
{
|
||||||
|
|
||||||
|
if(Ninja::isHosted())
|
||||||
|
$email_rules = ['required', 'email:rfc,dns', new NewUniqueUserRule, new BlackListRule, new EmailBlackListRule];
|
||||||
|
else
|
||||||
|
$email_rules = ['required', 'email:rfc,dns', new NewUniqueUserRule];
|
||||||
|
|
||||||
|
|
||||||
return [
|
return [
|
||||||
'first_name' => 'string|max:100',
|
'first_name' => 'string|max:100',
|
||||||
'last_name' => 'string:max:100',
|
'last_name' => 'string:max:100',
|
||||||
'password' => 'required|string|min:6|max:1000',
|
'password' => 'required|string|min:6|max:1000',
|
||||||
// 'email' => 'bail|required|email:rfc,dns',
|
'email' => $email_rules,
|
||||||
// 'email' => new NewUniqueUserRule(),
|
|
||||||
'email' => ['required', 'email:rfc,dns', new NewUniqueUserRule],
|
|
||||||
'privacy_policy' => 'required|boolean',
|
'privacy_policy' => 'required|boolean',
|
||||||
'terms_of_service' => 'required|boolean',
|
'terms_of_service' => 'required|boolean',
|
||||||
];
|
];
|
||||||
|
@ -14,6 +14,7 @@ namespace App\Http\Requests\Login;
|
|||||||
|
|
||||||
use App\Http\Requests\Request;
|
use App\Http\Requests\Request;
|
||||||
use App\Http\ValidationRules\Account\BlackListRule;
|
use App\Http\ValidationRules\Account\BlackListRule;
|
||||||
|
use App\Http\ValidationRules\Account\EmailBlackListRule;
|
||||||
use App\Utils\Ninja;
|
use App\Utils\Ninja;
|
||||||
|
|
||||||
class LoginRequest extends Request
|
class LoginRequest extends Request
|
||||||
@ -38,7 +39,7 @@ class LoginRequest extends Request
|
|||||||
{
|
{
|
||||||
|
|
||||||
if(Ninja::isHosted())
|
if(Ninja::isHosted())
|
||||||
$email_rules = ['required', new BlackListRule];
|
$email_rules = ['required', new BlackListRule, new EmailBlackListRule];
|
||||||
else
|
else
|
||||||
$email_rules = 'required';
|
$email_rules = 'required';
|
||||||
|
|
||||||
|
47
app/Http/ValidationRules/Account/EmailBlackListRule.php
Normal file
47
app/Http/ValidationRules/Account/EmailBlackListRule.php
Normal file
@ -0,0 +1,47 @@
|
|||||||
|
<?php
|
||||||
|
/**
|
||||||
|
* Invoice Ninja (https://invoiceninja.com).
|
||||||
|
*
|
||||||
|
* @link https://github.com/invoiceninja/invoiceninja source repository
|
||||||
|
*
|
||||||
|
* @copyright Copyright (c) 2022. Invoice Ninja LLC (https://invoiceninja.com)
|
||||||
|
*
|
||||||
|
* @license https://www.elastic.co/licensing/elastic-license
|
||||||
|
*/
|
||||||
|
|
||||||
|
namespace App\Http\ValidationRules\Account;
|
||||||
|
|
||||||
|
use App\Libraries\MultiDB;
|
||||||
|
use Illuminate\Contracts\Validation\Rule;
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Class EmailBlackListRule.
|
||||||
|
*/
|
||||||
|
class EmailBlackListRule implements Rule
|
||||||
|
{
|
||||||
|
public array $blacklist = [
|
||||||
|
|
||||||
|
];
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @param string $attribute
|
||||||
|
* @param mixed $value
|
||||||
|
* @return bool
|
||||||
|
*/
|
||||||
|
public function passes($attribute, $value)
|
||||||
|
{
|
||||||
|
|
||||||
|
return !in_array($value, $this->blacklist);
|
||||||
|
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @return string
|
||||||
|
*/
|
||||||
|
public function message()
|
||||||
|
{
|
||||||
|
return "This email address is blacklisted, if you think this is in error, please email contact@invoiceninja.com";
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
}
|
70
tests/Unit/ValidationRules/EmailBlacklistValidationTest.php
Normal file
70
tests/Unit/ValidationRules/EmailBlacklistValidationTest.php
Normal file
@ -0,0 +1,70 @@
|
|||||||
|
<?php
|
||||||
|
/**
|
||||||
|
* Invoice Ninja (https://invoiceninja.com).
|
||||||
|
*
|
||||||
|
* @link https://github.com/invoiceninja/invoiceninja source repository
|
||||||
|
*
|
||||||
|
* @copyright Copyright (c) 2021. Invoice Ninja LLC (https://invoiceninja.com)
|
||||||
|
*
|
||||||
|
* @license https://opensource.org/licenses/AAL
|
||||||
|
*/
|
||||||
|
namespace Tests\Unit\ValidationRules;
|
||||||
|
|
||||||
|
use App\Http\ValidationRules\Account\BlackListRule;
|
||||||
|
use App\Http\ValidationRules\Account\EmailBlackListRule;
|
||||||
|
use App\Models\Invoice;
|
||||||
|
use Illuminate\Foundation\Testing\DatabaseTransactions;
|
||||||
|
use Tests\MockAccountData;
|
||||||
|
use Tests\TestCase;
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @test
|
||||||
|
* @covers App\Http\ValidationRules\Account\EmailBlackListRule
|
||||||
|
*/
|
||||||
|
class EmailBlacklistValidationTest extends TestCase
|
||||||
|
{
|
||||||
|
|
||||||
|
|
||||||
|
public function setUp() :void
|
||||||
|
{
|
||||||
|
parent::setUp();
|
||||||
|
|
||||||
|
}
|
||||||
|
|
||||||
|
public function testValidEmailRule()
|
||||||
|
{
|
||||||
|
$email_rule = new EmailBlackListRule;
|
||||||
|
$email_rule->blacklist = ['gimmy@gmail.com'];
|
||||||
|
|
||||||
|
$rules = [
|
||||||
|
'email' => [$email_rule]
|
||||||
|
];
|
||||||
|
|
||||||
|
$data = [
|
||||||
|
'email' => "gimmy@gmail.com",
|
||||||
|
];
|
||||||
|
|
||||||
|
$v = $this->app['validator']->make($data, $rules);
|
||||||
|
$this->assertFalse($v->passes());
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
public function testInValidEmailRule()
|
||||||
|
{
|
||||||
|
|
||||||
|
$rules = [
|
||||||
|
'email' => [new EmailBlackListRule]
|
||||||
|
];
|
||||||
|
|
||||||
|
$data = [
|
||||||
|
'email' => "jimmy@candassociates.com",
|
||||||
|
];
|
||||||
|
|
||||||
|
$v = $this->app['validator']->make($data, $rules);
|
||||||
|
$this->assertTrue($v->passes());
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
|
}
|
Loading…
x
Reference in New Issue
Block a user