From 2895e6df2d3603be9ec6605abeed0a15c57aca44 Mon Sep 17 00:00:00 2001 From: David Bomba Date: Mon, 16 Dec 2019 22:53:16 +1100 Subject: [PATCH] Fixes for codacy (#3150) --- app/Utils/Traits/InvoiceEmailBuilder.php | 6 ++---- tests/Feature/InvoiceEmailTest.php | 2 +- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/app/Utils/Traits/InvoiceEmailBuilder.php b/app/Utils/Traits/InvoiceEmailBuilder.php index f3b2e825f8ea..37ce15b48929 100644 --- a/app/Utils/Traits/InvoiceEmailBuilder.php +++ b/app/Utils/Traits/InvoiceEmailBuilder.php @@ -31,15 +31,13 @@ trait InvoiceEmailBuilder public function getEmailData($reminder_template = null) :array { //client - $client = $this->client; + //$client = $this->client; if(!$reminder_template) $reminder_template = $this->calculateTemplate(); //Need to determine which email template we are producing - $email_data = $this->generateTemplateData($reminder_template); - - return $email_data; + return $this->generateTemplateData($reminder_template); } diff --git a/tests/Feature/InvoiceEmailTest.php b/tests/Feature/InvoiceEmailTest.php index d1bfb4bbbb74..d346d800e2a5 100644 --- a/tests/Feature/InvoiceEmailTest.php +++ b/tests/Feature/InvoiceEmailTest.php @@ -55,7 +55,7 @@ class InvoiceEmailTest extends TestCase $message_array['title'] = &$message_array['subject']; $message_array['footer'] = 'The Footer'; - $template_style = $this->client->getSetting('email_style'); + // $template_style = $this->client->getSetting('email_style'); $template_style = 'light'; //iterate through the senders list and send from here