Cutlery/invoiceninja
1
0
Fork 0
mirror of https://github.com/invoiceninja/invoiceninja.git synced 2025-05-24 02:14:21 -04:00
Code Issues Packages Projects Releases Wiki Activity

Refactor to remove laravel-data from application

Browse Source
This commit is contained in:
David Bomba 2024-05-26 08:54:24 +10:00
parent 5e21b72021
commit 2f1648eb4e
3 changed files with 75 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
app/Helpers/Bank/Yodlee/DTO/AccountSummary.php
View File

@ -16,6 +16,7 @@ use Spatie\LaravelData\Attributes\MapInputName;
use Spatie\LaravelData\Data;
/**
* @deprecated
* [
"account": [
[

24
app/Http/Controllers/Bank/YodleeController.php
View File

@ -301,8 +301,30 @@ class YodleeController extends BaseController
$summary = $yodlee->getAccountSummary($account_number);
$transformed_summary = AccountSummary::from($summary[0]);
//@todo remove laravel-data
// $transformed_summary = AccountSummary::from($summary[0]);
$transformed_summary = $this->transformSummary($summary[0]);
return response()->json($transformed_summary, 200);
}
private function transformSummary($summary): array
{
$dto = new \stdClass;
$dto->id = $summary['id'] ?? 0;
$dto->account_type = $summary['CONTAINER'] ?? '';
$dto->account_status = $summary['accountStatus'] ?? '';
$dto->account_number = $summary['accountNumber'] ?? '';
$dto->provider_account_id = $summary['providerAccountId'] ?? '';
$dto->provider_id = $summary['providerId'] ?? '';
$dto->provider_name = $summary['providerName'] ?? '';
$dto->nickname = $summary['nickname'] ?? '';
$dto->account_name = $summary['accountName'] ?? '';
$dto->current_balance = $summary['currentBalance']['amount'] ?? 0;
$dto->account_currency = $summary['currentBalance']['currency'] ?? 0;
return (array)$dto;
}
}

51
tests/Integration/DTO/AccountSummaryTest.php
View File

@ -141,4 +141,55 @@ class AccountSummaryTest extends TestCase
$this->assertEquals($dto->id, 19315);
}
public function testTransformRefactor()
{
$dto = $this->transformSummary($this->data[0]);
$this->assertEquals($dto->id, 19315);
$this->assertEquals($dto->provider_account_id, 330);
$this->assertEquals($dto->account_type, $this->data[0]['CONTAINER'] ?? '');
$this->assertEquals($dto->account_status, $this->data[0]['accountStatus'] ?? '');
$this->assertEquals($dto->account_number, $this->data[0]['accountNumber'] ?? '');
$this->assertEquals($dto->provider_account_id, $this->data[0]['providerAccountId'] ?? '');
$this->assertEquals($dto->provider_id, $this->data[0]['providerId'] ?? '');
$this->assertEquals($dto->provider_name, $this->data[0]['providerName'] ?? '');
$this->assertEquals($dto->nickname, $this->data[0]['nickname'] ?? '');
$this->assertEquals($dto->account_name, $this->data[0]['accountName'] ?? '');
$this->assertEquals($dto->current_balance, $this->data[0]['currentBalance']['amount'] ?? 0);
$this->assertEquals($dto->account_currency, $this->data[0]['currentBalance']['currency'] ?? 0);
$dto_array = (array)$dto;
$this->assertEquals($dto_array['id'], 19315);
$this->assertEquals($dto_array['provider_account_id'], 330);
$this->assertEquals($dto_array['account_type'], $this->data[0]['CONTAINER'] ?? '');
$this->assertEquals($dto_array['account_status'], $this->data[0]['accountStatus'] ?? '');
$this->assertEquals($dto_array['account_number'], $this->data[0]['accountNumber'] ?? '');
$this->assertEquals($dto_array['provider_account_id'], $this->data[0]['providerAccountId'] ?? '');
$this->assertEquals($dto_array['provider_id'], $this->data[0]['providerId'] ?? '');
$this->assertEquals($dto_array['provider_name'], $this->data[0]['providerName'] ?? '');
$this->assertEquals($dto_array['nickname'], $this->data[0]['nickname'] ?? '');
$this->assertEquals($dto_array['account_name'], $this->data[0]['accountName'] ?? '');
$this->assertEquals($dto_array['current_balance'], $this->data[0]['currentBalance']['amount'] ?? 0);
$this->assertEquals($dto_array['account_currency'], $this->data[0]['currentBalance']['currency'] ?? 0);
}
private function transformSummary($summary)
{
$dto = new \stdClass;
$dto->id = $summary['id'] ?? 0;
$dto->account_type = $summary['CONTAINER'] ?? '';
$dto->account_status = $summary['accountStatus'] ?? '';
$dto->account_number = $summary['accountNumber'] ?? '';
$dto->provider_account_id = $summary['providerAccountId'] ?? '';
$dto->provider_id = $summary['providerId'] ?? '';
$dto->provider_name = $summary['providerName'] ?? '';
$dto->nickname = $summary['nickname'] ?? '';
$dto->account_name = $summary['accountName'] ?? '';
$dto->current_balance = $summary['currentBalance']['amount'] ?? 0;
$dto->account_currency = $summary['currentBalance']['currency'] ?? 0;
return $dto;
}
}