From 33badc78b7ff983ee24febf879a35764007f304e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Holger=20Lo=CC=88sken?= Date: Thu, 14 Jul 2016 23:20:16 +0200 Subject: [PATCH] Fixed wrong overrides, added some more docblocks --- app/Ninja/Repositories/PaymentRepository.php | 8 ++++---- app/Policies/DocumentPolicy.php | 4 ++-- app/Policies/InvoicePolicy.php | 8 +++++++- app/Policies/PaymentPolicy.php | 8 +++++++- app/Policies/TokenPolicy.php | 20 ++++++++++++++++++-- app/Policies/VendorPolicy.php | 4 ++++ 6 files changed, 42 insertions(+), 10 deletions(-) diff --git a/app/Ninja/Repositories/PaymentRepository.php b/app/Ninja/Repositories/PaymentRepository.php index 13b8e847b0d3..582085df17c4 100644 --- a/app/Ninja/Repositories/PaymentRepository.php +++ b/app/Ninja/Repositories/PaymentRepository.php @@ -227,11 +227,11 @@ class PaymentRepository extends BaseRepository } /** - * @param Payment $payment + * @param $payment * * @return bool */ - public function delete(Payment $payment) + public function delete($payment) { if ($payment->invoice->is_deleted) { return false; @@ -241,11 +241,11 @@ class PaymentRepository extends BaseRepository } /** - * @param Payment $payment + * @param $payment * * @return bool */ - public function restore(Payment $payment) + public function restore($payment) { if ($payment->invoice->is_deleted) { return false; diff --git a/app/Policies/DocumentPolicy.php b/app/Policies/DocumentPolicy.php index 98160ba4e948..8ebadcb2e0c9 100644 --- a/app/Policies/DocumentPolicy.php +++ b/app/Policies/DocumentPolicy.php @@ -22,11 +22,11 @@ class DocumentPolicy extends EntityPolicy /** * @param User $user - * @param Document $document + * @param $item * * @return bool */ - public static function view(User $user, Document $document) + public static function view(User $user, $item) { if ($user->hasPermission('view_all')) { return true; diff --git a/app/Policies/InvoicePolicy.php b/app/Policies/InvoicePolicy.php index aa72b4c0533c..5a7f7ebfc465 100644 --- a/app/Policies/InvoicePolicy.php +++ b/app/Policies/InvoicePolicy.php @@ -2,4 +2,10 @@ namespace App\Policies; -class InvoicePolicy extends EntityPolicy {} +/** + * Class InvoicePolicy + */ +class InvoicePolicy extends EntityPolicy +{ + +} diff --git a/app/Policies/PaymentPolicy.php b/app/Policies/PaymentPolicy.php index e9c3fc582a3f..eaf3c7d85877 100644 --- a/app/Policies/PaymentPolicy.php +++ b/app/Policies/PaymentPolicy.php @@ -2,4 +2,10 @@ namespace App\Policies; -class PaymentPolicy extends EntityPolicy {} \ No newline at end of file +/** + * Class PaymentPolicy + */ +class PaymentPolicy extends EntityPolicy +{ + +} \ No newline at end of file diff --git a/app/Policies/TokenPolicy.php b/app/Policies/TokenPolicy.php index 36e37e313a69..a26805d66865 100644 --- a/app/Policies/TokenPolicy.php +++ b/app/Policies/TokenPolicy.php @@ -2,12 +2,28 @@ namespace App\Policies; +use App\Models\User; + +/** + * Class TokenPolicy + */ class TokenPolicy extends EntityPolicy { - public static function edit($user, $item) { + /** + * @param User $user + * @param $item + * + * @return bool + */ + public static function edit(User $user, $item) { return $user->hasPermission('admin'); } - public static function create($user) { + /** + * @param User $user + * + * @return bool + */ + public static function create(User $user) { return $user->hasPermission('admin'); } } \ No newline at end of file diff --git a/app/Policies/VendorPolicy.php b/app/Policies/VendorPolicy.php index 8c388193251d..9e2d4a8a6403 100644 --- a/app/Policies/VendorPolicy.php +++ b/app/Policies/VendorPolicy.php @@ -4,10 +4,14 @@ namespace App\Policies; use App\Models\User; +/** + * Class VendorPolicy + */ class VendorPolicy extends EntityPolicy { /** * @param User $user + * * @return bool */ public static function create(User $user) {