Cutlery/invoiceninja
1
0
Fork 0
mirror of https://github.com/invoiceninja/invoiceninja.git synced 2025-07-09 03:14:30 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #9202 from paulwer/fix-nordigen-9198

Browse Source 
FIX: Nordigen Import Error, when missing transactionId from instituition
This commit is contained in:
David Bomba 2024-01-28 08:30:37 +11:00 committed by GitHub
commit 3ad0a255fe
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
app/Helpers/Bank/Nordigen/Transformer/TransactionTransformer.php
View File

@ -81,9 +81,16 @@ class TransactionTransformer implements BankRevenueInterface
public function transformTransaction($transaction)
{
if (!array_key_exists('transactionId', $transaction) || !array_key_exists('transactionAmount', $transaction))
throw new \Exception('invalid dataset');
// depending on institution, the result can be different, so we load the first available unique id
$transactionId = '';
if (array_key_exists('transactionId', $transaction))
$transactionId = $transaction["transactionId"];
else if (array_key_exists('internalTransactionId', $transaction))
$transactionId = $transaction["internalTransactionId"];
else {
nlog(`Invalid Input for nordigen transaction transformer: ` . $transaction);
throw new \Exception('invalid dataset: missing transactionId - Please report this error to the developer');
}
$amount = (float) $transaction["transactionAmount"]["amount"];
@ -119,7 +126,7 @@ class TransactionTransformer implements BankRevenueInterface
return [
'transaction_id' => 0,
'nordigen_transaction_id' => $transaction["transactionId"],
'nordigen_transaction_id' => $transactionId,
'amount' => $amount,
'currency_id' => $this->convertCurrency($transaction["transactionAmount"]["currency"]),
'category_id' => null,