From 7f231e952b300db387b6171e75e5a95b77e79fad Mon Sep 17 00:00:00 2001
From: David Bomba <turbo124@gmail.com>
Date: Sun, 16 Jul 2023 12:48:04 +1000
Subject: [PATCH 1/8] Fixes for tests

---
 tests/Feature/Export/ReportCsvGenerationTest.php | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/Feature/Export/ReportCsvGenerationTest.php b/tests/Feature/Export/ReportCsvGenerationTest.php
index 7abd3b151f91..28245ab22872 100644
--- a/tests/Feature/Export/ReportCsvGenerationTest.php
+++ b/tests/Feature/Export/ReportCsvGenerationTest.php
@@ -256,4 +256,5 @@ class ReportCsvGenerationTest extends TestCase
        
 
 
-}
+    }
+}
\ No newline at end of file

From c4a205ff0f10f81f55b393bbf618cbacf0f61ad2 Mon Sep 17 00:00:00 2001
From: David Bomba <turbo124@gmail.com>
Date: Sun, 16 Jul 2023 12:50:59 +1000
Subject: [PATCH 2/8] Fixes for tests

---
 tests/Feature/Export/ReportCsvGenerationTest.php | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tests/Feature/Export/ReportCsvGenerationTest.php b/tests/Feature/Export/ReportCsvGenerationTest.php
index 28245ab22872..918a8e78d8b7 100644
--- a/tests/Feature/Export/ReportCsvGenerationTest.php
+++ b/tests/Feature/Export/ReportCsvGenerationTest.php
@@ -14,6 +14,7 @@ namespace Tests\Feature\Export;
 use Tests\TestCase;
 use App\Models\User;
 use App\Models\Client;
+use App\Models\Credit;
 use League\Csv\Reader;
 use App\Models\Account;
 use App\Models\Company;
@@ -253,8 +254,8 @@ class ReportCsvGenerationTest extends TestCase
             'X-API-SECRET' => config('ninja.api_secret'),
             'X-API-TOKEN' => $this->token,
         ])->post('/api/v1/reports/credits', $data);
+
+        $response->assertStatus(200);
        
-
-
     }
 }
\ No newline at end of file

From 5e6b4f35ec27b2359f1449e4f60cfdce380161f9 Mon Sep 17 00:00:00 2001
From: David Bomba <turbo124@gmail.com>
Date: Sun, 16 Jul 2023 13:12:45 +1000
Subject: [PATCH 3/8] Updates for loader in client portal

---
 .../components/livewire/pdf-slot.blade.php    | 47 ++++++++++++++++---
 1 file changed, 41 insertions(+), 6 deletions(-)

diff --git a/resources/views/portal/ninja2020/components/livewire/pdf-slot.blade.php b/resources/views/portal/ninja2020/components/livewire/pdf-slot.blade.php
index ddde1a25a703..bfff352725a0 100644
--- a/resources/views/portal/ninja2020/components/livewire/pdf-slot.blade.php
+++ b/resources/views/portal/ninja2020/components/livewire/pdf-slot.blade.php
@@ -13,12 +13,8 @@
   </div>
   <div class="hidden lg:block">
     <div wire:init="getPdf()">
-        @if($pdf)
-        <!-- <iframe id="pdf-iframe" src="{!! $pdf !!}" class="h-screen w-full border-0 mt-4"></iframe> -->
-        <iframe id="pdf-iframe" src="/{{ $route_entity }}/showBlob/{{ $pdf }}" class="h-screen w-full border-0 mt-4"></iframe>
-        @else
         <div class="flex mt-4 place-items-center">
-            <span class="loader m-auto"></span>
+            <span class="loader m-auto" id="loader"></span>
             <style type="text/css">
             .loader {
             width: 48px;
@@ -54,6 +50,9 @@
           }
             </style>
         </div>
+        <!-- <iframe id="pdf-iframe" src="{!! $pdf !!}" class="h-screen w-full border-0 mt-4"></iframe> -->
+        @if($pdf)
+        <iframe id="pdf-iframe" src="/{{ $route_entity }}/showBlob/{{ $pdf }}" class="h-screen w-full border-0 mt-4"></iframe>
         @endif
     </div>
   </div>
@@ -61,4 +60,40 @@
   <div class="block lg:hidden">
     @include('portal.ninja2020.components.html-viewer')
   </div>
-</div>
\ No newline at end of file
+</div>
+
+
+<script type="text/javascript">
+
+  waitForElement("#pdf-iframe", 0).then(function(){
+    const iframe = document.getElementById("pdf-iframe");
+
+    iframe.addEventListener("load", function () {
+      const loader = document.getElementById("loader").hidden = "true";
+    });
+
+  });
+
+function waitForElement(querySelector, timeout){
+  return new Promise((resolve, reject)=>{
+    var timer = false;
+    if(document.querySelectorAll(querySelector).length) return resolve();
+    const observer = new MutationObserver(()=>{
+      if(document.querySelectorAll(querySelector).length){
+        observer.disconnect();
+        if(timer !== false) clearTimeout(timer);
+        return resolve();
+      }
+    });
+    observer.observe(document.body, {
+      childList: true, 
+      subtree: true
+    });
+    if(timeout) timer = setTimeout(()=>{
+      observer.disconnect();
+      reject();
+    }, timeout);
+  });
+}
+
+</script>
\ No newline at end of file

From 526485bcaf381edafde55f85d62f1bb21cd0b295 Mon Sep 17 00:00:00 2001
From: David Bomba <turbo124@gmail.com>
Date: Sun, 16 Jul 2023 14:28:56 +1000
Subject: [PATCH 4/8] Fixes for loader re-displaying inappropriately

---
 app/Http/Livewire/PdfSlot.php                 |  2 --
 .../components/livewire/pdf-slot.blade.php    | 19 +++++++++++--------
 2 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/app/Http/Livewire/PdfSlot.php b/app/Http/Livewire/PdfSlot.php
index 52736fb4e90b..c0f29b517a00 100644
--- a/app/Http/Livewire/PdfSlot.php
+++ b/app/Http/Livewire/PdfSlot.php
@@ -48,8 +48,6 @@ class PdfSlot extends Component
 
     private $entity_type;
 
-    protected $listeners = ['viewportChanged' => 'getPdf'];
-
     public $show_cost = true;
 
     public $show_quantity = true;
diff --git a/resources/views/portal/ninja2020/components/livewire/pdf-slot.blade.php b/resources/views/portal/ninja2020/components/livewire/pdf-slot.blade.php
index bfff352725a0..895624523532 100644
--- a/resources/views/portal/ninja2020/components/livewire/pdf-slot.blade.php
+++ b/resources/views/portal/ninja2020/components/livewire/pdf-slot.blade.php
@@ -1,20 +1,19 @@
 <div>
-  <div class="flex flex-col items-end mb-2">
-    <button wire:loading.attr="disabled" wire:click="downloadPdf" class="bg-gray-100 hover:bg-gray-200 text-gray-800 font-bold px-2 rounded inline-flex">
+  <div class="flex flex-col items-end mb-2" x-data>
+    <button wire:loading.attr="disabled" wire:click="downloadPdf" class="bg-gray-100 hover:bg-gray-200 text-gray-800 font-bold px-2 rounded inline-flex" type="button">
         <span>{{ ctrans('texts.download_pdf') }}</span>
         <div wire:loading wire:target="downloadPdf">
             <svg class="animate-spin h-5 w-5 text-blue" xmlns="http://www.w3.org/2000/svg" fill="none" viewBox="0 0 24 24">
                 <circle class="opacity-25" cx="12" cy="12" r="10" stroke="currentColor" stroke-width="4"></circle>
                 <path class="opacity-75" fill="currentColor" d="M4 12a8 8 0 018-8V0C5.373 0 0 5.373 0 12h4zm2 5.291A7.962 7.962 0 014 12H0c0 3.042 1.135 5.824 3 7.938l3-2.647z"></path>
             </svg>
-
         </div>
     </button>
   </div>
   <div class="hidden lg:block">
     <div wire:init="getPdf()">
-        <div class="flex mt-4 place-items-center">
-            <span class="loader m-auto" id="loader"></span>
+        <div class="flex mt-4 place-items-center" id="loader" wire:ignore>
+            <span class="loader m-auto" wire:ignore></span>
             <style type="text/css">
             .loader {
             width: 48px;
@@ -48,10 +47,10 @@
               75%  {clip-path:polygon(50% 50%,0 0,100% 0,100% 100%,0 100%,0 100%)}
               100% {clip-path:polygon(50% 50%,0 0,100% 0,100% 100%,0 100%,0 0)}
           }
-            </style>
+          </style>
         </div>
-        <!-- <iframe id="pdf-iframe" src="{!! $pdf !!}" class="h-screen w-full border-0 mt-4"></iframe> -->
         @if($pdf)
+        <!-- <iframe id="pdf-iframe" src="{!! $pdf !!}" class="h-screen w-full border-0 mt-4"></iframe> -->
         <iframe id="pdf-iframe" src="/{{ $route_entity }}/showBlob/{{ $pdf }}" class="h-screen w-full border-0 mt-4"></iframe>
         @endif
     </div>
@@ -69,7 +68,10 @@
     const iframe = document.getElementById("pdf-iframe");
 
     iframe.addEventListener("load", function () {
-      const loader = document.getElementById("loader").hidden = "true";
+      const loader = document.getElementById("loader")
+      loader.classList.add("hidden");
+      // loader.hidden=true;
+      // loader.remove();
     });
 
   });
@@ -94,6 +96,7 @@ function waitForElement(querySelector, timeout){
       reject();
     }, timeout);
   });
+
 }
 
 </script>
\ No newline at end of file

From f7841aced19492436204a6d10b8e1f6cb34c89e5 Mon Sep 17 00:00:00 2001
From: David Bomba <turbo124@gmail.com>
Date: Sun, 16 Jul 2023 15:09:05 +1000
Subject: [PATCH 5/8] Clean up for pdf slot

---
 .../portal/ninja2020/components/livewire/pdf-slot.blade.php     | 2 --
 1 file changed, 2 deletions(-)

diff --git a/resources/views/portal/ninja2020/components/livewire/pdf-slot.blade.php b/resources/views/portal/ninja2020/components/livewire/pdf-slot.blade.php
index 895624523532..992c75e86947 100644
--- a/resources/views/portal/ninja2020/components/livewire/pdf-slot.blade.php
+++ b/resources/views/portal/ninja2020/components/livewire/pdf-slot.blade.php
@@ -70,8 +70,6 @@
     iframe.addEventListener("load", function () {
       const loader = document.getElementById("loader")
       loader.classList.add("hidden");
-      // loader.hidden=true;
-      // loader.remove();
     });
 
   });

From 3cb7f79fd483f54c4440d30d996c92318c7231a2 Mon Sep 17 00:00:00 2001
From: David Bomba <turbo124@gmail.com>
Date: Sun, 16 Jul 2023 15:12:55 +1000
Subject: [PATCH 6/8] Updates for subdomains when importing

---
 app/Jobs/Util/Import.php | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/app/Jobs/Util/Import.php b/app/Jobs/Util/Import.php
index 1df1683a212e..0d2e837983ed 100644
--- a/app/Jobs/Util/Import.php
+++ b/app/Jobs/Util/Import.php
@@ -398,6 +398,9 @@ class Import implements ShouldQueue
         $data = $this->transformCompanyData($data);
 
         if (Ninja::isHosted()) {
+
+            $data['subdomain'] = str_replace("_","",$data['subdomain']);
+            
             if (!MultiDB::checkDomainAvailable($data['subdomain'])) {
                 $data['subdomain'] = MultiDB::randomSubdomainGenerator();
             }

From 073948facff0495b82a3d5d7b300525889244bd4 Mon Sep 17 00:00:00 2001
From: David Bomba <turbo124@gmail.com>
Date: Sun, 16 Jul 2023 15:44:54 +1000
Subject: [PATCH 7/8] Updates for filters

---
 app/Filters/ExpenseFilters.php       | 11 +++++++++++
 app/Filters/PurchaseOrderFilters.php |  5 +++++
 2 files changed, 16 insertions(+)

diff --git a/app/Filters/ExpenseFilters.php b/app/Filters/ExpenseFilters.php
index 6260c1b04b3c..b057ad3f27f9 100644
--- a/app/Filters/ExpenseFilters.php
+++ b/app/Filters/ExpenseFilters.php
@@ -164,6 +164,17 @@ class ExpenseFilters extends QueryFilters
             return $this->builder;
         }
 
+        if ($sort_col[0] == 'client_id') {
+            return $this->builder->orderBy(\App\Models\Client::select('name')
+                    ->whereColumn('clients.id', 'expenses.client_id'), $sort_col[1]);
+        }
+
+        if ($sort_col[0] == 'vendor_id') {
+            return $this->builder->orderBy(\App\Models\Vendor::select('name')
+                    ->whereColumn('vendors.id', 'expenses.vendor_id'), $sort_col[1]);
+        }
+
+
         if (is_array($sort_col) && in_array($sort_col[1], ['asc', 'desc']) && in_array($sort_col[0], ['public_notes', 'date', 'id_number', 'custom_value1', 'custom_value2', 'custom_value3', 'custom_value4'])) {
             return $this->builder->orderBy($sort_col[0], $sort_col[1]);
         }
diff --git a/app/Filters/PurchaseOrderFilters.php b/app/Filters/PurchaseOrderFilters.php
index 4b86b618ac09..8948a619f451 100644
--- a/app/Filters/PurchaseOrderFilters.php
+++ b/app/Filters/PurchaseOrderFilters.php
@@ -123,6 +123,11 @@ class PurchaseOrderFilters extends QueryFilters
             return $this->builder;
         }
 
+        if ($sort_col[0] == 'vendor_id') {
+            return $this->builder->orderBy(\App\Models\Vendor::select('name')
+                    ->whereColumn('vendors.id', 'purchase_orders.vendor_id'), $sort_col[1]);
+        }
+
         return $this->builder->orderBy($sort_col[0], $sort_col[1]);
     }
 

From af8a788dfb975cddeab6a8ec290d243730e1abe2 Mon Sep 17 00:00:00 2001
From: David Bomba <turbo124@gmail.com>
Date: Sun, 16 Jul 2023 16:36:52 +1000
Subject: [PATCH 8/8] Updates for deleting activities when purging clients

---
 app/Models/Client.php                  | 5 +++++
 app/Repositories/ClientRepository.php  | 2 +-
 app/Services/Payment/DeletePayment.php | 2 +-
 3 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/app/Models/Client.php b/app/Models/Client.php
index acd034b9643c..5896488cce73 100644
--- a/app/Models/Client.php
+++ b/app/Models/Client.php
@@ -347,6 +347,11 @@ class Client extends BaseModel implements HasLocalePreference
         return $this->hasMany(Credit::class)->withTrashed();
     }
 
+    public function purgeable_activities()
+    {
+        return $this->hasMany(Activity::class);
+    }
+
     public function activities()
     {
         return $this->hasMany(Activity::class)->take(50)->orderBy('id', 'desc');
diff --git a/app/Repositories/ClientRepository.php b/app/Repositories/ClientRepository.php
index ec324ef6934d..f9abbd6fa88b 100644
--- a/app/Repositories/ClientRepository.php
+++ b/app/Repositories/ClientRepository.php
@@ -136,7 +136,7 @@ class ClientRepository extends BaseRepository
         $client->projects()->forceDelete();
         $client->credits()->forceDelete();
         $client->quotes()->forceDelete();
-        $client->activities()->forceDelete();
+        $client->purgeable_activities()->forceDelete();
         $client->recurring_invoices()->forceDelete();
         $client->expenses()->forceDelete();
         $client->recurring_expenses()->forceDelete();
diff --git a/app/Services/Payment/DeletePayment.php b/app/Services/Payment/DeletePayment.php
index fb50797b64f5..98242ecb8543 100644
--- a/app/Services/Payment/DeletePayment.php
+++ b/app/Services/Payment/DeletePayment.php
@@ -148,7 +148,7 @@ class DeletePayment
 
                 $client
                 ->service()
-                ->updatePaidToDate(($paymentable_credit->pivot->amount) * -1)
+                // ->updatePaidToDate(($paymentable_credit->pivot->amount) * -1)
                 ->adjustCreditBalance($paymentable_credit->pivot->amount)
                 ->save();
             });