From 3dec3f07bfc0b95a5d3dbc7695b5f7038c84b5a0 Mon Sep 17 00:00:00 2001
From: Hillel Coren <hillelcoren@gmail.com>
Date: Tue, 23 Jan 2018 16:06:33 +0200
Subject: [PATCH] Fix design select options

---
 app/Models/InvoiceDesign.php | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/app/Models/InvoiceDesign.php b/app/Models/InvoiceDesign.php
index 7b5558533de9..2e1ec1314a33 100644
--- a/app/Models/InvoiceDesign.php
+++ b/app/Models/InvoiceDesign.php
@@ -75,9 +75,11 @@ class InvoiceDesign extends Eloquent
         $account = Auth::user()->account;
         $designs = Cache::get('invoiceDesigns');
 
+        $data = collect();
+
         foreach ($designs as $design) {
-            if ($design->id > Auth::user()->maxInvoiceDesignId()) {
-                $designs->pull($design->id);
+            if ($design->id <= Auth::user()->maxInvoiceDesignId()) {
+                $data->push($design);
             }
 
             $design->javascript = $design->pdfmake;
@@ -87,11 +89,11 @@ class InvoiceDesign extends Eloquent
                 if ($javascript = $account->getCustomDesign($design->id)) {
                     $design->javascript = $javascript;
                 } else {
-                    $designs->forget($design->id - 1);
+                    $data->forget($design->id - 1);
                 }
             }
         }
 
-        return $designs;
+        return $data;
     }
 }