From 3ed45ad27f29db3d1260d3957c9ab47b418559a8 Mon Sep 17 00:00:00 2001 From: David Bomba Date: Sat, 25 Mar 2023 11:02:43 +1100 Subject: [PATCH] Refactor for taxes --- app/DataMapper/Tax/us/Rule.php | 2 +- app/Helpers/Invoice/InvoiceItemSum.php | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/app/DataMapper/Tax/us/Rule.php b/app/DataMapper/Tax/us/Rule.php index 6259faeb43ec..7fee2564dac3 100644 --- a/app/DataMapper/Tax/us/Rule.php +++ b/app/DataMapper/Tax/us/Rule.php @@ -153,7 +153,7 @@ class Rule implements RuleInterface public function default(): self { - $this->tax_name1 = ''; + $this->tax_name1 = 'Tax Exempt'; $this->tax_rate1 = 0; return $this; diff --git a/app/Helpers/Invoice/InvoiceItemSum.php b/app/Helpers/Invoice/InvoiceItemSum.php index e6d389a468e7..f093962f7f98 100644 --- a/app/Helpers/Invoice/InvoiceItemSum.php +++ b/app/Helpers/Invoice/InvoiceItemSum.php @@ -104,7 +104,6 @@ class InvoiceItemSum { if (!$this->invoice->company->calculate_taxes || $this->client->is_tax_exempt) { $this->calc_tax = false; - nlog("returning false"); return $this; } @@ -115,8 +114,6 @@ class InvoiceItemSum $this->rule = new $class($tax_data); - nlog("returning true"); - $this->calc_tax = true; return $this;