From 40a16226ebd148c1b80578e7362b78ca149a3f89 Mon Sep 17 00:00:00 2001 From: David Bomba Date: Mon, 17 Jul 2023 12:01:35 +1000 Subject: [PATCH] Fixes for proteted downloads --- app/Http/Controllers/ProtectedDownloadController.php | 6 ++++-- routes/api.php | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/app/Http/Controllers/ProtectedDownloadController.php b/app/Http/Controllers/ProtectedDownloadController.php index d7277d69f383..c333539b99ab 100644 --- a/app/Http/Controllers/ProtectedDownloadController.php +++ b/app/Http/Controllers/ProtectedDownloadController.php @@ -29,8 +29,10 @@ class ProtectedDownloadController extends BaseController throw new SystemError('File no longer available', 404); abort(404, 'File no longer available'); } - - return response()->download($hashed_path, basename($hashed_path), [])->deleteFileAfterSend(true); + + return response()->streamDownload(function () use ($hashed_path) { + echo Storage::get($hashed_path); + }, basename($hashed_path), []); } diff --git a/routes/api.php b/routes/api.php index 97c8550b3417..56de0b9dd319 100644 --- a/routes/api.php +++ b/routes/api.php @@ -406,6 +406,6 @@ Route::post('api/v1/yodlee/data_updates', [YodleeController::class, 'dataUpdates Route::post('api/v1/yodlee/refresh_updates', [YodleeController::class, 'refreshUpdatesWebhook'])->middleware('throttle:100,1'); Route::post('api/v1/yodlee/balance', [YodleeController::class, 'balanceWebhook'])->middleware('throttle:100,1'); -Route::get('api/v1/protected_download/{hash}', [ProtectedDownloadController::class, 'index'])->name('protected_download')->middleware('signed')->middleware('throttle:300,1'); +Route::get('api/v1/protected_download/{hash}', [ProtectedDownloadController::class, 'index'])->name('protected_download')->middleware('throttle:300,1'); Route::fallback([BaseController::class, 'notFound'])->middleware('throttle:404'); \ No newline at end of file