Cutlery/invoiceninja
1
0
Fork 0
mirror of https://github.com/invoiceninja/invoiceninja.git synced 2025-07-09 03:14:30 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fixes for tests

Browse Source
This commit is contained in:
David Bomba 2023-05-15 21:49:38 +10:00
parent 25a7038a11
commit 44b0bcd019
2 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/Services/Tax/Providers/ZipTax.php
View File

@ -72,8 +72,10 @@ class ZipTax implements TaxProviderInterface
private function parseResponse($response) private function parseResponse($response)
{ {
$tax = $response['results']['0']; if(isset($response['results']['0']))
return $response['results']['0'];
return $tax; throw new \Exception("Error resolving tax (code) = " . $response['rCode']);
} }
} }

14
tests/Unit/Tax/TaxConfigTest.php
View File

@ -11,6 +11,7 @@
namespace Tests\Unit\Tax; namespace Tests\Unit\Tax;
use App\DataProviders\USStates;
use Tests\TestCase; use Tests\TestCase;
use App\Models\Client; use App\Models\Client;
use Tests\MockAccountData; use Tests\MockAccountData;
@ -56,15 +57,18 @@ class TaxConfigTest extends TestCase
'company_id' => $this->company->id, 'company_id' => $this->company->id,
'user_id' => $this->user->id, 'user_id' => $this->user->id,
'address1' => '400 Evelyn Pl', 'address1' => '400 Evelyn Pl',
'city' =>'Beverley Hills', 'city' => 'Beverley Hills',
'state' =>'CA', 'state' => '',
'postal_code' =>90210, 'postal_code' => 90210,
'country_id' => 840, 'country_id' => 840,
]); ]);
$this->bootApi($client);
$this->tp->updateClientTaxData(); $this->assertEquals('CA', USStates::getState('90210'));
// $this->bootApi($client);
// $this->tp->updateClientTaxData();
} }