diff --git a/app/Import/Transformers/BaseTransformer.php b/app/Import/Transformers/BaseTransformer.php index 72a76edc0934..f0b2721c3e55 100644 --- a/app/Import/Transformers/BaseTransformer.php +++ b/app/Import/Transformers/BaseTransformer.php @@ -146,7 +146,7 @@ class BaseTransformer $number = 0; } - return Number::parseStringFloat($number); + return Number::parseFloat($number); } /** diff --git a/tests/Unit/NumberTest.php b/tests/Unit/NumberTest.php index 254ec236398b..fa12911a8760 100644 --- a/tests/Unit/NumberTest.php +++ b/tests/Unit/NumberTest.php @@ -41,6 +41,27 @@ class NumberTest extends TestCase $this->assertEquals(2.15, $rounded); } + //this method proved an error! removing this method from production + // public function testImportFloatConversion() + // { + + // $amount = '€7,99'; + + // $converted_amount = Number::parseStringFloat($amount); + + // $this->assertEquals(799, $converted_amount); + + // } + + public function testParsingStringCurrency() + { + $amount = '€7,99'; + + $converted_amount = Number::parseFloat($amount); + + $this->assertEquals(7.99, $converted_amount); + } + // public function testParsingFloats() // { // Currency::all()->each(function ($currency) {