From 8164d4000771559ccfe1508b4be457da4930c7f6 Mon Sep 17 00:00:00 2001
From: David Bomba <turbo124@gmail.com>
Date: Mon, 13 Jun 2022 09:33:40 +1000
Subject: [PATCH] MInor fixes for correct disk configuration

---
 app/Jobs/Entity/CreateEntityPdf.php           | 4 ++--
 app/Services/Invoice/GenerateDeliveryNote.php | 2 --
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/app/Jobs/Entity/CreateEntityPdf.php b/app/Jobs/Entity/CreateEntityPdf.php
index 4a5be2b5887a..256c618ae9f7 100644
--- a/app/Jobs/Entity/CreateEntityPdf.php
+++ b/app/Jobs/Entity/CreateEntityPdf.php
@@ -70,7 +70,7 @@ class CreateEntityPdf implements ShouldQueue
      *
      * @param $invitation
      */
-    public function __construct($invitation, $disk = 'public')
+    public function __construct($invitation, $disk = null)
     {
         $this->invitation = $invitation;
 
@@ -99,7 +99,7 @@ class CreateEntityPdf implements ShouldQueue
         $this->client = $invitation->contact->client;
         $this->client->load('company');
         
-        $this->disk = Ninja::isHosted() ? config('filesystems.default') : $disk;
+        $this->disk = $disk ?? config('filesystems.default');
 
     }
 
diff --git a/app/Services/Invoice/GenerateDeliveryNote.php b/app/Services/Invoice/GenerateDeliveryNote.php
index 1546a05b62bf..39851845ff77 100644
--- a/app/Services/Invoice/GenerateDeliveryNote.php
+++ b/app/Services/Invoice/GenerateDeliveryNote.php
@@ -49,8 +49,6 @@ class GenerateDeliveryNote
 
         $this->contact = $contact;
 
-        // $this->disk = 'public';
-
         $this->disk = $disk ?? config('filesystems.default');
     }