From 52800bdc4bd82cd164f3d27813bf72906634eaff Mon Sep 17 00:00:00 2001 From: David Bomba Date: Mon, 6 May 2019 15:34:59 +1000 Subject: [PATCH] Minor refactors --- app/Http/Controllers/InvoiceController.php | 4 ++-- app/Repositories/ClientContactRepository.php | 1 + app/Repositories/InvoiceRepository.php | 4 ++-- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/app/Http/Controllers/InvoiceController.php b/app/Http/Controllers/InvoiceController.php index ce8d3bc5c1e2..b301416c09bf 100644 --- a/app/Http/Controllers/InvoiceController.php +++ b/app/Http/Controllers/InvoiceController.php @@ -100,7 +100,7 @@ class InvoiceController extends BaseController public function store(StoreInvoiceRequest $request) { - $invoice = $this->invoice_repo->save($request, InvoiceFactory::create(auth()->user()->company()->id, auth()->user()->id)); + $invoice = $this->invoice_repo->save($request->all(), InvoiceFactory::create(auth()->user()->company()->id, auth()->user()->id)); return $this->itemResponse($invoice); @@ -147,7 +147,7 @@ class InvoiceController extends BaseController public function update(UpdateInvoiceRequest $request, Invoice $invoice) { - $invoice = $this->invoice_repo->save(request(), $invoice); + $invoice = $this->invoice_repo->save($request->all(), $invoice); return $this->itemResponse($invoice); diff --git a/app/Repositories/ClientContactRepository.php b/app/Repositories/ClientContactRepository.php index 318c59bf6f09..f14d775ac229 100644 --- a/app/Repositories/ClientContactRepository.php +++ b/app/Repositories/ClientContactRepository.php @@ -27,6 +27,7 @@ class ClientContactRepository extends BaseRepository $contacts->first(function($contact){ $contact['is_primary'] = true; + $contact->save(); }); //loop and update/create contacts diff --git a/app/Repositories/InvoiceRepository.php b/app/Repositories/InvoiceRepository.php index c8aa469c38b7..8cfc4218ca8d 100644 --- a/app/Repositories/InvoiceRepository.php +++ b/app/Repositories/InvoiceRepository.php @@ -18,9 +18,9 @@ class InvoiceRepository extends BaseRepository return Invoice::class; } - public function save(Request $request, Invoice $invoice) : ?Invoice + public function save($data, Invoice $invoice) : ?Invoice { - $invoice->fill($request->input()); + $invoice->fill($data); $invoice->save();