diff --git a/app/Http/Requests/Nordigen/ConnectNordigenBankIntegrationRequest.php b/app/Http/Requests/Nordigen/ConnectNordigenBankIntegrationRequest.php index f4834d05d385..b3c0ebf89be1 100644 --- a/app/Http/Requests/Nordigen/ConnectNordigenBankIntegrationRequest.php +++ b/app/Http/Requests/Nordigen/ConnectNordigenBankIntegrationRequest.php @@ -55,7 +55,6 @@ class ConnectNordigenBankIntegrationRequest extends Request $input["redirect"] = isset($context['is_react']) && $context['is_react'] ? config('ninja.react_url') : config('ninja.app_url'); $this->replace($input); - } } public function getTokenContent() @@ -74,15 +73,12 @@ class ConnectNordigenBankIntegrationRequest extends Request MultiDB::findAndSetDbByCompanyKey($this->getTokenContent()['company_key']); return User::findOrFail($this->getTokenContent()['user_id']); - } public function getCompany() { - MultiDB::findAndSetDbByCompanyKey($this->getTokenContent()['company_key']); return Company::where('company_key', $this->getTokenContent()['company_key'])->firstOrFail(); - } } diff --git a/app/Jobs/Bank/ProcessBankTransactionsNordigen.php b/app/Jobs/Bank/ProcessBankTransactionsNordigen.php index 454c288236a4..7862775c5bab 100644 --- a/app/Jobs/Bank/ProcessBankTransactionsNordigen.php +++ b/app/Jobs/Bank/ProcessBankTransactionsNordigen.php @@ -56,7 +56,6 @@ class ProcessBankTransactionsNordigen implements ShouldQueue */ public function handle() { - if ($this->bank_integration->integration_type != BankIntegration::INTEGRATION_TYPE_NORDIGEN) throw new \Exception("Invalid BankIntegration Type"); @@ -111,7 +110,6 @@ class ProcessBankTransactionsNordigen implements ShouldQueue // Perform Matching BankMatchingService::dispatch($this->company->id, $this->company->db); - } private function updateAccount() @@ -132,12 +130,10 @@ class ProcessBankTransactionsNordigen implements ShouldQueue $this->bank_integration->balance = $this->nordigen_account['current_balance']; $this->bank_integration->save(); - } private function processTransactions() { - //Get transaction count object $transactions = $this->nordigen->getTransactions($this->bank_integration->nordigen_account_id, $this->from_date); @@ -183,6 +179,5 @@ class ProcessBankTransactionsNordigen implements ShouldQueue $this->bank_integration->from_date = now()->subDays(5); $this->bank_integration->save(); - } } diff --git a/app/Jobs/Bank/ProcessBankTransactionsYodlee.php b/app/Jobs/Bank/ProcessBankTransactionsYodlee.php index 0d2122c6733c..17f7f61a5abb 100644 --- a/app/Jobs/Bank/ProcessBankTransactionsYodlee.php +++ b/app/Jobs/Bank/ProcessBankTransactionsYodlee.php @@ -62,7 +62,6 @@ class ProcessBankTransactionsYodlee implements ShouldQueue */ public function handle() { - if ($this->bank_integration->integration_type != BankIntegration::INTEGRATION_TYPE_YODLEE) throw new \Exception("Invalid BankIntegration Type"); @@ -96,7 +95,6 @@ class ProcessBankTransactionsYodlee implements ShouldQueue private function processTransactions() { - $yodlee = new Yodlee($this->account->bank_integration_account_id); if (!$yodlee->getAccount($this->bank_integration->bank_account_id)) { diff --git a/app/Jobs/Ninja/BankTransactionSync.php b/app/Jobs/Ninja/BankTransactionSync.php index 04a08f8531c8..cfe218d91c74 100644 --- a/app/Jobs/Ninja/BankTransactionSync.php +++ b/app/Jobs/Ninja/BankTransactionSync.php @@ -45,7 +45,7 @@ class BankTransactionSync implements ShouldQueue */ public function handle() { - //multiDB environment, need to + // multiDB environment, need to @turbo124 do we need any changes here for selfhosted non-multidb envs foreach (MultiDB::$dbs as $db) { MultiDB::setDB($db);