Merge pull request #9074 from turbo124/v5-develop

Nordigen / GoCardless updates.

app/Filters/UserFilters.php

@@ -66,21 +66,44 @@ class UserFilters extends QueryFilters
      */
     public function entityFilter()
     {
-        return $this->builder->whereHas('company_users', function ($q) {
+
-            $q->where('company_id', '=', auth()->user()->company()->id);
+        /** @var \App\Models\User $user */
+        $user = auth()->user();
+
+        return $this->builder->whereHas('company_users', function ($q) use ($user){
+            $q->where('company_id', '=', $user->company()->id);
         });
     }
     
+    /**
+     * Hides owner users from the list.
+     *
+     * @return Builder
+     */
+    public function hideOwnerUsers(): Builder
+    {
+        /** @var \App\Models\User $user */
+        $user = auth()->user();
+        
+        return $this->builder->whereHas('company_users', function ($q) use ($user) {
+            $q->where('company_id', '=', $user->company()->id)->where('is_owner', false);
+        });
+
+    }
+
     /**
      * Filters users that have been removed from the
      * company, but not deleted from the system.
      *
-     * @return void
+     * @return Builder
      */
-    public function hideRemovedUsers()
+    public function hideRemovedUsers(): Builder
     {
-        return $this->builder->whereHas('company_users', function ($q) {
+        /** @var \App\Models\User $user */
-            $q->where('company_id', '=', auth()->user()->company()->id)->whereNull('deleted_at');
+        $user = auth()->user();
+
+        return $this->builder->whereHas('company_users', function ($q) use ($user) {
+            $q->where('company_id', '=', $user->company()->id)->whereNull('deleted_at');
         });
     }
 
@@ -98,12 +121,21 @@ class UserFilters extends QueryFilters
             return $this->builder;
         }
 
+        /** @var \App\Models\User $user */
+        $user = auth()->user();
+
         return $this->builder
             ->orWhere($this->with_property, $value)
             ->orderByRaw("{$this->with_property} = ? DESC", [$value])
-            ->where('account_id', auth()->user()->account_id);
+            ->where('account_id', $user->account_id);
     }
         
+    /**
+     * Returns users with permissions to send emails via OAuth
+     *
+     * @param  string $value
+     * @return Builder
+     */
     public function sending_users(string $value = ''): Builder
     {
         if (strlen($value) == 0 || $value != 'true') {

app/Helpers/Bank/Nordigen/Nordigen.php

@@ -39,7 +39,7 @@ class Nordigen
 
         $this->client = new \Nordigen\NordigenPHP\API\NordigenClient(config('ninja.nordigen.secret_id'), config('ninja.nordigen.secret_key'));
 
-        $this->client->createAccessToken(); // access_token is valid 24h -> so we dont have to implement a refresh-cycle
+        $this->client->createAccessToken();
     }
 
     // metadata-section for frontend
@@ -52,12 +52,12 @@ class Nordigen
     }
 
     // requisition-section
-    public function createRequisition(string $redirect, string $initutionId, string $reference)
+    public function createRequisition(string $redirect, string $initutionId, string $reference, string $userLanguage)
     {
         if ($this->test_mode && $initutionId != $this->sandbox_institutionId)
             throw new \Exception('invalid institutionId while in test-mode');
 
-        return $this->client->requisition->createRequisition($redirect, $initutionId, null, $reference);
+        return $this->client->requisition->createRequisition($redirect, $initutionId, null, $reference, $userLanguage);
     }
 
     public function getRequisition(string $requisitionId)
@@ -85,6 +85,7 @@ class Nordigen
 
             $it = new AccountTransformer();
             return $it->transform($out);
+            
         } catch (\Exception $e) {
             if (strpos($e->getMessage(), "Invalid Account ID") !== false)
                 return false;
@@ -93,7 +94,13 @@ class Nordigen
         }
     }
     
-    public function isAccountActive(string $account_id)
+    /**
+     * isAccountActive
+     *
+     * @param  string $account_id
+     * @return bool
+     */
+    public function isAccountActive(string $account_id): bool
     {
         try {
             $account = $this->client->account($account_id)->getAccountMetaData();
@@ -112,11 +119,15 @@ class Nordigen
         }
     }
 
+    
     /**
-     * this method returns booked transactions from the bank_account, pending transactions are not part of the result
+     * getTransactions
-     * @todo @turbo124 should we include pending transactions within the integration-process and mark them with a specific category?!
+     *
+     * @param  string $accountId
+     * @param  string $dateFrom
+     * @return array
      */
-    public function getTransactions(string $accountId, string $dateFrom = null)
+    public function getTransactions(string $accountId, string $dateFrom = null): array
     {
         $transactionResponse = $this->client->account($accountId)->getAccountTransactions($dateFrom);
 

app/Helpers/Bank/Nordigen/Transformer/TransactionTransformer.php

@@ -113,8 +113,8 @@ class TransactionTransformer implements BankRevenueInterface
             'transaction_id' => $transaction["transactionId"],
             'amount' => abs((int) $transaction["transactionAmount"]["amount"]),
             'currency_id' => $this->convertCurrency($transaction["transactionAmount"]["currency"]),
-            'category_id' => null, // nordigen has no categories
+            'category_id' => null,
-            'category_type' => array_key_exists('additionalInformation', $transaction) ? $transaction["additionalInformation"] : null, // TODO: institution specific keys like: GUTSCHRIFT, ABSCHLUSS, MONATSABSCHLUSS etc
+            'category_type' => array_key_exists('additionalInformation', $transaction) ? $transaction["additionalInformation"] : '',
             'date' => $transaction["bookingDate"],
             'description' => $description,
             'participant' => $participant,

app/Http/Controllers/Bank/NordigenController.php

@@ -31,8 +31,11 @@ class NordigenController extends BaseController
     public function connect(ConnectNordigenBankIntegrationRequest $request)
     {
         $data = $request->all();
+
+        /** @var array $context */
         $context = $request->getTokenContent();
-        $lang = $data['lang'] ?? 'en';
+        $company = $request->getCompany();
+        $lang = $company->locale();
         $context["lang"] = $lang;
 
         if (!$context)
@@ -62,7 +65,7 @@ class NordigenController extends BaseController
                 "redirectUrl" => $context["redirect"] . "?action=nordigen_connect&status=failed&reason=account-config-invalid",
             ]);
 
-        if (!(Ninja::isSelfHost() || (Ninja::isHosted() && $account->isPaid() && $account->plan == 'enterprise')))
+        if (!(Ninja::isSelfHost() || (Ninja::isHosted() && $account->isEnterprisePaidClient())))
             return view('bank.nordigen.handler', [
                 'lang' => $lang,
                 'company' => $company,
@@ -85,7 +88,7 @@ class NordigenController extends BaseController
 
         // redirect to requisition flow
         try {
-            $requisition = $nordigen->createRequisition(config('ninja.app_url') . '/nordigen/confirm', $data['institution_id'], $request->token);
+            $requisition = $nordigen->createRequisition(config('ninja.app_url') . '/nordigen/confirm', $data['institution_id'], $request->token, $lang);
         } catch (NordigenException $e) { // TODO: property_exists returns null in these cases... => why => therefore we just get unknown error everytime $responseBody is typeof GuzzleHttp\Psr7\Stream
             $responseBody = (string) $e->getResponse()->getBody();
 
@@ -128,15 +131,19 @@ class NordigenController extends BaseController
 
     /**
      * VIEW: Confirm Nordigen Bank Integration (redirect after nordigen flow)
-     * @param ConnectNordigenBankIntegrationRequest $request
+     * @param ConfirmNordigenBankIntegrationRequest $request
      */
     public function confirm(ConfirmNordigenBankIntegrationRequest $request)
     {
         $data = $request->all();
+        $company = $request->getCompany();
+        $account = $company->account;
+        $lang = $company->locale();
+
+        /** @var array $context */
         $context = $request->getTokenContent();
         if (!array_key_exists('lang', $data) && $context['lang'] != 'en')
-            return redirect()->route('nordigen.confirm', array_merge(["lang" => $context['lang']], $request->query())); // redirect is required in order for the bank-ui to display everything properly
+            return redirect()->route('nordigen.confirm', array_merge(["lang" => $context['lang']], $request->query()));
-        $lang = $data['lang'] ?? 'en';
 
         if (!$context || $context["context"] != "nordigen" || !array_key_exists("requisitionId", $context))
             return view('bank.nordigen.handler', [
@@ -145,9 +152,6 @@ class NordigenController extends BaseController
                 "redirectUrl" => ($context && array_key_exists("redirect", $context) ? $context["redirect"] : config('ninja.app_url')) . "?action=nordigen_connect&status=failed&reason=ref-invalid",
             ]);
 
-        $company = $request->getCompany();
-        $account = $company->account;
-
         if (!(config('ninja.nordigen.secret_id') && config('ninja.nordigen.secret_key')))
             return view('bank.nordigen.handler', [
                 'lang' => $lang,

app/Http/Controllers/BankIntegrationController.php

@@ -212,7 +212,7 @@ class BankIntegrationController extends BaseController
                 ProcessBankTransactionsYodlee::dispatch($user_account->id, $bank_integration);
             });
 
-        if (config('ninja.nordigen.secret_id') && config('ninja.nordigen.secret_key') && (Ninja::isSelfHost() || (Ninja::isHosted() && $user_account->isPaid() && $user_account->plan == 'enterprise')))
+        if (config('ninja.nordigen.secret_id') && config('ninja.nordigen.secret_key') && (Ninja::isSelfHost() || (Ninja::isHosted() && $user_account->isEnterprisePaidClient())))
             $user_account->bank_integrations->where("integration_type", BankIntegration::INTEGRATION_TYPE_NORDIGEN)->each(function ($bank_integration) {
                 ProcessBankTransactionsNordigen::dispatch($bank_integration);
             });
@@ -298,11 +298,14 @@ class BankIntegrationController extends BaseController
 
         $account = $user->account;
 
-        $bank_integration = BankIntegration::withTrashed()->where('bank_account_id', $acc_id)->orWhere('nordigen_account_id', $acc_id)->company()->firstOrFail(); // @turbo124 please check
+        $bank_integration = BankIntegration::withTrashed()
+                                        ->where('bank_account_id', $acc_id)
+                                        ->orWhere('nordigen_account_id', $acc_id)
+                                        ->company()
+                                        ->firstOrFail();
 
         if ($bank_integration->integration_type == BankIntegration::INTEGRATION_TYPE_YODLEE)
             $this->removeAccountYodlee($account, $bank_integration);
-        // we dont remove Accounts from nordigen, because they could be used within other companies
 
         $this->bank_integration_repo->delete($bank_integration);
 

app/Http/Requests/Nordigen/ConnectNordigenBankIntegrationRequest.php

@@ -36,24 +36,19 @@ class ConnectNordigenBankIntegrationRequest extends Request
     public function rules()
     {
         return [
-            'lang' => 'string',
-            'institution_id' => 'string',
-            'redirect' => 'string',
         ];
     }
 
-    // @turbo124 @todo please check for validity, when request from frontend
     public function prepareForValidation()
     {
         $input = $this->all();
 
-        if (!array_key_exists('redirect', $input)) {
         $context = $this->getTokenContent();
 
         $input["redirect"] = isset($context["is_react"]) && $context['is_react'] ? config('ninja.react_url') . "/#/settings/bank_accounts" : config('ninja.app_url');
 
         $this->replace($input);
-        }
+       
     }
     public function getTokenContent()
     {

app/Http/ValidationRules/Account/BlackListRule.php

@@ -11,14 +11,19 @@
 
 namespace App\Http\ValidationRules\Account;
 
-use Illuminate\Contracts\Validation\Rule;
+use Closure;
+use Illuminate\Contracts\Validation\ValidationRule;
 
 /**
  * Class BlackListRule.
  */
-class BlackListRule implements Rule
+class BlackListRule implements ValidationRule
 {
+    /** Bad domains +/- dispoable email domains */
     private array $blacklist = [
+        'secure-coinspot.com',
+        'casasotombo.com',
+        'otpku.com',
         'ckptr.com',
         'pretreer.com',
         'candassociates.com',
@@ -57,6 +62,8 @@ class BlackListRule implements Rule
         '10dk.email',
         '10mail.com',
         '10mail.org',
+        '10mail.tk',
+        '10minmail.de',
         '10minut.com.pl',
         '10minut.xyz',
         '10minutemail.be',
@@ -75,6 +82,7 @@ class BlackListRule implements Rule
         '10minutemailbox.com',
         '10minutemails.in',
         '10minutenemail.de',
+        '10minutenmail.xyz',
         '10minutesmail.com',
         '10minutesmail.fr',
         '10minutmail.pl',
@@ -268,6 +276,7 @@ class BlackListRule implements Rule
         'affinitywe.us',
         'affluentwe.us',
         'affordablewe.us',
+        'afia.pro',
         'afrobacon.com',
         'afterhourswe.us',
         'agedmail.com',
@@ -287,6 +296,8 @@ class BlackListRule implements Rule
         'akapost.com',
         'akerd.com',
         'akgq701.com',
+        'akmail.in',
+        'akugu.com',
         'al-qaeda.us',
         'albionwe.us',
         'alchemywe.us',
@@ -294,6 +305,7 @@ class BlackListRule implements Rule
         'aliaswe.us',
         'alienware13.com',
         'aligamel.com',
+        'alina-schiesser.ch',
         'alisongamel.com',
         'alivance.com',
         'alivewe.us',
@@ -376,6 +388,7 @@ class BlackListRule implements Rule
         'antispam.de',
         'antispam24.de',
         'antispammail.de',
+        'any.pink',
         'anyalias.com',
         'aoeuhtns.com',
         'apfelkorps.de',
@@ -440,10 +453,12 @@ class BlackListRule implements Rule
         'badoop.com',
         'badpotato.tk',
         'balaket.com',
+        'bangban.uk',
         'banit.club',
         'banit.me',
         'bank-opros1.ru',
         'bareed.ws',
+        'barooko.com',
         'barryogorman.com',
         'bartdevos.be',
         'basscode.org',
@@ -451,11 +466,15 @@ class BlackListRule implements Rule
         'bazaaboom.com',
         'bbbbyyzz.info',
         'bbhost.us',
+        'bbitf.com',
+        'bbitj.com',
+        'bbitq.com',
         'bcaoo.com',
         'bcast.ws',
         'bcb.ro',
         'bccto.me',
         'bdmuzic.pw',
+        'beaconmessenger.com',
         'bearsarefuzzy.com',
         'beddly.com',
         'beefmilk.com',
@@ -477,6 +496,7 @@ class BlackListRule implements Rule
         'betr.co',
         'bgtmail.com',
         'bgx.ro',
+        'bheps.com',
         'bidourlnks.com',
         'big1.us',
         'bigprofessor.so',
@@ -520,9 +540,11 @@ class BlackListRule implements Rule
         'bouncr.com',
         'boxformail.in',
         'boximail.com',
+        'boxmail.lol',
         'boxomail.live',
         'boxtemp.com.br',
         'bptfp.net',
+        'brand-app.biz',
         'brandallday.net',
         'brasx.org',
         'breakthru.com',
@@ -543,8 +565,10 @@ class BlackListRule implements Rule
         'budaya-tionghoa.com',
         'budayationghoa.com',
         'buffemail.com',
+        'bugfoo.com',
         'bugmenever.com',
         'bugmenot.com',
+        'bukhariansiddur.com',
         'bulrushpress.com',
         'bum.net',
         'bumpymail.com',
@@ -582,6 +606,7 @@ class BlackListRule implements Rule
         'caseedu.tk',
         'cashflow35.com',
         'casualdx.com',
+        'catgroup.uk',
         'cavi.mx',
         'cbair.com',
         'cbes.net',
@@ -605,6 +630,7 @@ class BlackListRule implements Rule
         'cheaphub.net',
         'cheatmail.de',
         'chenbot.email',
+        'chewydonut.com',
         'chibakenma.ml',
         'chickenkiller.com',
         'chielo.com',
@@ -621,6 +647,7 @@ class BlackListRule implements Rule
         'chong-mail.org',
         'chumpstakingdumps.com',
         'cigar-auctions.com',
+        'civikli.com',
         'civx.org',
         'ckaazaza.tk',
         'ckiso.com',
@@ -637,6 +664,7 @@ class BlackListRule implements Rule
         'clonemoi.tk',
         'cloud-mail.top',
         'cloudns.cx',
+        'clout.wiki',
         'clrmail.com',
         'cmail.club',
         'cmail.com',
@@ -678,6 +706,7 @@ class BlackListRule implements Rule
         'crazymailing.com',
         'cream.pink',
         'crepeau12.com',
+        'cringemonster.com',
         'cross-law.ga',
         'cross-law.gq',
         'crossmailjet.com',
@@ -733,6 +762,7 @@ class BlackListRule implements Rule
         'daymailonline.com',
         'dayrep.com',
         'dbunker.com',
+        'dcctb.com',
         'dcemail.com',
         'ddcrew.com',
         'de-a.org',
@@ -769,6 +799,7 @@ class BlackListRule implements Rule
         'dev-null.ga',
         'dev-null.gq',
         'dev-null.ml',
+        'developermail.com',
         'devnullmail.com',
         'deyom.com',
         'dharmatel.net',
@@ -800,6 +831,7 @@ class BlackListRule implements Rule
         'discardmail.com',
         'discardmail.de',
         'discos4.com',
+        'dishcatfish.com',
         'disign-concept.eu',
         'disign-revelation.com',
         'dispo.in',
@@ -851,10 +883,12 @@ class BlackListRule implements Rule
         'domforfb8.tk',
         'domforfb9.tk',
         'domozmail.com',
+        'donebyngle.com',
         'donemail.ru',
         'dongqing365.com',
         'dontreg.com',
         'dontsendmespam.de',
+        'doojazz.com',
         'doquier.tk',
         'dotman.de',
         'dotmsg.com',
@@ -869,13 +903,17 @@ class BlackListRule implements Rule
         'dred.ru',
         'drevo.si',
         'drivetagdev.com',
+        'drmail.in',
         'droolingfanboy.de',
         'dropcake.de',
         'dropjar.com',
         'droplar.com',
         'dropmail.me',
         'dropsin.net',
+        'drowblock.com',
+        'dsgvo.party',
         'dsgvo.ru',
+        'dshfjdafd.cloud',
         'dsiay.com',
         'dspwebservices.com',
         'duam.net',
@@ -944,6 +982,7 @@ class BlackListRule implements Rule
         'emailage.ml',
         'emailage.tk',
         'emailate.com',
+        'emailbin.net',
         'emailcu.icu',
         'emaildienst.de',
         'emaildrop.io',
@@ -1017,8 +1056,11 @@ class BlackListRule implements Rule
         'eposta.buzz',
         'eposta.work',
         'eqiluxspam.ga',
+        'ereplyzy.com',
         'ericjohnson.ml',
+        'eripo.net',
         'ero-tube.org',
+        'esadverse.com',
         'esbano-ru.ru',
         'esc.la',
         'escapehatchapp.com',
@@ -1043,16 +1085,19 @@ class BlackListRule implements Rule
         'evopo.com',
         'evyush.com',
         'exdonuts.com',
+        'exelica.com',
         'existiert.net',
         'exitstageleft.net',
         'explodemail.com',
         'express.net.ua',
+        'extracurricularsociety.com',
         'extremail.ru',
         'eyepaste.com',
         'ez.lv',
         'ezehe.com',
         'ezfill.com',
         'ezstest.com',
+        'ezztt.com',
         'f4k.es',
         'f5.si',
         'facebook-email.cf',
@@ -1108,12 +1153,14 @@ class BlackListRule implements Rule
         'fbma.tk',
         'fddns.ml',
         'fdfdsfds.com',
+        'femailtor.com',
         'fer-gabon.org',
         'fermaxxi.ru',
         'fettometern.com',
         'fexbox.org',
         'fexbox.ru',
         'fexpost.com',
+        'fextemp.com',
         'ficken.de',
         'fictionsite.com',
         'fightallspam.com',
@@ -1127,6 +1174,7 @@ class BlackListRule implements Rule
         'filzmail.com',
         'findemail.info',
         'findu.pl',
+        'finews.biz',
         'fir.hk',
         'firemailbox.club',
         'fitnesrezink.ru',
@@ -1135,12 +1183,14 @@ class BlackListRule implements Rule
         'fizmail.com',
         'fleckens.hu',
         'flemail.ru',
+        'fliegender.fish',
         'flowu.com',
         'flu.cc',
         'fluidsoft.us',
         'flurred.com',
         'fly-ts.de',
         'flyinggeek.net',
+        'flymail.tk',
         'flyspam.com',
         'foobarbot.net',
         'footard.com',
@@ -1158,6 +1208,7 @@ class BlackListRule implements Rule
         'fosil.pro',
         'foxja.com',
         'foxtrotter.info',
+        'fr.cr',
         'fr.nf',
         'fr33mail.info',
         'fragolina2.tk',
@@ -1204,11 +1255,15 @@ class BlackListRule implements Rule
         'fuirio.com',
         'fukaru.com',
         'fukurou.ch',
+        'fullangle.org',
         'fulvie.com',
         'fun64.com',
         'funnycodesnippets.com',
         'funnymail.de',
         'furzauflunge.de',
+        'futuramind.com',
+        'fuwa.be',
+        'fuwa.li',
         'fuwamofu.com',
         'fuwari.be',
         'fux0ringduh.com',
@@ -1291,6 +1346,7 @@ class BlackListRule implements Rule
         'giveh2o.info',
         'givememail.club',
         'givmail.com',
+        'gixenmixen.com',
         'glitch.sx',
         'globaltouron.com',
         'glubex.com',
@@ -1304,6 +1360,7 @@ class BlackListRule implements Rule
         'gnctr-calgary.com',
         'go2usa.info',
         'go2vpn.net',
+        'goatmail.uk',
         'goemailgo.com',
         'golemico.com',
         'gomail.in',
@@ -1363,6 +1420,7 @@ class BlackListRule implements Rule
         'guerrillamail.net',
         'guerrillamail.org',
         'guerrillamailblock.com',
+        'gufum.com',
         'gustr.com',
         'gxemail.men',
         'gynzi.co.uk',
@@ -1389,6 +1447,7 @@ class BlackListRule implements Rule
         'haltospam.com',
         'hamham.uk',
         'hangxomcuatoilatotoro.ml',
+        'happy2023year.com',
         'happydomik.ru',
         'harakirimail.com',
         'haribu.com',
@@ -1467,6 +1526,7 @@ class BlackListRule implements Rule
         'huskion.net',
         'hvastudiesucces.nl',
         'hwsye.net',
+        'hypenated-domain.com',
         'i2pmail.org',
         'i6.cloudns.cc',
         'iaoss.com',
@@ -1476,6 +1536,7 @@ class BlackListRule implements Rule
         'ichigo.me',
         'icx.in',
         'icx.ro',
+        'icznn.com',
         'idx4.com',
         'idxue.com',
         'ieatspam.eu',
@@ -1498,9 +1559,12 @@ class BlackListRule implements Rule
         'imgof.com',
         'imgv.de',
         'immo-gerance.info',
+        'imperialcnk.com',
         'imstations.com',
         'imul.info',
         'in-ulm.de',
+        'in2reach.com',
+        'inactivemachine.com',
         'inbax.tk',
         'inbound.plus',
         'inbox.si',
@@ -1530,6 +1594,7 @@ class BlackListRule implements Rule
         'ineec.net',
         'infocom.zp.ua',
         'inggo.org',
+        'inkiny.com',
         'inkomail.com',
         'inmynetwork.tk',
         'inoutmail.de',
@@ -1540,12 +1605,16 @@ class BlackListRule implements Rule
         'insanumingeniumhomebrew.com',
         'insorg-mail.info',
         'instaddr.ch',
+        'instaddr.uk',
+        'instaddr.win',
         'instance-email.com',
         'instant-mail.de',
         'instantblingmail.info',
         'instantemailaddress.com',
         'instantmail.fr',
+        'instmail.uk',
         'internet-v-stavropole.ru',
+        'internetkeno.com',
         'internetoftags.com',
         'interstats.org',
         'intersteller.com',
@@ -1577,6 +1646,7 @@ class BlackListRule implements Rule
         'italy-mail.com',
         'itcompu.com',
         'itfast.net',
+        'itsjiff.com',
         'itunesgiftcodegenerator.com',
         'iubridge.com',
         'iuemail.men',
@@ -1585,6 +1655,7 @@ class BlackListRule implements Rule
         'ixx.io',
         'j-p.us',
         'jafps.com',
+        'jaga.email',
         'jajxz.com',
         'janproz.com',
         'jaqis.com',
@@ -1599,11 +1670,15 @@ class BlackListRule implements Rule
         'jetable.net',
         'jetable.org',
         'jetable.pp.ua',
+        'ji5.de',
+        'ji6.de',
+        'ji7.de',
         'jiooq.com',
         'jmail.ovh',
         'jmail.ro',
         'jnxjn.com',
         'jobbikszimpatizans.hu',
+        'jobbrett.com',
         'jobposts.net',
         'jobs-to-be-done.net',
         'joelpet.com',
@@ -1660,6 +1735,8 @@ class BlackListRule implements Rule
         'killmail.com',
         'killmail.net',
         'kimsdisk.com',
+        'kinda.email',
+        'kindamail.com',
         'kingsq.ga',
         'kino-100.ru',
         'kiois.com',
@@ -1668,16 +1745,20 @@ class BlackListRule implements Rule
         'kitnastar.com',
         'kjkszpjcompany.com',
         'kkmail.be',
+        'kkoup.com',
         'kksm.be',
         'klassmaster.com',
         'klassmaster.net',
         'klick-tipp.us',
         'klipschx12.com',
         'kloap.com',
+        'klovenode.com',
         'kludgemush.com',
         'klzlk.com',
         'kmail.li',
+        'kmail.live',
         'kmhow.com',
+        'knickerbockerban.de',
         'knol-power.nl',
         'kobrandly.com',
         'kommunity.biz',
@@ -1711,6 +1792,7 @@ class BlackListRule implements Rule
         'kwilco.net',
         'kyal.pl',
         'kyois.com',
+        'kzccv.com',
         'l-c-a.us',
         'l33r.eu',
         'l6factors.com',
@@ -1725,9 +1807,12 @@ class BlackListRule implements Rule
         'lak.pp.ua',
         'lakelivingstonrealestate.com',
         'lakqs.com',
+        'lamasticots.com',
+        'lambsauce.de',
         'landmail.co',
         'laoeq.com',
         'larisia.com',
+        'larland.com',
         'last-chance.pro',
         'lastmail.co',
         'lastmail.com',
@@ -1757,6 +1842,7 @@ class BlackListRule implements Rule
         'ligsb.com',
         'lillemap.net',
         'lilo.me',
+        'lilspam.com',
         'lindenbaumjapan.com',
         'link2mail.net',
         'linkedintuts2016.pw',
@@ -1802,6 +1888,8 @@ class BlackListRule implements Rule
         'lukop.dk',
         'luv2.us',
         'lyfestylecreditsolutions.com',
+        'lyft.live',
+        'lyricspad.net',
         'lzoaq.com',
         'm21.cc',
         'm4ilweb.info',
@@ -1847,6 +1935,7 @@ class BlackListRule implements Rule
         'mailapp.top',
         'mailback.com',
         'mailbidon.com',
+        'mailbiscuit.com',
         'mailbiz.biz',
         'mailblocks.com',
         'mailbox.in.ua',
@@ -1876,6 +1965,7 @@ class BlackListRule implements Rule
         'mailed.ro',
         'maileimer.de',
         'maileme101.com',
+        'mailers.edu.pl',
         'mailexpire.com',
         'mailf5.com',
         'mailfa.tk',
@@ -1943,6 +2033,7 @@ class BlackListRule implements Rule
         'mailonaut.com',
         'mailorc.com',
         'mailorg.org',
+        'mailosaur.net',
         'mailox.fun',
         'mailpick.biz',
         'mailpluss.com',
@@ -2006,18 +2097,22 @@ class BlackListRule implements Rule
         'mcache.net',
         'mciek.com',
         'mdhc.tk',
+        'mdz.email',
         'meantinc.com',
         'mebelnu.info',
         'mechanicalresumes.com',
         'medkabinet-uzi.ru',
         'meepsheep.eu',
+        'meidecn.com',
         'meinspamschutz.de',
         'meltedbrownies.com',
         'meltmail.com',
         'memsg.site',
         'mentonit.net',
         'mepost.pw',
+        'merepost.com',
         'merry.pink',
+        'meruado.uk',
         'messagebeamer.de',
         'messwiththebestdielikethe.rest',
         'metadownload.org',
@@ -2043,6 +2138,7 @@ class BlackListRule implements Rule
         'migumail.com',
         'mihep.com',
         'mijnhva.nl',
+        'minimail.gq',
         'ministry-of-silly-walks.de',
         'minsmail.com',
         'mintemail.com',
@@ -2054,6 +2150,7 @@ class BlackListRule implements Rule
         'mjukglass.nu',
         'mkpfilm.com',
         'ml8.ca',
+        'mliok.com',
         'mm.my',
         'mm5.se',
         'mnode.me',
@@ -2109,6 +2206,7 @@ class BlackListRule implements Rule
         'mucincanon.com',
         'muehlacker.tk',
         'muell.icu',
+        'muell.io',
         'muell.monster',
         'muell.xyz',
         'muellemail.com',
@@ -2128,16 +2226,19 @@ class BlackListRule implements Rule
         'mycleaninbox.net',
         'mycorneroftheinter.net',
         'myde.ml',
+        'mydefipet.live',
         'mydemo.equipment',
         'myecho.es',
         'myemailboxy.com',
         'mygeoweb.info',
         'myindohome.services',
+        'myinfoinc.com',
         'myinterserver.ml',
         'mykickassideas.com',
         'mymail-in.net',
         'mymail90.com',
         'mymailoasis.com',
+        'mymaily.lol',
         'mynetstore.de',
         'myopang.com',
         'mypacks.net',
@@ -2171,10 +2272,12 @@ class BlackListRule implements Rule
         'naslazhdai.ru',
         'nationalgardeningclub.com',
         'nawmin.info',
+        'naymedia.com',
         'nbzmr.com',
         'negated.com',
         'neko2.net',
         'nekochan.fr',
+        'nekosan.uk',
         'neomailbox.com',
         'neotlozhniy-zaim.ru',
         'nepwk.com',
@@ -2263,6 +2366,7 @@ class BlackListRule implements Rule
         'nwytg.com',
         'nwytg.net',
         'ny7.me',
+        'nyasan.com',
         'nypato.com',
         'nyrmusic.com',
         'o2stk.org',
@@ -2280,6 +2384,7 @@ class BlackListRule implements Rule
         'oepia.com',
         'oerpub.org',
         'offshore-proxies.net',
+        'ofisher.net',
         'ohaaa.de',
         'ohi.tw',
         'oida.icu',
@@ -2305,6 +2410,7 @@ class BlackListRule implements Rule
         'onlatedotcom.info',
         'online.ms',
         'onlineidea.info',
+        'onlyapp.net',
         'onqin.com',
         'ontyne.biz',
         'oohioo.com',
@@ -2330,6 +2436,7 @@ class BlackListRule implements Rule
         'ourklips.com',
         'ourpreviewdomain.com',
         'outlawspam.com',
+        'outlook.edu.pl',
         'outmail.win',
         'ovomail.co',
         'ovpn.to',
@@ -2337,6 +2444,7 @@ class BlackListRule implements Rule
         'owlpic.com',
         'ownsyou.de',
         'oxopoha.com',
+        'ozatvn.com',
         'ozyl.de',
         'p-banlis.ru',
         'p33.org',
@@ -2347,6 +2455,7 @@ class BlackListRule implements Rule
         'pagamenti.tk',
         'paharpurmim.ga',
         'pakadebu.ga',
+        'pamaweb.com',
         'pancakemail.com',
         'papierkorb.me',
         'paplease.com',
@@ -2384,6 +2493,8 @@ class BlackListRule implements Rule
         'pisls.com',
         'pitaniezdorovie.ru',
         'pivo-bar.ru',
+        'pixiil.com',
+        'pizzajunk.com',
         'pjjkp.com',
         'placebomail10.com',
         'pleasenoham.org',
@@ -2435,6 +2546,7 @@ class BlackListRule implements Rule
         'prin.be',
         'privacy.net',
         'privatdemail.net',
+        'privmail.edu.pl',
         'privy-mail.com',
         'privy-mail.de',
         'privymail.de',
@@ -2454,6 +2566,7 @@ class BlackListRule implements Rule
         'prtz.eu',
         'psh.me',
         'psles.com',
+        'psnator.com',
         'psoxs.com',
         'puglieisi.com',
         'puji.pro',
@@ -2464,11 +2577,13 @@ class BlackListRule implements Rule
         'put2.net',
         'puttanamaiala.tk',
         'putthisinyourspamdatabase.com',
+        'pwpwa.com',
         'pwrby.com',
         'qasti.com',
         'qbfree.us',
         'qc.to',
         'qibl.at',
+        'qiott.com',
         'qipmail.net',
         'qiq.us',
         'qisdo.com',
@@ -2485,6 +2600,7 @@ class BlackListRule implements Rule
         'quickinbox.com',
         'quickmail.nl',
         'quicksend.ch',
+        'quipas.com',
         'ququb.com',
         'qvy.me',
         'qwickmail.com',
@@ -2496,6 +2612,7 @@ class BlackListRule implements Rule
         'raetp9.com',
         'rainbowly.ml',
         'raketenmann.de',
+        'ramenmail.de',
         'rancidhome.net',
         'randomail.io',
         'randomail.net',
@@ -2512,6 +2629,7 @@ class BlackListRule implements Rule
         're-gister.com',
         'reality-concept.club',
         'reallymymail.com',
+        'realquickemail.com',
         'realtyalerts.ca',
         'rebates.stream',
         'receiveee.com',
@@ -2542,6 +2660,7 @@ class BlackListRule implements Rule
         'rippb.com',
         'risingsuntouch.com',
         'riski.cf',
+        'risu.be',
         'rklips.com',
         'rkomo.com',
         'rm2rf.com',
@@ -2578,6 +2697,7 @@ class BlackListRule implements Rule
         's33db0x.com',
         'sabrestlouis.com',
         'sackboii.com',
+        'saeoil.com',
         'safaat.cf',
         'safermail.info',
         'safersignup.de',
@@ -2630,10 +2750,13 @@ class BlackListRule implements Rule
         'sexforswingers.com',
         'sexical.com',
         'sexyalwasmi.top',
+        'sfolkar.com',
         'shadap.org',
         'shalar.net',
         'sharedmailbox.org',
+        'sharkfaces.com',
         'sharklasers.com',
+        'shchiba.uk',
         'sheryli.com',
         'shhmail.com',
         'shhuut.org',
@@ -2662,6 +2785,7 @@ class BlackListRule implements Rule
         'sify.com',
         'sika3.com',
         'sikux.com',
+        'silenceofthespam.com',
         'siliwangi.ga',
         'silvercoin.life',
         'sim-simka.ru',
@@ -2681,6 +2805,7 @@ class BlackListRule implements Rule
         'skrx.tk',
         'sky-inbox.com',
         'sky-ts.de',
+        'skygazerhub.com',
         'skyrt.de',
         'slapsfromlastnight.com',
         'slaskpost.se',
@@ -2698,6 +2823,7 @@ class BlackListRule implements Rule
         'smapfree24.eu',
         'smapfree24.info',
         'smapfree24.org',
+        'smartnator.com',
         'smarttalent.pw',
         'smashmail.de',
         'smellfear.com',
@@ -2705,12 +2831,14 @@ class BlackListRule implements Rule
         'smellypotato.tk',
         'smtp99.com',
         'smwg.info',
+        'snakebutt.com',
         'snakemail.com',
         'snapwet.com',
         'sneakmail.de',
         'snece.com',
         'social-mailer.tk',
         'socialfurry.org',
+        'sociallymediocre.com',
         'sofia.re',
         'sofimail.com',
         'sofort-mail.de',
@@ -2731,6 +2859,7 @@ class BlackListRule implements Rule
         'soodmail.com',
         'soodomail.com',
         'soodonims.com',
+        'soombo.com',
         'soon.it',
         'spacebazzar.ru',
         'spam-be-gone.com',
@@ -2763,6 +2892,7 @@ class BlackListRule implements Rule
         'spamday.com',
         'spamdecoy.net',
         'spamex.com',
+        'spamfellas.com',
         'spamfighter.cf',
         'spamfighter.ga',
         'spamfighter.gq',
@@ -2791,6 +2921,7 @@ class BlackListRule implements Rule
         'spamobox.com',
         'spamoff.de',
         'spamsalad.in',
+        'spamsandwich.com',
         'spamslicer.com',
         'spamsphere.com',
         'spamspot.com',
@@ -2810,11 +2941,13 @@ class BlackListRule implements Rule
         'spikio.com',
         'spindl-e.com',
         'spoofmail.de',
+        'sportrid.com',
         'spr.io',
         'spritzzone.de',
         'spruzme.com',
         'spybox.de',
         'spymail.com',
+        'spymail.one',
         'squizzy.de',
         'squizzy.net',
         'sroff.com',
@@ -2852,10 +2985,12 @@ class BlackListRule implements Rule
         'submic.com',
         'suburbanthug.com',
         'suckmyd.com',
+        'sudern.de',
         'sueshaw.com',
         'suexamplesb.com',
         'suioe.com',
         'super-auswahl.de',
+        'superblohey.com',
         'supergreatmail.com',
         'supermailer.jp',
         'superplatyna.com',
@@ -2872,6 +3007,7 @@ class BlackListRule implements Rule
         'sweetxxx.de',
         'swift-mail.net',
         'swift10minutemail.com',
+        'syinxun.com',
         'sylvannet.com',
         'symphonyresume.com',
         'syosetu.gq',
@@ -2891,6 +3027,8 @@ class BlackListRule implements Rule
         'tastrg.com',
         'taukah.com',
         'tb-on-line.net',
+        'tcwlm.com',
+        'tcwlx.com',
         'tdtda.com',
         'tech69.com',
         'techblast.ch',
@@ -2901,6 +3039,7 @@ class BlackListRule implements Rule
         'teewars.org',
         'tefl.ro',
         'telecomix.pl',
+        'teleg.eu',
         'teleworm.com',
         'teleworm.us',
         'tellos.xyz',
@@ -2965,6 +3104,7 @@ class BlackListRule implements Rule
         'thecloudindex.com',
         'thediamants.org',
         'thedirhq.info',
+        'theeyeoftruth.com',
         'thejoker5.com',
         'thelightningmail.net',
         'thelimestones.com',
@@ -2974,6 +3114,7 @@ class BlackListRule implements Rule
         'thereddoors.online',
         'theroyalweb.club',
         'thescrappermovie.com',
+        'thespamfather.com',
         'theteastory.info',
         'thex.ro',
         'thichanthit.com',
@@ -3010,9 +3151,13 @@ class BlackListRule implements Rule
         'tkitc.de',
         'tlpn.org',
         'tmail.com',
+        'tmail.io',
         'tmail.ws',
+        'tmail3.com',
+        'tmail9.com',
         'tmailinator.com',
         'tmails.net',
+        'tmmbt.net',
         'tmpbox.net',
         'tmpemails.com',
         'tmpeml.com',
@@ -3020,6 +3165,7 @@ class BlackListRule implements Rule
         'tmpjr.me',
         'tmpmail.net',
         'tmpmail.org',
+        'tmpx.sa.com',
         'toddsbighug.com',
         'tofeat.com',
         'toiea.com',
@@ -3049,6 +3195,7 @@ class BlackListRule implements Rule
         'totoan.info',
         'tourcc.com',
         'tp-qa-mail.com',
+        'tpwlb.com',
         'tqoai.com',
         'tqosi.com',
         'tradermail.info',
@@ -3097,6 +3244,7 @@ class BlackListRule implements Rule
         'trialmail.de',
         'trickmail.net',
         'trillianpro.com',
+        'triots.com',
         'trixtrux1.ru',
         'trollproject.com',
         'tropicalbass.info',
@@ -3112,6 +3260,7 @@ class BlackListRule implements Rule
         'turoid.com',
         'turual.com',
         'turuma.com',
+        'tutuapp.bid',
         'tvchd.com',
         'tverya.com',
         'twinmail.de',
@@ -3150,6 +3299,7 @@ class BlackListRule implements Rule
         'unit7lahaina.com',
         'unmail.ru',
         'uooos.com',
+        'uorak.com',
         'upliftnow.com',
         'uplipht.com',
         'uploadnolimit.com',
@@ -3268,6 +3418,7 @@ class BlackListRule implements Rule
         'watchever.biz',
         'watchfull.net',
         'watchironman3onlinefreefullmovie.com',
+        'waterisgone.com',
         'wazabi.club',
         'wbdev.tech',
         'wbml.net',
@@ -3307,6 +3458,7 @@ class BlackListRule implements Rule
         'wegwrfmail.de',
         'wegwrfmail.net',
         'wegwrfmail.org',
+        'weizixu.com',
         'wekawa.com',
         'welikecookies.com',
         'wellsfargocomcardholders.com',
@@ -3316,6 +3468,7 @@ class BlackListRule implements Rule
         'wfgdfhj.tk',
         'wg0.com',
         'wh4f.org',
+        'whaaaaaaaaaat.com',
         'whatiaas.com',
         'whatifanalytics.com',
         'whatpaas.com',
@@ -3327,6 +3480,7 @@ class BlackListRule implements Rule
         'wickmail.net',
         'widaryanto.info',
         'widget.gg',
+        'wiemei.com',
         'wierie.tk',
         'wifimaple.com',
         'wifioak.com',
@@ -3355,6 +3509,7 @@ class BlackListRule implements Rule
         'wudet.men',
         'wuespdj.xyz',
         'wupics.com',
+        'wuuvo.com',
         'wuzup.net',
         'wuzupmail.net',
         'wwjmp.com',
@@ -3387,6 +3542,9 @@ class BlackListRule implements Rule
         'xrap.de',
         'xrho.com',
         'xvx.us',
+        'xwaretech.com',
+        'xwaretech.info',
+        'xwaretech.net',
         'xww.ro',
         'xxhamsterxx.ga',
         'xxi2.com',
@@ -3463,6 +3621,7 @@ class BlackListRule implements Rule
         'zebins.eu',
         'zehnminuten.de',
         'zehnminutenmail.de',
+        'zemzar.net',
         'zepp.dk',
         'zetmail.com',
         'zfymail.com',
@@ -3473,6 +3632,7 @@ class BlackListRule implements Rule
         'zhorachu.com',
         'zik.dj',
         'zipcad.com',
+        'zipcatfish.com',
         'zipo1.gq',
         'zippymail.info',
         'zipsendtest.com',
@@ -3494,27 +3654,13 @@ class BlackListRule implements Rule
         'zzz.com',
     ];
 
-    /**
+    public function validate(string $attribute, mixed $value, Closure $fail): void
-     * @param string $attribute
-     * @param mixed $value
-     * @return bool
-     */
-    public function passes($attribute, $value): bool
     {
         $parts = explode("@", $value);
 
-        if (is_array($parts)) {
+        if (is_array($parts) && in_array($parts[1], $this->blacklist)) {
-            return ! in_array($parts[1], $this->blacklist);
+            $fail('This domain is blacklisted, if you think this is in error, please email contact@invoiceninja.com');
-        } else {
-            return true;
         }
     }
 
-    /**
-     * @return string
-     */
-    public function message(): string
-    {
-        return 'This domain is blacklisted, if you think this is in error, please email contact@invoiceninja.com';
-    }
 }

app/Http/ValidationRules/Account/EmailBlackListRule.php

@@ -11,32 +11,26 @@
 
 namespace App\Http\ValidationRules\Account;
 
-use Illuminate\Contracts\Validation\Rule;
+use Closure;
+use Illuminate\Contracts\Validation\ValidationRule;
 
 /**
  * Class EmailBlackListRule.
  */
-class EmailBlackListRule implements Rule
+class EmailBlackListRule implements ValidationRule
 {
     public array $blacklist = [
-
+        'noddy@invoiceninja.com',
     ];
 
-    /**
+
-     * @param string $attribute
+    public function validate(string $attribute, mixed $value, Closure $fail): void
-     * @param mixed $value
-     * @return bool
-     */
-    public function passes($attribute, $value)
     {
-        return ! in_array($value, $this->blacklist);
+
+        if (in_array($value, $this->blacklist)) {
+            $fail('This email address is blacklisted, if you think this is in error, please email contact@invoiceninja.com');
         }
 
-    /**
-     * @return string
-     */
-    public function message()
-    {
-        return 'This email address is blacklisted, if you think this is in error, please email contact@invoiceninja.com';
     }
+
 }

app/Jobs/Bank/ProcessBankTransactionsNordigen.php

@@ -35,7 +35,7 @@ class ProcessBankTransactionsNordigen implements ShouldQueue
     public Company $company;
     public Nordigen $nordigen;
     public $nordigen_account;
-
+    private bool $stop_loop = false;
     /**
      * Create a new job instance.
      */

app/Jobs/Bank/ProcessBankTransactionsYodlee.php

@@ -162,7 +162,7 @@ class ProcessBankTransactionsYodlee implements ShouldQueue
         $now = now();
 
         foreach ($transactions as $transaction) {
-            if (BankTransaction::query()->where('transaction_id', $transaction['transaction_id'])->where('company_id', $this->company->id)->where('bank_integration_id', $this->bank_integration->id)->withTrashed()->exists()) { // @turbo124 was not scoped to bank_integration_id => from my pov this should be present, because when an account was historized (is_deleted) a transaction can occur multiple (in the archived bank_integration and in the new one
+            if (BankTransaction::query()->where('transaction_id', $transaction['transaction_id'])->where('company_id', $this->company->id)->where('bank_integration_id', $this->bank_integration->id)->withTrashed()->exists()) { 
                 continue;
             }
 

app/Jobs/Ninja/BankTransactionSync.php

@@ -64,12 +64,12 @@ class BankTransactionSync implements ShouldQueue
 
     private function processYodlee()
     {
-        if (Ninja::isHosted()) { // @turbo124 @todo I migrated the schedule for the job within the kernel to execute on all platforms and use the same expression here to determine if yodlee can run or not. Please chek/verify
+        if (Ninja::isHosted()) {
             nlog("syncing transactions - yodlee");
 
             Account::with('bank_integrations')->whereNotNull('bank_integration_account_id')->cursor()->each(function ($account) {
 
-                if ($account->isPaid() && $account->plan == 'enterprise') {
+                if ($account->isEnterprisePaidClient()) {
                     $account->bank_integrations()->where('integration_type', BankIntegration::INTEGRATION_TYPE_YODLEE)->where('auto_sync', true)->cursor()->each(function ($bank_integration) use ($account) {
                         (new ProcessBankTransactionsYodlee($account->id, $bank_integration))->handle();
                     });
@@ -80,12 +80,12 @@ class BankTransactionSync implements ShouldQueue
     }
     private function processNordigen()
     {
-        if (config("ninja.nordigen.secret_id") && config("ninja.nordigen.secret_key")) { // @turbo124 check condition, when to execute this should be placed here (isSelfHosted || isPro/isEnterprise)
+        if (config("ninja.nordigen.secret_id") && config("ninja.nordigen.secret_key")) { 
             nlog("syncing transactions - nordigen");
 
             Account::with('bank_integrations')->cursor()->each(function ($account) {
 
-                if ((Ninja::isSelfHost() || (Ninja::isHosted() && $account->isPaid() && $account->plan == 'enterprise'))) {
+                if ((Ninja::isSelfHost() || (Ninja::isHosted() && $account->isEnterprisePaidClient()))) {
                     $account->bank_integrations()->where('integration_type', BankIntegration::INTEGRATION_TYPE_NORDIGEN)->where('auto_sync', true)->cursor()->each(function ($bank_integration) {
                         (new ProcessBankTransactionsNordigen($bank_integration))->handle();
                     });

app/Jobs/PostMark/ProcessPostmarkWebhook.php

@@ -30,6 +30,7 @@ use Illuminate\Foundation\Bus\Dispatchable;
 use App\DataMapper\Analytics\Mail\EmailSpam;
 use App\DataMapper\Analytics\Mail\EmailBounce;
 use App\Notifications\Ninja\EmailSpamNotification;
+use App\Notifications\Ninja\EmailBounceNotification;
 
 class ProcessPostmarkWebhook implements ShouldQueue
 {
@@ -103,6 +104,11 @@ class ProcessPostmarkWebhook implements ShouldQueue
             case 'Delivery':
                 return $this->processDelivery();
             case 'Bounce':
+
+                if($this->request['Subject'] == ctrans('texts.confirmation_subject')) {
+                    $company->notification(new EmailBounceNotification($this->request['Email']))->ninja();
+                }
+
                 return $this->processBounce();
             case 'SpamComplaint':
                 return $this->processSpamComplaint();
@@ -263,8 +269,6 @@ class ProcessPostmarkWebhook implements ShouldQueue
 
         (new SystemLogger($data, SystemLog::CATEGORY_MAIL, SystemLog::EVENT_MAIL_BOUNCED, SystemLog::TYPE_WEBHOOK_RESPONSE, $this->invitation->contact->client, $this->invitation->company))->handle();
 
-        // if(config('ninja.notification.slack'))
-        // $this->invitation->company->notification(new EmailBounceNotification($this->invitation->company->account))->ninja();
     }
 
     // {

app/Listeners/User/UpdateUserLastLogin.php

@@ -11,17 +11,19 @@
 
 namespace App\Listeners\User;
 
-use App\Jobs\Mail\NinjaMailerJob;
+use App\Utils\Ninja;
-use App\Jobs\Mail\NinjaMailerObject;
-use App\Jobs\Util\SystemLogger;
-use App\Libraries\MultiDB;
-use App\Mail\User\UserLoggedIn;
 use App\Models\SystemLog;
-use Illuminate\Broadcasting\InteractsWithSockets;
+use App\Libraries\MultiDB;
+use App\Jobs\Util\SystemLogger;
+use App\Mail\User\UserLoggedIn;
+use App\Jobs\Mail\NinjaMailerJob;
+use Illuminate\Support\Facades\App;
+use App\Jobs\Mail\NinjaMailerObject;
+use Illuminate\Support\Facades\Cache;
+use Illuminate\Queue\SerializesModels;
 use Illuminate\Contracts\Queue\ShouldQueue;
 use Illuminate\Foundation\Events\Dispatchable;
-use Illuminate\Queue\SerializesModels;
+use Illuminate\Broadcasting\InteractsWithSockets;
-use Illuminate\Support\Facades\Cache;
 
 class UpdateUserLastLogin implements ShouldQueue
 {
@@ -46,6 +48,11 @@ class UpdateUserLastLogin implements ShouldQueue
     {
         MultiDB::setDb($event->company->db);
 
+        App::forgetInstance('translator');
+        $t = app('translator');
+        $t->replace(Ninja::transformTranslations($event->company->settings));
+        App::setLocale($event->company->locale());
+        
         $user = $event->user;
         $user->last_login = now();
         $user->save();

app/Mail/Admin/VerifyUserObject.php

@@ -42,7 +42,6 @@ class VerifyUserObject
 
         if($this->is_react) {
             $react_redirect = '?react=true';
-            nlog("is react");
         }
 
         $data = [

app/Notifications/Ninja/EmailBounceNotification.php

@@ -21,11 +21,9 @@ class EmailBounceNotification extends Notification
      *
      * @return void
      */
-    protected $account;
 
-    public function __construct($account)
+    public function __construct(private string $email_address)
     {
-        $this->account = $account;
     }
 
     /**
@@ -64,11 +62,7 @@ class EmailBounceNotification extends Notification
 
     public function toSlack($notifiable)
     {
-        $content = "Email bounce notification for Account {$this->account->key} \n";
+        $content = "Email bounce notification for {$this->email_address} \n";
-
-        $owner = $this->account->companies()->first()->owner();
-
-        $content .= "Owner {$owner->present()->name() } | {$owner->email}";
 
         return (new SlackMessage)
                 ->success()

app/Transformers/BankIntegrationTransformer.php

@@ -68,6 +68,7 @@ class BankIntegrationTransformer extends EntityTransformer
             'created_at' => (int) $bank_integration->created_at,
             'updated_at' => (int) $bank_integration->updated_at,
             'archived_at' => (int) $bank_integration->deleted_at,
+            'integration_type' => (string) $bank_integration->integration_type ?: '',
         ];
     }
 

lang/en/texts.php

@@ -5227,23 +5227,23 @@ $lang = array(
     'primary_contact' => 'Primary Contact',
     'all_contacts' => 'All Contacts',
     'insert_below' => 'Insert Below',
-    'nordigen_handler_subtitle' => 'will gain access for your selected bank account. After selecting your institution you are redirected to theire front-page to complete the request with your account credentials.',
+    'nordigen_handler_subtitle' => 'Bank account authentication. Selecting your institution to complete the request with your account credentials.',
-    'nordigen_handler_error_heading_unknown' => 'An Error has occured',
+    'nordigen_handler_error_heading_unknown' => 'An error has occured',
-    'nordigen_handler_error_contents_unknown' => 'An unknown Error has occured! Reason:',
+    'nordigen_handler_error_contents_unknown' => 'An unknown error has occurred! Reason:',
     'nordigen_handler_error_heading_token_invalid' => 'Invalid Token',
-    'nordigen_handler_error_contents_token_invalid' => 'The provided token was invalid. Please restart the flow, with a valid one_time_token. Contact support for help, if this issue persists.',
+    'nordigen_handler_error_contents_token_invalid' => 'The provided token was invalid. Contact support for help, if this issue persists.',
     'nordigen_handler_error_heading_account_config_invalid' => 'Missing Credentials',
-    'nordigen_handler_error_contents_account_config_invalid' => 'The provided credentials for nordigen are eighter missing or invalid. Contact support for help, if this issue persists.',
+    'nordigen_handler_error_contents_account_config_invalid' => 'Invalid or missing credentials for Gocardless Bank Account Data. Contact support for help, if this issue persists.',
     'nordigen_handler_error_heading_not_available' => 'Not Available',
-    'nordigen_handler_error_contents_not_available' => 'This flow is not available for your account. Considder upgrading to enterprise version. Contact support for help, if this issue persists.',
+    'nordigen_handler_error_contents_not_available' => 'Feature unavailable, enterprise plan only.',
     'nordigen_handler_error_heading_institution_invalid' => 'Invalid Institution',
-    'nordigen_handler_error_contents_institution_invalid' => 'The provided institution-id is invalid or no longer valid. You can go to the bank selection page by clicking the button below or cancel the flow by clicking on the \'X\' above.',
+    'nordigen_handler_error_contents_institution_invalid' => 'The provided institution-id is invalid or no longer valid.',
     'nordigen_handler_error_heading_ref_invalid' => 'Invalid Reference',
-    'nordigen_handler_error_contents_ref_invalid' => 'Nordigen did not provide a valid reference. Please run flow again and contact support, if this issue persists.',
+    'nordigen_handler_error_contents_ref_invalid' => 'GoCardless did not provide a valid reference. Please run flow again and contact support, if this issue persists.',
     'nordigen_handler_error_heading_not_found' => 'Invalid Requisition',
-    'nordigen_handler_error_contents_not_found' => 'Nordigen did not provide a valid reference. Please run flow again and contact support, if this issue persists.',
+    'nordigen_handler_error_contents_not_found' => 'GoCardless did not provide a valid reference. Please run flow again and contact support, if this issue persists.',
     'nordigen_handler_error_heading_requisition_invalid_status' => 'Not Ready',
-    'nordigen_handler_error_contents_requisition_invalid_status' => 'You may called this site to early. Please finish authorization and refresh this page. Contact support for help, if this issue persists.',
+    'nordigen_handler_error_contents_requisition_invalid_status' => 'You called this site too early. Please finish authorization and refresh this page. Contact support for help, if this issue persists.',
     'nordigen_handler_error_heading_requisition_no_accounts' => 'No Accounts selected',
     'nordigen_handler_error_contents_requisition_no_accounts' => 'The service has not returned any valid accounts. Considder restarting the flow.',
     'nordigen_handler_restart' => 'Restart flow.',

lang/fr_CA/texts.php

@@ -3364,7 +3364,7 @@ Lorsque les montant apparaîtront sur votre relevé, veuillez revenir sur cette
     'credit_number_counter' => 'Compteur du numéro de crédit',
     'reset_counter_date' => 'Réinitialiser le compteur de date',
     'counter_padding' => 'Espacement du compteur',
-    'shared_invoice_quote_counter' => 'Share Invoice/Quote Counter',
+    'shared_invoice_quote_counter' => 'Partager le compteur des factures/soumissions',
     'default_tax_name_1' => 'Nom de taxe par défaut 1',
     'default_tax_rate_1' => 'Taux de taxe par défaut 1',
     'default_tax_name_2' => 'Nom de taxe par défaut 2',
@@ -5212,6 +5212,34 @@ Lorsque les montant apparaîtront sur votre relevé, veuillez revenir sur cette
     'receipt' => 'Reçu',
     'charges' => 'Charges',
     'email_report' => 'Envoyer le rapport',
+    'payment_type_Pay Later' => 'Payer plus tard',
+    'payment_type_credit' => 'Type de paiement crédit',
+    'payment_type_debit' => 'Type de paiement débit',
+    'send_emails_to' => 'Envoyer les courriels à',
+    'primary_contact' => 'Contact principal',
+    'all_contacts' => 'Tous les contacts',
+    'insert_below' => 'Insérer ci-dessous',
+    'nordigen_handler_subtitle' => 'will gain access for your selected bank account. After selecting your institution you are redirected to theire front-page to complete the request with your account credentials.',
+    'nordigen_handler_error_heading_unknown' => 'An Error has occured',
+    'nordigen_handler_error_contents_unknown' => 'An unknown Error has occured! Reason:',
+    'nordigen_handler_error_heading_token_invalid' => 'Invalid Token',
+    'nordigen_handler_error_contents_token_invalid' => 'The provided token was invalid. Please restart the flow, with a valid one_time_token. Contact support for help, if this issue persists.',
+    'nordigen_handler_error_heading_account_config_invalid' => 'Missing Credentials',
+    'nordigen_handler_error_contents_account_config_invalid' => 'The provided credentials for nordigen are eighter missing or invalid. Contact support for help, if this issue persists.',
+    'nordigen_handler_error_heading_not_available' => 'Not Available',
+    'nordigen_handler_error_contents_not_available' => 'This flow is not available for your account. Considder upgrading to enterprise version. Contact support for help, if this issue persists.',
+    'nordigen_handler_error_heading_institution_invalid' => 'Invalid Institution',
+    'nordigen_handler_error_contents_institution_invalid' => 'The provided institution-id is invalid or no longer valid. You can go to the bank selection page by clicking the button below or cancel the flow by clicking on the \'X\' above.',
+    'nordigen_handler_error_heading_ref_invalid' => 'Invalid Reference',
+    'nordigen_handler_error_contents_ref_invalid' => 'Nordigen did not provide a valid reference. Please run flow again and contact support, if this issue persists.',
+    'nordigen_handler_error_heading_not_found' => 'Invalid Requisition',
+    'nordigen_handler_error_contents_not_found' => 'Nordigen did not provide a valid reference. Please run flow again and contact support, if this issue persists.',
+    'nordigen_handler_error_heading_requisition_invalid_status' => 'Not Ready',
+    'nordigen_handler_error_contents_requisition_invalid_status' => 'You may called this site to early. Please finish authorization and refresh this page. Contact support for help, if this issue persists.',
+    'nordigen_handler_error_heading_requisition_no_accounts' => 'No Accounts selected',
+    'nordigen_handler_error_contents_requisition_no_accounts' => 'The service has not returned any valid accounts. Considder restarting the flow.',
+    'nordigen_handler_restart' => 'Restart flow.',
+    'nordigen_handler_return' => 'Return to application.',
 );
 
 return $lang;

tests/Unit/ValidationRules/BlacklistValidationTest.php

@@ -11,8 +11,9 @@
 
 namespace Tests\Unit\ValidationRules;
 
-use App\Http\ValidationRules\Account\BlackListRule;
 use Tests\TestCase;
+use App\Http\ValidationRules\Account\BlackListRule;
+use App\Http\ValidationRules\Account\EmailBlackListRule;
 
 /**
  * @test
@@ -25,6 +26,35 @@ class BlacklistValidationTest extends TestCase
         parent::setUp();
     }
 
+    public function testValidEmailRule3()
+    {
+        $rules = [
+            'email' => [new EmailBlackListRule],
+        ];
+
+        $data = [
+            'email' => 'contact@invoiceninja.com',
+        ];
+
+        $v = $this->app['validator']->make($data, $rules);
+        $this->assertTrue($v->passes());
+    }
+
+
+    public function testValidEmailRule2()
+    {
+        $rules = [
+            'email' => [new EmailBlackListRule],
+        ];
+
+        $data = [
+            'email' => 'noddy@invoiceninja.com',
+        ];
+
+        $v = $this->app['validator']->make($data, $rules);
+        $this->assertFalse($v->passes());
+    }
+
     public function testValidEmailRule()
     {
         $rules = [
@@ -52,4 +82,32 @@ class BlacklistValidationTest extends TestCase
         $v = $this->app['validator']->make($data, $rules);
         $this->assertFalse($v->passes());
     }
+
+    public function testInValidEmailRule2()
+    {
+        $rules = [
+            'email' => [new BlackListRule],
+        ];
+
+        $data = [
+            'email' => 'jimmy@zzz.com',
+        ];
+
+        $v = $this->app['validator']->make($data, $rules);
+        $this->assertFalse($v->passes());
+    }
+
+    public function testInValidEmailRule3()
+    {
+        $rules = [
+            'email' => [new BlackListRule],
+        ];
+
+        $data = [
+            'email' => 'jimmy@gmail.com',
+        ];
+
+        $v = $this->app['validator']->make($data, $rules);
+        $this->assertTrue($v->passes());
+    }
 }