From 58e720ef402b19d1f341fcd1ca8b6aaf4f77f407 Mon Sep 17 00:00:00 2001 From: Hillel Coren Date: Wed, 21 Jun 2017 13:52:59 +0300 Subject: [PATCH] Fix for negative line item taxes --- app/Ninja/Repositories/InvoiceRepository.php | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/app/Ninja/Repositories/InvoiceRepository.php b/app/Ninja/Repositories/InvoiceRepository.php index b72915c62097..f7a0cf80db2d 100644 --- a/app/Ninja/Repositories/InvoiceRepository.php +++ b/app/Ninja/Repositories/InvoiceRepository.php @@ -508,13 +508,13 @@ class InvoiceRepository extends BaseRepository } } - if (isset($item['tax_rate1']) && Utils::parseFloat($item['tax_rate1']) > 0) { - $invoiceItemTaxRate = Utils::parseFloat($item['tax_rate1']); - $itemTax += round($lineTotal * $invoiceItemTaxRate / 100, 2); + $taxRate1 = Utils::parseFloat($item['tax_rate1']); + if ($taxRate1 != 0) { + $itemTax += round($lineTotal * $taxRate1 / 100, 2); } - if (isset($item['tax_rate2']) && Utils::parseFloat($item['tax_rate2']) > 0) { - $invoiceItemTaxRate = Utils::parseFloat($item['tax_rate2']); - $itemTax += round($lineTotal * $invoiceItemTaxRate / 100, 2); + $taxRate2 = Utils::parseFloat($item['tax_rate2']); + if ($taxRate2 != 0) { + $itemTax += round($lineTotal * $taxRate2 / 100, 2); } }