From ba8759af6fb3e830cd5d0e49cbbb2b31457abdae Mon Sep 17 00:00:00 2001 From: David Bomba Date: Wed, 11 Aug 2021 09:16:35 +1000 Subject: [PATCH] minor fixes --- .../Controllers/SubscriptionController.php | 2 ++ .../Subscription/SubscriptionService.php | 23 +++++++++++++++++-- 2 files changed, 23 insertions(+), 2 deletions(-) diff --git a/app/Http/Controllers/SubscriptionController.php b/app/Http/Controllers/SubscriptionController.php index 051156343a96..0cf6233a9c21 100644 --- a/app/Http/Controllers/SubscriptionController.php +++ b/app/Http/Controllers/SubscriptionController.php @@ -354,6 +354,8 @@ class SubscriptionController extends BaseController event(new SubscriptionWasUpdated($subscription, $subscription->company, Ninja::eventVars(auth()->user() ? auth()->user()->id : null))); +nlog($subscription->id); + return $this->itemResponse($subscription); } diff --git a/app/Services/Subscription/SubscriptionService.php b/app/Services/Subscription/SubscriptionService.php index 0b70ce95557f..85dde2d02b01 100644 --- a/app/Services/Subscription/SubscriptionService.php +++ b/app/Services/Subscription/SubscriptionService.php @@ -777,7 +777,15 @@ class SubscriptionService */ public function products() { - return Product::whereIn('id', $this->transformKeys(explode(",", $this->subscription->product_ids)))->get(); + if(!$this->subscription->product_ids) + return collect(); + + $keys = $this->transformKeys(explode(",", $this->subscription->product_ids)); + + if(is_array($keys)) + return Product::whereIn('id', $keys)->get(); + else + return Product::where('id', $keys)->get(); } /** @@ -788,7 +796,18 @@ class SubscriptionService */ public function recurring_products() { - return Product::whereIn('id', $this->transformKeys(explode(",", $this->subscription->recurring_product_ids)))->get(); + if(!$this->subscription->recurring_product_ids) + return collect(); + + $keys = $this->transformKeys(explode(",", $this->subscription->recurring_product_ids)); + + if(is_array($keys)){ + return Product::whereIn('id', $keys)->get(); + } + else{ + return Product::where('id', $keys)->get(); + } + } /**