From 5b13f2d8ef8c7535f4d3878d139617cf0ff37bf1 Mon Sep 17 00:00:00 2001 From: Hillel Coren Date: Thu, 16 Jan 2014 21:12:46 +0000 Subject: [PATCH] bug fixes --- app/commands/SendRecurringInvoices.php | 1 - app/config/packages/zizaco/confide/config.php | 2 +- app/controllers/AccountController.php | 8 +- app/controllers/ActivityController.php | 2 +- app/controllers/ClientController.php | 1 + app/controllers/CreditController.php | 9 +- app/controllers/InvoiceController.php | 5 +- app/controllers/PaymentController.php | 25 ++- app/controllers/UserController.php | 2 +- ...11_05_180133_confide_setup_users_table.php | 11 +- app/lang/en/validation.php | 2 + app/models/Activity.php | 68 ++------ app/models/Client.php | 8 + app/models/Credit.php | 18 +++ app/models/User.php | 4 + app/ninja/repositories/CreditRepository.php | 5 +- app/ninja/repositories/InvoiceRepository.php | 1 - app/ninja/repositories/PaymentRepository.php | 48 +++++- app/routes.php | 16 +- app/views/clients/show.blade.php | 26 +++- app/views/credits/edit.blade.php | 15 +- app/views/emails/confirm_html.blade.php | 8 + app/views/header.blade.php | 4 +- app/views/invoices/edit.blade.php | 4 + public/js/script.js | 145 +++++++++--------- 25 files changed, 256 insertions(+), 182 deletions(-) create mode 100755 app/views/emails/confirm_html.blade.php diff --git a/app/commands/SendRecurringInvoices.php b/app/commands/SendRecurringInvoices.php index b0e452d646b9..1759f23127d5 100755 --- a/app/commands/SendRecurringInvoices.php +++ b/app/commands/SendRecurringInvoices.php @@ -44,7 +44,6 @@ class SendRecurringInvoices extends Command { $invoice->invoice_number = 'R' . $recurInvoice->account->getNextInvoiceNumber(); $invoice->amount = $recurInvoice->amount; $invoice->balance = $recurInvoice->amount; - $invoice->currency_id = $recurInvoice->currency_id; $invoice->invoice_date = date_create()->format('Y-m-d'); if ($invoice->client->payment_terms) diff --git a/app/config/packages/zizaco/confide/config.php b/app/config/packages/zizaco/confide/config.php index 76ea482697f2..28dd09117174 100755 --- a/app/config/packages/zizaco/confide/config.php +++ b/app/config/packages/zizaco/confide/config.php @@ -71,7 +71,7 @@ return array( */ 'email_reset_password' => 'confide::emails.passwordreset', // with $user and $token. - 'email_account_confirmation' => 'confide::emails.confirm', // with $user + 'email_account_confirmation' => 'emails.confirm_html', // with $user /* |-------------------------------------------------------------------------- diff --git a/app/controllers/AccountController.php b/app/controllers/AccountController.php index 74bebaf71b94..c19d66e3618e 100755 --- a/app/controllers/AccountController.php +++ b/app/controllers/AccountController.php @@ -44,9 +44,9 @@ class AccountController extends \BaseController { $random = str_random(RANDOM_KEY_LENGTH); $user = new User; - $user->username = $random; $user->password = $random; $user->password_confirmation = $random; + $user->username = $random; $account->users()->save($user); Session::forget(RECENTLY_VIEWED); @@ -486,7 +486,7 @@ class AccountController extends \BaseController { $user->username = trim(Input::get('email')); $user->email = trim(Input::get('email')); $user->phone = trim(Input::get('phone')); - $user->amend(); // need to 'amend' to avoid password validation rules + $user->save(); /* Logo image file */ if ($file = Input::file('logo')) @@ -520,7 +520,7 @@ class AccountController extends \BaseController { 'new_first_name' => 'required', 'new_last_name' => 'required', 'new_password' => 'required|min:6', - 'new_email' => 'email|required' + 'new_email' => 'email|required|unique:users,email,' . Auth::user()->id . ',id' ); $validator = Validator::make(Input::all(), $rules); @@ -537,7 +537,7 @@ class AccountController extends \BaseController { $user->password = trim(Input::get('new_password')); $user->password_confirmation = trim(Input::get('new_password')); $user->registered = true; - $user->save(); + $user->amend(); $activities = Activity::scope()->get(); foreach ($activities as $activity) diff --git a/app/controllers/ActivityController.php b/app/controllers/ActivityController.php index 11377ff5c181..0cad4e5ad730 100755 --- a/app/controllers/ActivityController.php +++ b/app/controllers/ActivityController.php @@ -8,7 +8,7 @@ class ActivityController extends \BaseController { ->join('clients', 'clients.id', '=', 'activities.client_id') ->where('clients.public_id', '=', $clientPublicId) ->where('activities.account_id', '=', Auth::user()->account_id) - ->select('activities.message', 'activities.created_at', 'activities.currency_id', 'activities.balance', 'activities.adjustment'); + ->select('activities.message', 'activities.created_at', 'clients.currency_id', 'activities.balance', 'activities.adjustment'); return Datatable::query($query) ->addColumn('created_at', function($model) { return Utils::timestampToDateTimeString(strtotime($model->created_at)); }) diff --git a/app/controllers/ClientController.php b/app/controllers/ClientController.php index 57effd9b04e0..03f5b8437374 100755 --- a/app/controllers/ClientController.php +++ b/app/controllers/ClientController.php @@ -104,6 +104,7 @@ class ClientController extends \BaseController { $data = array( 'client' => $client, + 'credit' => $client->getTotalCredit(), 'title' => '- ' . $client->getDisplayName(), 'hasRecurringInvoices' => Invoice::scope()->where('is_recurring', '=', true)->whereClientId($client->id)->count() > 0 ); diff --git a/app/controllers/CreditController.php b/app/controllers/CreditController.php index b51293c3f00b..e33d613b1cac 100755 --- a/app/controllers/CreditController.php +++ b/app/controllers/CreditController.php @@ -23,7 +23,7 @@ class CreditController extends \BaseController { return View::make('list', array( 'entityType'=>ENTITY_CREDIT, 'title' => '- Credits', - 'columns'=>['checkbox', 'Client', 'Credit Amount', 'Credit Date', 'Private Notes', 'Action'] + 'columns'=>['checkbox', 'Client', 'Credit Amount', 'Credit Balance', 'Credit Date', 'Private Notes', 'Action'] )); } @@ -40,6 +40,7 @@ class CreditController extends \BaseController { } return $table->addColumn('amount', function($model){ return Utils::formatMoney($model->amount, $model->currency_id); }) + ->addColumn('balance', function($model){ return Utils::formatMoney($model->balance, $model->currency_id); }) ->addColumn('credit_date', function($model) { return Utils::fromSqlDate($model->credit_date); }) ->addColumn('private_notes', function($model) { return $model->private_notes; }) ->addColumn('dropdown', function($model) @@ -58,17 +59,17 @@ class CreditController extends \BaseController { } - public function create($clientPublicId = 0, $invoicePublicId = 0) + public function create($clientPublicId = 0) { $data = array( 'clientPublicId' => Input::old('client') ? Input::old('client') : $clientPublicId, - 'invoicePublicId' => Input::old('invoice') ? Input::old('invoice') : $invoicePublicId, + //'invoicePublicId' => Input::old('invoice') ? Input::old('invoice') : $invoicePublicId, 'credit' => null, 'method' => 'POST', 'url' => 'credits', 'title' => '- New Credit', //'currencies' => Currency::remember(DEFAULT_QUERY_CACHE)->orderBy('name')->get(), - 'invoices' => Invoice::scope()->with('client', 'invoice_status')->orderBy('invoice_number')->get(), + //'invoices' => Invoice::scope()->with('client', 'invoice_status')->orderBy('invoice_number')->get(), 'clients' => Client::scope()->with('contacts')->orderBy('name')->get()); return View::make('credits.edit', $data); diff --git a/app/controllers/InvoiceController.php b/app/controllers/InvoiceController.php index 2645eab6a604..c74c075568c7 100755 --- a/app/controllers/InvoiceController.php +++ b/app/controllers/InvoiceController.php @@ -67,9 +67,7 @@ class InvoiceController extends \BaseController {