Cutlery/invoiceninja
1
0
Fork 0
mirror of https://github.com/invoiceninja/invoiceninja.git synced 2025-11-04 02:27:29 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #4158 from Striffly/features/browsershot-nodepaths

Browse Source 
Add ability to use Browsershot with NODE_PATH & NPM_PATH env variables
This commit is contained in:
David Bomba 2020-10-14 09:30:58 +11:00 committed by GitHub
commit 6256b197bf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 483 additions and 296 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/Http/Controllers/SetupController.php
View File

@ -192,6 +192,8 @@ class SetupController extends Controller
} }
Browsershot::html('PDF GENERATION WORKS! Thank you for using Invoice Ninja!') Browsershot::html('PDF GENERATION WORKS! Thank you for using Invoice Ninja!')
->setNodeBinary(config('ninja.system.node_path'))
->setNpmBinary(config('ninja.system.npm_path'))
->noSandbox() ->noSandbox()
->savePdf( ->savePdf(
public_path('test.pdf') public_path('test.pdf')

773
package-lock.json generated
View File

File diff suppressed because it is too large Load Diff

2
package.json
View File

@ -16,6 +16,7 @@
"@babel/plugin-proposal-class-properties": "^7.10.4", "@babel/plugin-proposal-class-properties": "^7.10.4",
"cypress": "^4.12.1", "cypress": "^4.12.1",
"laravel-mix-purgecss": "^5.0.0", "laravel-mix-purgecss": "^5.0.0",
"puppeteer": "^5.3.1",
"vue-template-compiler": "^2.6.11" "vue-template-compiler": "^2.6.11"
}, },
"dependencies": { "dependencies": {
@ -27,7 +28,6 @@
"jsignature": "^2.1.3", "jsignature": "^2.1.3",
"laravel-mix": "^5.0.7", "laravel-mix": "^5.0.7",
"lodash": "^4.17.20", "lodash": "^4.17.20",
"puppeteer": "^1.20.0",
"resolve-url-loader": "^3.1.0", "resolve-url-loader": "^3.1.0",
"sass": "^1.26.10", "sass": "^1.26.10",
"sass-loader": "^8.0.0", "sass-loader": "^8.0.0",

2
tests/Pdf/PdfGenerationTest.php
View File

@ -28,6 +28,8 @@ class PdfGenerationTest extends TestCase
private function makePdf($header, $footer, $html, $pdf) private function makePdf($header, $footer, $html, $pdf)
{ {
Browsershot::html($html) Browsershot::html($html)
->setNodeBinary(config('ninja.system.node_path'))
->setNpmBinary(config('ninja.system.npm_path'))
//->showBrowserHeaderAndFooter() //->showBrowserHeaderAndFooter()
//->headerHtml($header) //->headerHtml($header)
//->footerHtml($footer) //->footerHtml($footer)