From 644965e1c8d67d1ae4b98bbfed00915709550892 Mon Sep 17 00:00:00 2001
From: David Bomba <turbo124@gmail.com>
Date: Tue, 14 May 2024 15:13:49 +1000
Subject: [PATCH] improve twig filters

---
 app/Services/Template/TemplateMock.php    |  3 ---
 app/Services/Template/TemplateService.php | 29 ++++++++++++++++++-----
 2 files changed, 23 insertions(+), 9 deletions(-)

diff --git a/app/Services/Template/TemplateMock.php b/app/Services/Template/TemplateMock.php
index 572b64e7e7a0..7bf3b9fd7fdc 100644
--- a/app/Services/Template/TemplateMock.php
+++ b/app/Services/Template/TemplateMock.php
@@ -56,9 +56,6 @@ class TemplateMock
         $this->engines['payments'] = json_decode($this->payment_data, true);
         $this->engines['purchase_orders'] = json_decode($this->purchase_order_data, true);
 
-        // nlog("engines");
-        // nlog($this->engines);
-
         return $this;
 
     }
diff --git a/app/Services/Template/TemplateService.php b/app/Services/Template/TemplateService.php
index 2d55d8ad9689..429a565cab69 100644
--- a/app/Services/Template/TemplateService.php
+++ b/app/Services/Template/TemplateService.php
@@ -94,6 +94,7 @@ class TemplateService
         $this->twig = new \Twig\Environment($loader, [
                 'debug' => true,
         ]);
+        
         $string_extension = new \Twig\Extension\StringLoaderExtension();
         $this->twig->addExtension($string_extension);
         $this->twig->addExtension(new IntlExtension());
@@ -121,6 +122,26 @@ class TemplateService
 
         $this->twig->addFilter($filter);
 
+        $filter = new \Twig\TwigFilter('filter', function ($array, $arrow){
+
+            if(is_string($arrow) && in_array($arrow, ['popen','exec','shell_exec','system','passthru','proc_open','pcntl_exec','sleep','escapeshellcmd','escapeshellarg']))
+                throw new RuntimeError("Attempt to access command line");
+
+            if (!is_iterable($array)) {
+                throw new RuntimeError(sprintf('The "filter" filter expects an array or "Traversable", got "%s".', \is_object($array) ? \get_class($array) : \gettype($array)));
+            }
+
+            if (\is_array($array)) {
+                return array_filter($array, $arrow, \ARRAY_FILTER_USE_BOTH);
+            }
+
+            // the IteratorIterator wrapping is needed as some internal PHP classes are \Traversable but do not implement \Iterator
+            return new \CallbackFilterIterator(new \IteratorIterator($array), $arrow);
+
+        });
+
+        $this->twig->addFilter($filter);
+
         return $this;
     }
 
@@ -240,7 +261,7 @@ class TemplateService
      */
     public function getPdf(): string
     {
-
+        
         if (config('ninja.invoiceninja_hosted_pdf_generation') || config('ninja.pdf_generator') == 'hosted_ninja') {
             $pdf = (new NinjaPdf())->build($this->compiled_html);
         } else {
@@ -271,7 +292,7 @@ class TemplateService
     {
 
         $this->data = $this->preProcessDataBlocks($data);
-        // nlog(json_encode($this->data));
+
         return $this;
     }
 
@@ -1211,12 +1232,8 @@ class TemplateService
                 });
             })->toArray();
 
-        // nlog($company_details);
-
         $company_details = $include_labels ? $this->labelledFieldStack($company_details, 'company_details-') : $company_details;
 
-        // nlog($company_details);
-
         $this->updateElementProperties('company-details', $company_details);
 
         return $this;