Cutlery/invoiceninja
1
0
Fork 0
mirror of https://github.com/invoiceninja/invoiceninja.git synced 2025-07-09 03:14:30 -04:00
Code Issues Packages Projects Releases Wiki Activity

Table locking for public_id integrity

Browse Source
This commit is contained in:
David Bomba 2016-02-10 11:26:21 +11:00
parent 04807bccc6
commit 67b74b2a34
2 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
app/Models/EntityModel.php
View File

@ -27,6 +27,7 @@ class EntityModel extends Eloquent
$lastEntity = $className::withTrashed() $lastEntity = $className::withTrashed()
->scope(false, $entity->account_id) ->scope(false, $entity->account_id)
->orderBy('public_id', 'DESC') ->orderBy('public_id', 'DESC')
->lockForUpdate()
->first(); ->first();
if ($lastEntity) { if ($lastEntity) {

5
app/Ninja/Repositories/ClientRepository.php
View File

@ -66,6 +66,8 @@ class ClientRepository extends BaseRepository
{ {
$publicId = isset($data['public_id']) ? $data['public_id'] : false; $publicId = isset($data['public_id']) ? $data['public_id'] : false;
DB::beginTransaction();
if (!$publicId || $publicId == '-1') { if (!$publicId || $publicId == '-1') {
$client = Client::createNew(); $client = Client::createNew();
} else { } else {
@ -75,6 +77,9 @@ class ClientRepository extends BaseRepository
$client->fill($data); $client->fill($data);
$client->save(); $client->save();
DB::commit();
/* /*
if ( ! isset($data['contact']) && ! isset($data['contacts'])) { if ( ! isset($data['contact']) && ! isset($data['contacts'])) {
return $client; return $client;