diff --git a/app/Filters/RecurringInvoiceFilters.php b/app/Filters/RecurringInvoiceFilters.php index 81060eed6123..8c3bb10936fc 100644 --- a/app/Filters/RecurringInvoiceFilters.php +++ b/app/Filters/RecurringInvoiceFilters.php @@ -114,20 +114,25 @@ class RecurringInvoiceFilters extends QueryFilters */ public function sort(string $sort = ''): Builder { - $sort_col = explode('|', $sort); + $sort_col = explode('|', $sort); + if (!is_array($sort_col) || count($sort_col) != 2) { return $this->builder; } + $dir = ($sort_col[1] == 'asc') ? 'asc' : 'desc'; if ($sort_col[0] == 'client_id') { return $this->builder->orderBy(\App\Models\Client::select('name') - ->whereColumn('clients.id', 'recurring_invoices.client_id'), $sort_col[1]); + ->whereColumn('clients.id', 'recurring_invoices.client_id'), $dir); } + if($sort_col[0] == 'number'){ + return $this->builder->orderByRaw("ABS(number) {$dir}"); + } - return $this->builder->orderBy($sort_col[0], $sort_col[1]); + return $this->builder->orderBy($sort_col[0], $dir); } /**