From 6c32d905aead68e69e530d5db5742865d91f9f99 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Benjamin=20Beganovi=C4=87?= <k1pstabug@gmail.com>
Date: Tue, 24 Aug 2021 16:13:52 +0200
Subject: [PATCH] Extract totals table for statements into separate methods

---
 app/Services/PdfMaker/Design.php       | 30 ++++++++++++++++++++------
 resources/views/pdf-designs/plain.html |  7 +++++-
 2 files changed, 30 insertions(+), 7 deletions(-)

diff --git a/app/Services/PdfMaker/Design.php b/app/Services/PdfMaker/Design.php
index db1551da2f85..88ee420bf970 100644
--- a/app/Services/PdfMaker/Design.php
+++ b/app/Services/PdfMaker/Design.php
@@ -135,9 +135,7 @@ class Design extends BaseDesign
             ],
             'statement-invoice-table-totals' => [
                 'id' => 'statement-invoice-table-totals',
-                'elements' => [
-                    ['element' => 'p', 'content' => '$outstanding_label: $outstanding'],
-                ],
+                'elements' => $this->statementInvoiceTableTotals(),
             ],
             'statement-payment-table' => [
                 'id' => 'statement-payment-table',
@@ -145,9 +143,7 @@ class Design extends BaseDesign
             ],
             'statement-payment-table-totals' => [
                 'id' => 'statement-payment-table-totals',
-                'elements' => [
-                    ['element' => 'p', 'content' => \sprintf('%s: %s', ctrans('texts.amount_paid'), 1000)],
-                ],
+                'elements' => $this->statementPaymentTableTotals(),
             ],
             'statement-aging-table' => [
                 'id' => 'statement-aging-table',
@@ -377,6 +373,17 @@ class Design extends BaseDesign
         ];
     }
 
+    public function statementInvoiceTableTotals(): array
+    {
+        if ($this->type !== self::STATEMENT) {
+            return [];
+        }
+
+        return [
+            ['element' => 'p', 'content' => '$outstanding_label: $outstanding'],
+        ];
+    }
+
     /**
      * Parent method for building payments table within statement.
      *
@@ -413,6 +420,17 @@ class Design extends BaseDesign
         ];
     }
 
+    public function statementPaymentTableTotals(): array
+    {
+        if ($this->type !== self::STATEMENT) {
+            return [];
+        }
+
+        return [
+            ['element' => 'p', 'content' => \sprintf('%s: %s', ctrans('texts.amount_paid'), 1000)],
+        ];
+    }
+
     public function statementAgingTable(): array
     {
         if ($this->type !== self::STATEMENT) {
diff --git a/resources/views/pdf-designs/plain.html b/resources/views/pdf-designs/plain.html
index ab2487d66997..7026d615fbea 100644
--- a/resources/views/pdf-designs/plain.html
+++ b/resources/views/pdf-designs/plain.html
@@ -297,7 +297,12 @@
     <script>
         // Clear up space a bit, if [product-table, tasks-table, delivery-note-table] isn't present.
         document.addEventListener('DOMContentLoaded', () => {
-            ['product-table', 'task-table', 'delivery-note-table'].forEach((tableIdentifier) => {
+            let tables = [
+                'product-table', 'task-table', 'delivery-note-table',
+                'statement-invoice-table', 'statement-payment-table', 'statement-aging-table-totals',
+            ];
+
+            tables.forEach((tableIdentifier) => {
                 document.getElementById(tableIdentifier).childElementCount === 0
                     ? document.getElementById(tableIdentifier).style.display = 'none'
                     : '';