diff --git a/app/Http/Controllers/ReportController.php b/app/Http/Controllers/ReportController.php index aa169b3e58cd..02c87ca5dcd0 100644 --- a/app/Http/Controllers/ReportController.php +++ b/app/Http/Controllers/ReportController.php @@ -62,8 +62,8 @@ class ReportController extends BaseController $dateField = Input::get('date_field'); $startDate = Utils::toSqlDate(Input::get('start_date'), false); $endDate = Utils::toSqlDate(Input::get('end_date'), false); - $enableReport = Input::get('enable_report') ? true : false; - $enableChart = Input::get('enable_chart') ? true : false; + $enableReport = boolval(Input::get('enable_report')); + $enableChart = boolval(Input::get('enable_chart')); } else { $groupBy = 'MONTH'; $chartType = 'Bar'; diff --git a/resources/views/reports/chart_builder.blade.php b/resources/views/reports/chart_builder.blade.php index 7507b0e4ca79..e2c765b69468 100644 --- a/resources/views/reports/chart_builder.blade.php +++ b/resources/views/reports/chart_builder.blade.php @@ -3,7 +3,7 @@ @section('head') @parent - + @stop @section('content') @@ -11,7 +11,7 @@ @include('accounts.nav', ['selected' => ACCOUNT_CHARTS_AND_REPORTS, 'advanced' => true]) - {!! Former::open()->rules(['start_date' => 'required', 'end_date' => 'required'])->addClass('warn-on-exit') !!} + {!! Former::open()->rules(['start_date' => 'required', 'end_date' => 'required'])->addClass('warn-on-exit') !!}
{!! Former::text('action') !!} @@ -19,16 +19,14 @@ {!! Former::populateField('start_date', $startDate) !!} {!! Former::populateField('end_date', $endDate) !!} - {!! Former::populateField('enable_report', intval($enableReport)) !!} - {!! Former::populateField('enable_chart', intval($enableChart)) !!}

{!! trans('texts.report_settings') !!}

-
-
+
+
@@ -40,23 +38,23 @@ ->append('') !!}

 

- {!! Former::actions( + {!! Former::actions( Button::primary(trans('texts.export'))->withAttributes(array('onclick' => 'onExportClick()'))->appendIcon(Icon::create('export')), Button::success(trans('texts.run'))->withAttributes(array('id' => 'submitButton'))->submit()->appendIcon(Icon::create('play')) ) !!} @if (!Auth::user()->hasFeature(FEATURE_REPORTS)) + @endif
- {!! Former::checkbox('enable_report')->text(trans('texts.enable')) !!} + {!! Former::checkbox('enable_report')->text(trans('texts.enable'))->check($enableReport)->forceValue(1) !!} {!! Former::select('report_type')->options($reportTypes, $reportType)->label(trans('texts.type')) !!}
{!! Former::select('date_field')->label(trans('texts.filter')) @@ -64,11 +62,11 @@ ->addOption(trans('texts.payment_date'), FILTER_PAYMENT_DATE) !!}

 

- {!! Former::checkbox('enable_chart')->text(trans('texts.enable')) !!} + {!! Former::checkbox('enable_chart')->text(trans('texts.enable'))->check($enableChart)->forceValue(1) !!} {!! Former::select('group_by')->options($dateTypes, $groupBy) !!} {!! Former::select('chart_type')->options($chartTypes, $chartType) !!} - + {!! Former::close() !!}
@@ -79,9 +77,9 @@
- + - @foreach ($columns as $column) + @foreach ($columns as $column) @endforeach @@ -140,7 +138,7 @@
 Invoices
-
+
 Payments
@@ -161,7 +159,7 @@ function onExportClick() { $('#action').val('export'); $('#submitButton').click(); - $('#action').val(''); + $('#action').val(''); } @if ($enableChart) @@ -179,7 +177,7 @@ ] } - var options = { + var options = { scaleOverride: true, scaleSteps: 10, scaleStepWidth: {!! $scaleStepWidth !!}, @@ -222,4 +220,4 @@ keyboardNavigation: false }); -@stop \ No newline at end of file +@stop
{{ trans("texts.{$column}") }}