From 72bbcf2bb2f5e5b06470d2cc096775e7e941c26f Mon Sep 17 00:00:00 2001 From: = Date: Sun, 5 Sep 2021 20:31:08 +1000 Subject: [PATCH] Prevent duplicate events firing on save --- app/Console/Commands/HostedMigrations.php | 2 +- app/Console/Commands/ImportMigrations.php | 2 +- app/Jobs/Util/WebhookHandler.php | 2 +- app/Observers/InvoiceObserver.php | 2 +- app/Repositories/BaseRepository.php | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/app/Console/Commands/HostedMigrations.php b/app/Console/Commands/HostedMigrations.php index c10b0291e3cc..a672a9e1ed68 100644 --- a/app/Console/Commands/HostedMigrations.php +++ b/app/Console/Commands/HostedMigrations.php @@ -44,7 +44,7 @@ class HostedMigrations extends Command * * @var string */ - protected $signature = 'migrations:hosted-import {--email=}'; + protected $signature = 'ninja:import {--email=}'; /** * The console command description. diff --git a/app/Console/Commands/ImportMigrations.php b/app/Console/Commands/ImportMigrations.php index 716b26a929ab..a589634203ab 100644 --- a/app/Console/Commands/ImportMigrations.php +++ b/app/Console/Commands/ImportMigrations.php @@ -43,7 +43,7 @@ class ImportMigrations extends Command * * @var string */ - protected $signature = 'migrations:import {--path=}'; + protected $signature = 'ninja:old-import {--path=}'; /** * The console command description. diff --git a/app/Jobs/Util/WebhookHandler.php b/app/Jobs/Util/WebhookHandler.php index fc656ff8eb92..222ad861b8d5 100644 --- a/app/Jobs/Util/WebhookHandler.php +++ b/app/Jobs/Util/WebhookHandler.php @@ -36,7 +36,7 @@ class WebhookHandler implements ShouldQueue private $company; - public $tries = 1; //number of retries + public $tries = 3; //number of retries public $backoff = 10; //seconds to wait until retry diff --git a/app/Observers/InvoiceObserver.php b/app/Observers/InvoiceObserver.php index 606d37c50a80..869a0310364e 100644 --- a/app/Observers/InvoiceObserver.php +++ b/app/Observers/InvoiceObserver.php @@ -46,7 +46,7 @@ class InvoiceObserver * @return void */ public function updated(Invoice $invoice) - { + {nlog("updated"); $subscriptions = Webhook::where('company_id', $invoice->company->id) ->where('event_id', Webhook::EVENT_UPDATE_INVOICE) ->exists(); diff --git a/app/Repositories/BaseRepository.php b/app/Repositories/BaseRepository.php index 783f79cc94f4..fae747d85452 100644 --- a/app/Repositories/BaseRepository.php +++ b/app/Repositories/BaseRepository.php @@ -209,7 +209,7 @@ class BaseRepository $model->custom_surcharge_tax3 = $client->company->custom_surcharge_taxes3; $model->custom_surcharge_tax4 = $client->company->custom_surcharge_taxes4; - $model->save(); + $model->saveQuietly(); /* Model now persisted, now lets do some child tasks */