From 7c4d0a2af582301b2c081a019b14cfb8af9eb305 Mon Sep 17 00:00:00 2001 From: Hillel Coren Date: Tue, 6 Dec 2016 12:04:30 +0200 Subject: [PATCH] Label credits created by deleting payments --- app/Listeners/CreditListener.php | 22 +--------------------- app/Providers/EventServiceProvider.php | 1 - resources/lang/en/texts.php | 1 + 3 files changed, 2 insertions(+), 22 deletions(-) diff --git a/app/Listeners/CreditListener.php b/app/Listeners/CreditListener.php index c8d16a4776c2..2ad809cd24d7 100644 --- a/app/Listeners/CreditListener.php +++ b/app/Listeners/CreditListener.php @@ -41,27 +41,7 @@ class CreditListener $credit->client_id = $payment->client_id; $credit->credit_date = Carbon::now()->toDateTimeString(); $credit->balance = $credit->amount = $payment->getCompletedAmount(); - $credit->private_notes = $payment->transaction_reference; - $credit->save(); - } - - /** - * @param PaymentWasRefunded $event - */ - public function refundedPayment(PaymentWasRefunded $event) - { - $payment = $event->payment; - - // if the payment was from a credit we need to refund the credit - if ($payment->payment_type_id != PAYMENT_TYPE_CREDIT) { - return; - } - - $credit = Credit::createNew(); - $credit->client_id = $payment->client_id; - $credit->credit_date = Carbon::now()->toDateTimeString(); - $credit->balance = $credit->amount = $event->refundAmount; - $credit->private_notes = $payment->transaction_reference; + $credit->private_notes = trans('texts.refunded_credit_payment'); $credit->save(); } } diff --git a/app/Providers/EventServiceProvider.php b/app/Providers/EventServiceProvider.php index 0561a1a1f629..5d0be86d36bc 100644 --- a/app/Providers/EventServiceProvider.php +++ b/app/Providers/EventServiceProvider.php @@ -112,7 +112,6 @@ class EventServiceProvider extends ServiceProvider { 'App\Events\PaymentWasRefunded' => [ 'App\Listeners\ActivityListener@refundedPayment', 'App\Listeners\InvoiceListener@refundedPayment', - 'App\Listeners\CreditListener@refundedPayment', ], 'App\Events\PaymentWasVoided' => [ 'App\Listeners\ActivityListener@voidedPayment', diff --git a/resources/lang/en/texts.php b/resources/lang/en/texts.php index 84a37d423224..29ffab3e8620 100644 --- a/resources/lang/en/texts.php +++ b/resources/lang/en/texts.php @@ -2258,6 +2258,7 @@ $LANG = array( 'redirect_url' => 'Redirect URL', 'redirect_url_help' => 'Optionally specify a URL to redirect to after a payment is made entered.', 'save_draft' => 'Save Draft', + 'refunded_credit_payment' => 'Refunded credit payment', );