From e2ed2fa2b242337babdd9ac7dca00c8f52f1dde2 Mon Sep 17 00:00:00 2001 From: David Bomba Date: Thu, 6 Jul 2023 21:16:18 +1000 Subject: [PATCH 1/2] Fixes for plain text emails --- app/Http/Controllers/EmailController.php | 2 -- app/Services/Email/EmailDefaults.php | 10 ++++++++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/app/Http/Controllers/EmailController.php b/app/Http/Controllers/EmailController.php index b7e692d3726d..0939a79a294c 100644 --- a/app/Http/Controllers/EmailController.php +++ b/app/Http/Controllers/EmailController.php @@ -14,7 +14,6 @@ namespace App\Http\Controllers; use App\Events\Credit\CreditWasEmailed; use App\Events\Quote\QuoteWasEmailed; use App\Http\Requests\Email\SendEmailRequest; -use App\Jobs\Entity\EmailEntity; use App\Jobs\PurchaseOrder\PurchaseOrderEmail; use App\Models\Credit; use App\Models\Invoice; @@ -30,7 +29,6 @@ use App\Transformers\QuoteTransformer; use App\Transformers\RecurringInvoiceTransformer; use App\Utils\Ninja; use App\Utils\Traits\MakesHash; -use Illuminate\Http\Response; use Illuminate\Mail\Mailables\Address; class EmailController extends BaseController diff --git a/app/Services/Email/EmailDefaults.php b/app/Services/Email/EmailDefaults.php index 071541ad9dda..65a104b88fdc 100644 --- a/app/Services/Email/EmailDefaults.php +++ b/app/Services/Email/EmailDefaults.php @@ -180,8 +180,11 @@ class EmailDefaults $this->email->email_object->body = EmailTemplateDefaults::getDefaultTemplate($this->email->email_object->email_template_body, $this->locale); } - $this->email->email_object->text_body = strip_tags($this->email->email_object->body); - + $breaks = ["
","
","
"]; + $this->email->email_object->text_body = str_ireplace($breaks, "\r\n", $this->email->email_object->body); + $this->email->email_object->text_body = strip_tags($this->email->email_object->text_body); + $this->email->email_object->text_body = str_replace('$view_button', '$view_url', $this->email->email_object->text_body); + if ($this->template == 'email.template.custom') { $this->email->email_object->body = (str_replace('$body', $this->email->email_object->body, str_replace(["\r","\n"], "", $this->email->email_object->settings->email_style_custom))); } @@ -226,7 +229,10 @@ class EmailDefaults */ public function setVariables(): self { + $this->email->email_object->body = strtr($this->email->email_object->body, $this->email->email_object->variables); + + $this->email->email_object->text_body = strtr($this->email->email_object->text_body, $this->email->email_object->variables); $this->email->email_object->subject = strtr($this->email->email_object->subject, $this->email->email_object->variables); From 3fef3a9da54fbf9483809c75aaaa7e61e3477a68 Mon Sep 17 00:00:00 2001 From: David Bomba Date: Thu, 6 Jul 2023 21:16:45 +1000 Subject: [PATCH 2/2] v5.6.12 --- VERSION.txt | 2 +- config/ninja.php | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/VERSION.txt b/VERSION.txt index 92989cf398d6..60837570b607 100644 --- a/VERSION.txt +++ b/VERSION.txt @@ -1 +1 @@ -5.6.11 \ No newline at end of file +5.6.12 \ No newline at end of file diff --git a/config/ninja.php b/config/ninja.php index b5f085716678..2a6dfaa4c16e 100644 --- a/config/ninja.php +++ b/config/ninja.php @@ -15,8 +15,8 @@ return [ 'require_https' => env('REQUIRE_HTTPS', true), 'app_url' => rtrim(env('APP_URL', ''), '/'), 'app_domain' => env('APP_DOMAIN', 'invoicing.co'), - 'app_version' => '5.6.11', - 'app_tag' => '5.6.11', + 'app_version' => '5.6.12', + 'app_tag' => '5.6.12', 'minimum_client_version' => '5.0.16', 'terms_version' => '1.0.1', 'api_secret' => env('API_SECRET', ''),