From 8da6911e0e72e1abf9d7312ec9bc2f34c515f730 Mon Sep 17 00:00:00 2001
From: Lars Kusch <lars@lars-kusch.de>
Date: Tue, 14 Mar 2023 21:41:43 +0100
Subject: [PATCH] Simplified switch statement

---
 app/Jobs/Invoice/CreateXInvoice.php | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/app/Jobs/Invoice/CreateXInvoice.php b/app/Jobs/Invoice/CreateXInvoice.php
index a65e8272d642..d0d61fe5cd41 100644
--- a/app/Jobs/Invoice/CreateXInvoice.php
+++ b/app/Jobs/Invoice/CreateXInvoice.php
@@ -88,9 +88,6 @@ class CreateXInvoice implements ShouldQueue
         // Create line items and calculate taxes
         $taxtype1 = "";
         switch ($company->tax_type1){
-            case "Sales Tax":
-                $taxtype1 = "S";
-                break;
             case "ZeroRate":
                 $taxtype1 = "Z";
                 break;
@@ -115,12 +112,12 @@ class CreateXInvoice implements ShouldQueue
             case "Ceuta / Melila":
                 $taxtype1 = "M";
                 break;
+            default:
+                $taxtype1 = "S";
+                break;
         }
         $taxtype2 = "";
         switch ($company->tax_type2){
-            case "Sales Tax":
-                $taxtype2 = "S";
-                break;
             case "ZeroRate":
                 $taxtype2 = "Z";
                 break;
@@ -145,12 +142,12 @@ class CreateXInvoice implements ShouldQueue
             case "Ceuta / Melila":
                 $taxtype2 = "M";
                 break;
+            default:
+                $taxtype2 = "S";
+                break;
         }
         $taxtype3 = "";
         switch ($company->tax_type3){
-            case "Sales Tax":
-                $taxtype3 = "S";
-                break;
             case "ZeroRate":
                 $taxtype3 = "Z";
                 break;
@@ -175,6 +172,9 @@ class CreateXInvoice implements ShouldQueue
             case "Ceuta / Melila":
                 $taxtype3 = "M";
                 break;
+            default:
+                $taxtype3 = "S";
+                break;
         }
         $taxamount_1 = $taxamount_2 = $taxamount_3 = $taxnet_1 = $taxnet_2 = $taxnet_3 = 0.0;
         $netprice = 0.0;