Cutlery/invoiceninja
1
0
Fork 0
mirror of https://github.com/invoiceninja/invoiceninja.git synced 2025-05-24 02:14:21 -04:00
Code Issues Packages Projects Releases Wiki Activity

Tests for custom validation rules

Browse Source
This commit is contained in:
David Bomba 2021-10-23 12:07:54 +11:00
parent f270fbe2d6
commit 8dcdccb9c7
2 changed files with 145 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/Http/ValidationRules/ValidAmount.php
View File

@ -26,7 +26,8 @@ class ValidAmount implements Rule
*/
public function passes($attribute, $value)
{
return (bool) is_float($value) || preg_match('#[^0-9]#',$value);
return trim($value, '-1234567890.,') === '';
}
/**

143
tests/Integration/Validation/AmountValidationRuleTest.php Normal file
View File

@ -0,0 +1,143 @@
<?php
/**
* Invoice Ninja (https://invoiceninja.com).
*
* @link https://github.com/invoiceninja/invoiceninja source repository
*
* @copyright Copyright (c) 2021. Invoice Ninja LLC (https://invoiceninja.com)
*
* @license https://opensource.org/licenses/AAL
*/
namespace Tests\Integration\Validation;
use App\Http\ValidationRules\ValidAmount;
use Tests\TestCase;
/**
* @test
*/
class AmountValidationRuleTest extends TestCase
{
public function setUp() :void
{
parent::setUp();
}
public function testSimpleAmountValid()
{
$rules = [
'amount' => [new ValidAmount()]
];
$data = [
'amount' => 1,
];
$v = $this->app['validator']->make($data, $rules);
$this->assertTrue($v->passes());
}
public function testInvalidAmountValid()
{
$rules = [
'amount' => [new ValidAmount()]
];
$data = [
'amount' => "aa",
];
$v = $this->app['validator']->make($data, $rules);
$this->assertFalse($v->passes());
}
public function testIllegalChars()
{
$rules = [
'amount' => [new ValidAmount()]
];
$data = [
'amount' => "5+5",
];
$v = $this->app['validator']->make($data, $rules);
$this->assertFalse($v->passes());
}
public function testIllegalCharsNaked()
{
$rules = [
'amount' => [new ValidAmount()]
];
$data = [
'amount' => 5+5, //resolves as 10 - but in practice, i believe this amount is wrapped in quotes so interpreted as a string
];
$v = $this->app['validator']->make($data, $rules);
$this->assertTrue($v->passes());
}
public function testinValidScenario1()
{
$rules = [
'amount' => [new ValidAmount()]
];
$data = [
'amount' => "-10x",
];
$v = $this->app['validator']->make($data, $rules);
$this->assertFalse($v->passes());
}
public function testValidScenario2()
{
$rules = [
'amount' => [new ValidAmount()]
];
$data = [
'amount' => -10,
];
$v = $this->app['validator']->make($data, $rules);
$this->assertTrue($v->passes());
}
public function testValidScenario3()
{
$rules = [
'amount' => [new ValidAmount()]
];
$data = [
'amount' => "-10",
];
$v = $this->app['validator']->make($data, $rules);
$this->assertTrue($v->passes());
}
public function testInValidScenario4()
{
$rules = [
'amount' => [new ValidAmount()]
];
$data = [
'amount' => "-0 1",
];
$v = $this->app['validator']->make($data, $rules);
$this->assertFalse($v->passes());
}
}