From 913599334b15eb1d1ea0622615f87dc3178f2ae2 Mon Sep 17 00:00:00 2001 From: David Bomba Date: Mon, 15 May 2023 14:38:11 +1000 Subject: [PATCH] Fixes for Zip Tax Response --- app/DataMapper/Tax/US/Rule.php | 2 ++ app/Services/Tax/Providers/ZipTax.php | 19 +++++++++++++------ 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/app/DataMapper/Tax/US/Rule.php b/app/DataMapper/Tax/US/Rule.php index f22e09b612e4..d012aae93089 100644 --- a/app/DataMapper/Tax/US/Rule.php +++ b/app/DataMapper/Tax/US/Rule.php @@ -144,6 +144,8 @@ class Rule extends BaseRule implements RuleInterface */ public function default(): self { +nlog("default rate"); +nlog($this->tax_data); if($this->tax_data?->stateSalesTax == 0) { diff --git a/app/Services/Tax/Providers/ZipTax.php b/app/Services/Tax/Providers/ZipTax.php index 7c73c0aeba95..dd882833a278 100644 --- a/app/Services/Tax/Providers/ZipTax.php +++ b/app/Services/Tax/Providers/ZipTax.php @@ -31,17 +31,17 @@ class ZipTax implements TaxProviderInterface $response = $this->callApi(['key' => $this->api_key, 'address' => $string_address]); - if($response->successful()) - return $response->json(); + if($response->successful()){ + + return $this->parseResponse($response->json()); + + } if(isset($this->address['postal_code'])) { $response = $this->callApi(['key' => $this->api_key, 'address' => $this->address['postal_code']]); - nlog($response->json()); - nlog($response->body()); - if($response->successful()) - return $response->json(); + return $this->parseResponse($response->json()); } @@ -69,4 +69,11 @@ class ZipTax implements TaxProviderInterface return $response; } + + private function parseResponse($response) + { + $tax = $response['results']['0']; + + return $tax; + } }