diff --git a/app/Utils/Traits/MakesTimezoneAdjustment.php b/app/Utils/Traits/MakesDates.php similarity index 84% rename from app/Utils/Traits/MakesTimezoneAdjustment.php rename to app/Utils/Traits/MakesDates.php index 0e7a25915b0a..d723e3f8e1d2 100644 --- a/app/Utils/Traits/MakesTimezoneAdjustment.php +++ b/app/Utils/Traits/MakesDates.php @@ -3,10 +3,10 @@ namespace App\Utils\Traits; /** - * Class MakesTimezoneAdjustment + * Class MakesDates * @package App\Utils\Traits */ -trait MakesTimezoneAdjustment +trait MakesDates { public function createClientDate($utc_date , $timezone) diff --git a/tests/Unit/TimezoneTraitTest.php b/tests/Unit/MakesDatesTest.php similarity index 83% rename from tests/Unit/TimezoneTraitTest.php rename to tests/Unit/MakesDatesTest.php index 2b5bc272976f..3d8bbb8614cf 100644 --- a/tests/Unit/TimezoneTraitTest.php +++ b/tests/Unit/MakesDatesTest.php @@ -2,18 +2,23 @@ namespace Tests\Unit; -use App\Utils\Traits\MakesTimezoneAdjustment; +use App\Utils\Traits\MakesDates; use Tests\TestCase; /** * @test - * @covers App\Utils\Traits\MakesTimezoneAdjustment + * @covers App\Utils\Traits\MakesDates */ -class TimezoneTraitTest extends TestCase +class MakesDatesTest extends TestCase { - use MakesTimezoneAdjustment; + use MakesDates; +/* + * tests may break with daylight savings changes ( as PHP handle DST under the hood ) + * these tests are to confirm the timezone conversions + * work as expected at this point in time. + */ public function testConvertClientDateToUTCDateTimeTickOverSameDay() {