From 9fba49009c640689e96f7397d6ee9fbea2af19a4 Mon Sep 17 00:00:00 2001
From: Hillel Coren <hillelcoren@gmail.com>
Date: Thu, 28 Sep 2017 11:42:20 +0300
Subject: [PATCH] Working on time tracker

---
 resources/lang/en/texts.php                   |  2 +-
 resources/views/tasks/time_tracker.blade.php  | 12 ++--
 .../tasks/time_tracker_knockout.blade.php     | 68 ++++++++++++-------
 3 files changed, 52 insertions(+), 30 deletions(-)

diff --git a/resources/lang/en/texts.php b/resources/lang/en/texts.php
index e2359193383a..36aae5445d9f 100644
--- a/resources/lang/en/texts.php
+++ b/resources/lang/en/texts.php
@@ -2467,7 +2467,7 @@ $LANG = array(
     'stopped' => 'Stopped',
     'ascending' => 'Ascending',
     'descending' => 'Descending',
-    'direction' => 'Direction',
+    'sort_direction' => 'Direction',
 
 );
 
diff --git a/resources/views/tasks/time_tracker.blade.php b/resources/views/tasks/time_tracker.blade.php
index 7372884ab1a2..8b690a2d8fe4 100644
--- a/resources/views/tasks/time_tracker.blade.php
+++ b/resources/views/tasks/time_tracker.blade.php
@@ -235,18 +235,18 @@
 						<div class="row">
 							<div class="col-md-6" style="padding-top:24px;">
 								{!! Former::select('sort_by')
-								 		->addOption(trans('texts.date'), 'date')
+								 		->addOption(trans('texts.date'), 'createdAt')
 										->addOption(trans('texts.duration'), 'duration')
 										->addOption(trans('texts.client'), 'client')
 										->addOption(trans('texts.project'), 'project')
 										->addOption(trans('texts.description'), 'description')
-										->data_bind('value: sortBy') !!}
+										->data_bind('value: sortBy, event: {change: onSortChange}') !!}
 							</div>
 							<div class="col-md-6" style="padding-top:24px;">
-								{!! Former::select('direction')
-										->addOption(trans('texts.ascending'), 'asc')
-										->addOption(trans('texts.descending'), 'desc')
-										->data_bind('value: sortDirection') !!}
+								{!! Former::select('sort_direction')
+										->addOption(trans('texts.ascending'), 'ascending')
+										->addOption(trans('texts.descending'), 'descending')
+										->data_bind('value: sortDirection, event: {change: onSortChange}') !!}
 							</div>
 						</div>
 					</div>
diff --git a/resources/views/tasks/time_tracker_knockout.blade.php b/resources/views/tasks/time_tracker_knockout.blade.php
index a1313febcfa9..e581595e4bdd 100644
--- a/resources/views/tasks/time_tracker_knockout.blade.php
+++ b/resources/views/tasks/time_tracker_knockout.blade.php
@@ -14,8 +14,8 @@
         self.selectedProject = ko.observable(false);
 
         self.filterState = ko.observable('all');
-        self.sortBy = ko.observable('date');
-        self.sortDirection = ko.observable('desc');
+        self.sortBy = ko.observable('createdAt');
+        self.sortDirection = ko.observable('descending');
 
         self.isDesktop = function() {
             return navigator.userAgent == 'Time Tracker';
@@ -31,6 +31,10 @@
             task.save(data, true);
         }
 
+        self.onSortChange = function() {
+            console.log('sort change...');
+        }
+
         self.onFilterClick = function(event) {
             $('#filterPanel').toggle();
         }
@@ -323,14 +327,10 @@
         }
 
         self.filteredTasks = ko.computed(function() {
-
             var tasks = self.tasks();
 
-            // bind to fields
-            self.filterState();
-
             var filtered = ko.utils.arrayFilter(tasks, function(task) {
-                return task.matchesFilter();
+                return task.matchesFilter(self.filter(), self.filterState());
             });
 
             if (! self.filter() || filtered.length > 0) {
@@ -339,12 +339,21 @@
 
             // sort the data
             tasks.sort(function (left, right) {
-                return right.createdAt() - left.createdAt();
-                /*
-                right = right.firstTime() ? right.firstTime().order() : right.createdAt();
-                left = left.firstTime() ? left.firstTime().order() : left.createdAt();
-                return right - left;
-                */
+                var leftSortValue = left.sortValue(self.sortBy());
+                var rightSortValue = right.sortValue(self.sortBy());
+                if (self.sortBy() == 'createdAt' || self.sortBy() == 'duration') {
+                    if (self.sortDirection() == 'descending') {
+                        return rightSortValue - leftSortValue
+                    } else {
+                        return leftSortValue - rightSortValue;
+                    }
+                } else {
+                    if (self.sortDirection() == 'ascending') {
+                        return leftSortValue.localeCompare(rightSortValue);
+                    } else {
+                        return rightSortValue.localeCompare(leftSortValue);
+                    }
+                }
             });
 
             return tasks;
@@ -560,6 +569,18 @@
             self.update(data);
         }
 
+        self.sortValue = function(field) {
+            if (field == 'client') {
+                return self.client() && self.client().displayName() ? self.client().displayName().toLowerCase() : '';
+            } else if (field == 'project') {
+                return self.project() && self.project().name() ? self.project().name().toLowerCase() : '';
+            } else if (field == 'duration') {
+                return self.seconds(true);
+            } else {
+                return self[field]();
+            }
+        }
+
         self.isNew = ko.computed(function() {
             return ! self.public_id();
         });
@@ -595,8 +616,8 @@
             return times;
         }
 
-        self.matchesFilter = function() {
-            if (model.filter()) {
+        self.matchesFilter = function(filter, filterState) {
+            if (filter) {
                 filter = model.filter().toLowerCase();
                 var parts = filter.split(' ');
                 for (var i=0; i<parts.length; i++) {
@@ -625,9 +646,9 @@
                 }
             }
 
-            if (model.filterState() == 'stopped' && self.isRunning()) {
+            if (filterState == 'stopped' && self.isRunning()) {
                 return false;
-            } else if (model.filterState() == 'running' && ! self.isRunning()) {
+            } else if (filterState == 'running' && ! self.isRunning()) {
                 return false;
             }
 
@@ -740,9 +761,9 @@
             return time.age();
         });
 
-        self.calcDuration = function(total) {
+        self.seconds = function(total) {
             if (! self.time_log().length) {
-                return '0:00:00';
+                return moment.duration(0);
             }
             var time = self.lastTime();
             var now = new Date().getTime();
@@ -756,18 +777,19 @@
                 });
             }
 
-            var duration = moment.duration(duration * 1000);
-            return Math.floor(duration.asHours()) + moment.utc(duration.asMilliseconds()).format(":mm:ss");
+            return moment.duration(duration * 1000);
         }
 
         self.totalDuration = ko.computed(function() {
             model.clock(); // bind to the clock
-            return self.calcDuration(true);
+            var duration = self.seconds(true);
+            return Math.floor(duration.asHours()) + moment.utc(duration.asMilliseconds()).format(":mm:ss");
         });
 
         self.duration = ko.computed(function() {
             model.clock(); // bind to the clock
-            return self.calcDuration(false);
+            var duration = self.seconds(false);
+            return Math.floor(duration.asHours()) + moment.utc(duration.asMilliseconds()).format(":mm:ss");
         });
     }