Support updating products when importing

app/Ninja/Import/BaseTransformer.php

@@ -101,35 +101,17 @@ class BaseTransformer extends TransformerAbstract
      *
      * @return null
      */
-    public function getProductId($name)
+    public function getProduct($data, $key, $field, $default = false)
     {
-        $name = strtolower(trim($name));
+        $productKey = trim(strtolower($data->$key));
 
-        return isset($this->maps[ENTITY_PRODUCT][$name]) ? $this->maps[ENTITY_PRODUCT][$name] : null;
+        if (! isset($this->maps['product'][$productKey])) {
-    }
+            return $default;
+        }
 
-    /**
+        $product = $this->maps['product'][$productKey];
-     * @param $name
-     *
-     * @return null
-     */
-    public function getProductNotes($name)
-    {
-        $name = strtolower(trim($name));
 
-        return isset($this->maps['product_notes'][$name]) ? $this->maps['product_notes'][$name] : null;
+        return $product->$field ?: $default;
-    }
-
-    /**
-     * @param $name
-     *
-     * @return null
-     */
-    public function getProductCost($name)
-    {
-        $name = strtolower(trim($name));
-
-        return isset($this->maps['product_cost'][$name]) ? $this->maps['product_cost'][$name] : null;
     }
 
     /**

app/Ninja/Import/CSV/InvoiceTransformer.php

@@ -38,8 +38,8 @@ class InvoiceTransformer extends BaseTransformer
                 'invoice_items' => [
                     [
                         'product_key' => $this->getString($data, 'product'),
-                        'notes' => $this->getString($data, 'notes') ?: $this->getProductNotes($this->getString($data, 'product')),
+                        'notes' => $this->getString($data, 'notes') ?: $this->getProduct($data, 'product', 'notes', ''),
-                        'cost' => $this->getFloat($data, 'amount') ?: $this->getProductCost($this->getString($data, 'product')),
+                        'cost' => $this->getFloat($data, 'amount') ?: $this->getProduct($data, 'product', 'cost', 0),
                         'qty' => $this->getFloat($data, 'quantity') ?: 1,
                         'tax_name1' => $this->getTaxName($this->getString($data, 'tax1')),
                         'tax_rate1' => $this->getTaxRate($this->getString($data, 'tax1')),

app/Ninja/Import/CSV/ProductTransformer.php

@@ -23,6 +23,7 @@ class ProductTransformer extends BaseTransformer
 
         return new Item($data, function ($data) {
             return [
+                'public_id' => $this->getProduct($data, 'product_key', 'public_id'),
                 'product_key' => $this->getString($data, 'product_key'),
                 'notes' => $this->getString($data, 'notes'),
                 'cost' => $this->getFloat($data, 'cost'),

app/Ninja/Repositories/ProductRepository.php

@@ -17,6 +17,7 @@ class ProductRepository extends BaseRepository
     {
         return Product::scope()
                 ->withTrashed()
+                ->where('is_deleted', '=', false)
                 ->get();
     }
 
@@ -54,7 +55,7 @@ class ProductRepository extends BaseRepository
         if ($product) {
             // do nothing
         } elseif ($publicId) {
-            $product = Product::scope($publicId)->firstOrFail();
+            $product = Product::scope($publicId)->withArchived()->firstOrFail();
             \Log::warning('Entity not set in product repo save');
         } else {
             $product = Product::createNew();

app/Services/ImportService.php

@@ -933,9 +933,7 @@ class ImportService
     private function addProductToMaps(Product $product)
     {
         if ($key = strtolower(trim($product->product_key))) {
-            $this->maps['product'][$key] = $product->id;
+            $this->maps['product'][$key] = $product;
-            $this->maps['product_notes'][$key] = $product->notes;
-            $this->maps['product_cost'][$key] = $product->cost;
         }
     }
 

resources/lang/en/texts.php

@@ -1330,7 +1330,7 @@ $LANG = array(
     'import_products' => 'Import Products',
     'products_will_create' => 'products will be created',
     'product_key' => 'Product',
-    'created_products' => 'Successfully created :count product(s)',
+    'created_products' => 'Successfully created/updated :count product(s)',
     'export_help' => 'Use JSON if you plan to import the data into Invoice Ninja.<br/>The file includes clients, products, invoices, quotes and payments.',
     'JSON_file' => 'JSON File',